From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Tue, 09 Feb 2021 08:42:26 +0200 Message-ID: <87czx9u4h9.fsf@protesilaos.com> References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87im73m4ki.fsf@gnus.org> <87im72o6r6.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20891"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46358@debbugs.gnu.org, Lars Ingebrigtsen , Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 07:43:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Mk7-0005Li-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 07:43:23 +0100 Original-Received: from localhost ([::1]:37988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Mk6-0005GT-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 01:43:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9Mjm-0005GL-Ub for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 01:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9Mjm-0002D2-Mj for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 01:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9Mjm-0007IM-Io for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 01:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2021 06:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161285296128015 (code B ref 46358); Tue, 09 Feb 2021 06:43:02 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 9 Feb 2021 06:42:41 +0000 Original-Received: from localhost ([127.0.0.1]:52416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9MjR-0007Hn-5w for submit@debbugs.gnu.org; Tue, 09 Feb 2021 01:42:41 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9MjM-0007HV-SS for 46358@debbugs.gnu.org; Tue, 09 Feb 2021 01:42:40 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id DD2A5E0007; Tue, 9 Feb 2021 06:42:28 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Tue, 9 Feb 2021 01:24:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199657 Archived-At: On 2021-02-09, 01:24 +0200, Dmitry Gutov wrote: > On 08.02.2021 20:17, Juri Linkov wrote: >>>> Very well! I am doing just that in the revised patch. So there should >>>> be no visual difference between this and the prior state, except for one >>>> case: the empty Git stash header, which will ultimately inherit from >>>> 'shadow' (before there was a "FIXME" to disambiguate it from other >>>> header values). >>> >>> Looks good to me; pushed to Emacs 28 now. >> I don't know if anyone else has such problem, but now highlighting >> the empty Git stash header with a different color distinguishes it >> from other header lines, and thus attracts more attention. >> So now the most noticeable thing in the vc-dir is the Git stash header >> (that I almost never use). > > It looks okay-ish for me, but that must depend on a particular theme. For the default theme, the headers are green while their values are orange. The value of an empty stash is gray right now, while that of a non-empty one is orange, just like the other headers' values. >> Maybe better to display the empty Git stash header using the default >> colors, and then highlight it differently only when it's non-empty? > > Not with vc-dir-ignored, though (it is based on the 'shadow' face). Before this change, the empty stash looked the same as all other headers' values. This meant that there was no distinction between empty and non-empty stashes, something that was noted as a "FIXME" in the source code. I think there is value in distinguishing between those two states, though I am fine with some other choice of fallback color/face. Currently the empty stash uses 'vc-dir-ignored' which inherits from 'shadow'. Whereas others use 'vc-dir-header-value' which inherit from 'font-lock-variable-name-face'. If you feel this is a problem 'vc-dir-ignored' could also inherit from 'font-lock-variable-name-face'. -- Protesilaos Stavrou protesilaos.com