From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Trust me I am a Doctor Newsgroups: gmane.emacs.bugs Subject: bug#49069: 28.0.50; [PATCH] Use display-buffer for re-builder Date: Tue, 29 Jun 2021 23:50:19 +0200 Message-ID: <87czs4xqn7.fsf@riseup.net> References: <87r1h1jnf2.fsf@riseup.net> <87a6npf7pr.fsf@riseup.net> <871r90fsoq.fsf@riseup.net> <87o8boy8cd.fsf@riseup.net> <87pmw4tn2t.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12621"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49069@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 30 00:18:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyM3X-00034t-5r for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Jun 2021 00:18:11 +0200 Original-Received: from localhost ([::1]:37656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyM3W-0006f3-7Z for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Jun 2021 18:18:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyM3O-0006eg-H9 for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 18:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyM3O-0003L2-8P for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 18:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyM3N-000401-TF for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 18:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Trust me I am a Doctor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jun 2021 22:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49069 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49069-submit@debbugs.gnu.org id=B49069.162500504415327 (code B ref 49069); Tue, 29 Jun 2021 22:18:01 +0000 Original-Received: (at 49069) by debbugs.gnu.org; 29 Jun 2021 22:17:24 +0000 Original-Received: from localhost ([127.0.0.1]:55867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyM2l-0003z9-QT for submit@debbugs.gnu.org; Tue, 29 Jun 2021 18:17:24 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:53460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyM2j-0003yv-4Z for 49069@debbugs.gnu.org; Tue, 29 Jun 2021 18:17:21 -0400 Original-Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4GDzNq0v8nzDv4g; Tue, 29 Jun 2021 15:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1625005035; bh=vGXtquhGWR/8oUQUJlgeQpuVoO7kQLA/MLuONNrM+rM=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=Og0Vf3ifg+UMdSAv8gQlOwoGfbmrSuUNbMu98/efGLarJZDftU+6w4haGqia4m3jz D2mgWwjQr9qjpAtgkCDXlpGOsIMcn60ZdMSXqiHmeYZrTdseebX62Iy0YWAFG2ew2v 72QMHWS4kvowTrmhZwVY5xzyDWWOcANRRKva3waU= X-Riseup-User-ID: 598FEBD73E8B0428C8407D919E1CEC77FC30953E09A9FDAB3A8BB70E8668E7B4 Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4GDzNm33dNz5vsV; Tue, 29 Jun 2021 15:17:11 -0700 (PDT) In-reply-to: <87pmw4tn2t.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209127 Archived-At: Juri Linkov writes: >> But maybe we don't care at all about user customizations, the point being >> rather to stop the re-builder window to be stealed by other buffers, and >> to clean it on kill-buffer, then we could use >> 'display-buffer-overriding-actions'. > > Sorry, preventing the users from customizing windows is the wrong thing. I don't know really, let me explain my rational : some users have a very constrained display-buffer-alist and match ".*". You can see such rational explained at the end of this page : https://github.com/nex3/perspective-el This kind of constraint may be even more important for people with low vision, as emacs poping windows on a display of 40 columns by 9 lines is very disruptive. So with a display-buffer-alist matching ".*", the rule will pop the re-buffer as the main window, and this create a poor interaction : the targeted buffer not being visible anymore, the re-buffer taking a full window. If really the user customization of the display of re-builder is a thing, I could put a variable as user-customization to split the apple in two. But I may be wrong, after all that's not my case. Anyway I put a pop-to-buffer in the last patch where I should kept display-buffer.