From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Juri Linkov <juri@linkov.net>,
39121@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select
Date: Sun, 25 Jul 2021 08:41:14 +0200 [thread overview]
Message-ID: <87czr6zyid.fsf@gnus.org> (raw)
In-Reply-To: <CB698B4A-78A9-457F-A162-3E32280820FB@acm.org> ("Mattias Engdegård"'s message of "Sat, 24 Jul 2021 19:29:57 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> All right, this might work. Patch!
Skimming the patch, it makes sense to me. (But I didn't try it.)
> The immediate visible benefit is that all matches on the same line are
> highlighted, not just the first one. It also fixes the compatibility
> problems mentioned above by removing occur-highlight-regexp entirely.
>
> External packages that populate occur-mode buffers themselves should
> still work, since the old `occur-target` property format is still
> recognised. In those cases we just highlight from the first match to
> the end of the line.
Great; go ahead and push.
(And I see that `occur-highlight-regexp' was introduced after emacs-27,
so it's indeed OK to just remove it like your patch does.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-07-25 6:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CD8A4158-1AD5-4997-8F36-8F8E7DF9BD32@acm.org>
2021-07-15 22:10 ` bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Juri Linkov
2021-07-16 13:20 ` Mattias Engdegård
2021-07-23 13:32 ` Mattias Engdegård
2021-07-23 14:05 ` Lars Ingebrigtsen
2021-07-23 17:16 ` Mattias Engdegård
2021-07-24 11:46 ` Lars Ingebrigtsen
2021-07-24 17:29 ` Mattias Engdegård
2021-07-25 6:41 ` Lars Ingebrigtsen [this message]
2021-07-25 9:16 ` Eli Zaretskii
2021-07-25 10:55 ` Mattias Engdegård
2021-07-25 11:39 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 14:45 ` Mattias Engdegård
2021-07-25 11:49 ` Eli Zaretskii
2021-07-25 15:09 ` Mattias Engdegård
2021-07-25 16:27 ` Eli Zaretskii
2021-07-25 18:54 ` Mattias Engdegård
2021-07-25 19:23 ` Eli Zaretskii
2021-07-25 19:30 ` Mattias Engdegård
2021-07-26 12:43 ` Eli Zaretskii
2021-07-25 10:06 ` Mattias Engdegård
2020-01-13 20:51 Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czr6zyid.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=39121@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=mattiase@acm.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).