From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45072: 28.0.50; Emacs switches other buffer back uncontrollably, if other window's buffer is changed by user during minibuffer editing Date: Wed, 04 Aug 2021 11:39:04 +0300 Organization: LINKOV.NET Message-ID: <87czqtbo47.fsf@mail.linkov.net> References: <86eek3hvu5.fsf@protected.rcdrun.com> <87eek1fvgf.fsf@gnus.org> <83eek18ref.fsf@gnu.org> <835z5d8lhc.fsf@gnu.org> <87lfe8jsok.fsf@gnus.org> <83h7ow70ty.fsf@gnu.org> <7a7c3ef0-619d-cd76-a4e4-040009e33d75@gmx.at> <87fsvr55n7.fsf@linkov.net> <87im0lhfbq.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19677"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: bugs@gnu.support, 45072@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 04 10:47:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBCYd-0004u0-Rp for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Aug 2021 10:47:23 +0200 Original-Received: from localhost ([::1]:33730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBCYc-0005zS-KQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Aug 2021 04:47:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBCYJ-0005zB-A0 for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 04:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBCYJ-00063p-2l for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 04:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBCYJ-0007HY-1B for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 04:47:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Aug 2021 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45072 X-GNU-PR-Package: emacs Original-Received: via spool by 45072-submit@debbugs.gnu.org id=B45072.162806680227002 (code B ref 45072); Wed, 04 Aug 2021 08:47:02 +0000 Original-Received: (at 45072) by debbugs.gnu.org; 4 Aug 2021 08:46:42 +0000 Original-Received: from localhost ([127.0.0.1]:42703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBCXy-00071D-0z for submit@debbugs.gnu.org; Wed, 04 Aug 2021 04:46:42 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBCXw-0006v3-Dx for 45072@debbugs.gnu.org; Wed, 04 Aug 2021 04:46:40 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A24656000D; Wed, 4 Aug 2021 08:46:32 +0000 (UTC) In-Reply-To: <87im0lhfbq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 04 Aug 2021 08:52:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211144 Archived-At: >> + ;; When read_minibuf doesn't restore all previous windows, >> + ;; then at least pop down the completions window. >> + (unless read-minibuffer-restore-windows >> + (minibuffer-hide-completions)) > > Hm... Well, I guess that's what most people would want... but... The new option read-minibuffer-restore-windows is quite unusable without the above change: selecting a completion from the completions buffer will leave the completions buffer on the screen. > should it be user-controllable? Perhaps read_minibuffer_restore_windows > shouldn't be a boolean, but allow values like t, 'completions and nil, > where 'completions would trigger this behaviour? Then I propose a new hook, e.g. read-minibuffer-restore-functions with the default value '(minibuffer-hide-completions). Then such hook could be run instead of restoring the window configuration, i.e. the logic could be: if (read_minibuffer_restore_windows) record_unwind_protect (restore_window_configuration, list3 (Fcurrent_window_configuration (Qnil), Qt, Qt)); else safe_run_hooks (Qread_minibuffer_restore_functions);