From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50320: 28.0.50; Recent changes cause functions in sh-script-mode to be indented incorrectly Date: Thu, 02 Sep 2021 08:44:54 +0200 Message-ID: <87czprcw7t.fsf@gnus.org> References: <87v93j33k9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11277"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Diego , 50320@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 08:46:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLgUN-0002gz-It for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 08:46:19 +0200 Original-Received: from localhost ([::1]:40458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLgUM-0000Eb-5c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 02:46:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLgU6-00005J-DW for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 02:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLgU6-0003eL-4o for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 02:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLgU5-00017Y-Qh for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 02:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 06:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50320 X-GNU-PR-Package: emacs Original-Received: via spool by 50320-submit@debbugs.gnu.org id=B50320.16305651091172 (code B ref 50320); Thu, 02 Sep 2021 06:46:01 +0000 Original-Received: (at 50320) by debbugs.gnu.org; 2 Sep 2021 06:45:09 +0000 Original-Received: from localhost ([127.0.0.1]:39483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLgTF-0000IZ-0s for submit@debbugs.gnu.org; Thu, 02 Sep 2021 02:45:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:40644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLgTC-0000AA-Sq for 50320@debbugs.gnu.org; Thu, 02 Sep 2021 02:45:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=M7DyfASlriUHU++SlQR+kB0DF/sVVm4T3fnCQ4i5kmU=; b=ENk0Bl3fbXXgD48IakLtgoF2Kr DLB8Qgl4U+MHAwjSjnOZnikZpifKgSj3zMlnVmk4ZPAQXtmCFHbxRVqTkAwvgcIQ4P8pKCqWl69kV Lh618cvSjVf2ZFaD/vOSLOHQz3bnuCtG1UyL6Avc6+O/1k4pX3cz4h7GAPpCDMTy4Rkk=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLgT2-0007Xz-7i; Thu, 02 Sep 2021 08:45:00 +0200 In-Reply-To: <87v93j33k9.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Thu, 02 Sep 2021 08:16:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213230 Archived-At: K=C3=A9vin Le Gouguec writes: >> I'm not quite sure when this behavior was introduced, but I suspect >> commits 4bb70549 or 6392bc37a may be responsible: > > Seems to be 6392bc37a; reverting it makes your test case pass again. I've now reverted the change and added a test. > As things stand, I don't know enough about SMIE to understand what the > correct fix is. A plain revert might be the best immediate action, > unless someone knowledgeable enough can reconcile my commit with Diego's > example. My understanding of SMIE is ... pretty vague. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no