From: Federico Tedin <federicotedin@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: phst@google.com, 49723@debbugs.gnu.org
Subject: bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable
Date: Fri, 17 Sep 2021 21:00:08 +0200 [thread overview]
Message-ID: <87czp7xc1z.fsf@gmail.com> (raw)
In-Reply-To: <83fsu38wuw.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Sep 2021 10:49:59 +0300")
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks. Did you run the test suite after applying the changes, and
> did you see no regressions? If you didn't yet run the test suite,
> please be sure to run all of it, as the use of expand-file-name is
> universal.
I hadn't, so I checked out master aa59d38c59 and applied my patch on top
of it. I then ran "make check" and waited for a bit. There appears to be
only two tests failing in test/lisp/time-stamp-tests.el
('time-stamp-format-day-of-week' and
'time-stamp-format-string-width'). Both seem to be unrelated to my
change; maybe it's my system's strange combination of
Spanish/English/German locale-related configurations (I'm attaching the
log just in case). All other test files were run without problems.
[-- Attachment #2: log --]
[-- Type: text/plain, Size: 10534 bytes --]
Running 135 tests (2021-09-17 20:46:15+0200, selector `(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))')
passed 1/135 formatz-%-10z-hhmm (0.000985 sec)
passed 2/135 formatz-%-10z-seconds (0.001173 sec)
passed 3/135 formatz-%-10z-threedigit (0.000526 sec)
passed 4/135 formatz-%-12z-hhmm (0.000991 sec)
passed 5/135 formatz-%-12z-seconds (0.001199 sec)
passed 6/135 formatz-%-12z-threedigit (0.000558 sec)
passed 7/135 formatz-%-3z-hhmm (0.000924 sec)
passed 8/135 formatz-%-3z-seconds (0.001093 sec)
passed 9/135 formatz-%-3z-threedigit (0.000506 sec)
passed 10/135 formatz-%-z-hhmm (0.000854 sec)
passed 11/135 formatz-%-z-seconds (0.001047 sec)
passed 12/135 formatz-%-z-threedigit (0.000491 sec)
passed 13/135 formatz-%012:::z-hhmm (0.001046 sec)
passed 14/135 formatz-%012:::z-seconds (0.001133 sec)
passed 15/135 formatz-%012:::z-threedigit (0.000583 sec)
passed 16/135 formatz-%012::z-hhmm (0.001066 sec)
passed 17/135 formatz-%012::z-seconds (0.001096 sec)
passed 18/135 formatz-%012::z-threedigit (0.000584 sec)
passed 19/135 formatz-%012:z-hhmm (0.001047 sec)
passed 20/135 formatz-%012:z-seconds (0.001066 sec)
passed 21/135 formatz-%012:z-threedigit (0.000558 sec)
passed 22/135 formatz-%012z-hhmm (0.001053 sec)
passed 23/135 formatz-%012z-seconds (0.001166 sec)
passed 24/135 formatz-%012z-threedigit (0.095949 sec)
passed 25/135 formatz-%03:::z-hhmm (0.000898 sec)
passed 26/135 formatz-%03:::z-seconds (0.000912 sec)
passed 27/135 formatz-%03:::z-threedigit (0.000488 sec)
passed 28/135 formatz-%05z-hhmm (0.000870 sec)
passed 29/135 formatz-%05z-seconds (0.001055 sec)
passed 30/135 formatz-%05z-threedigit (0.000480 sec)
passed 31/135 formatz-%06:::z-hhmm (0.000852 sec)
passed 32/135 formatz-%06:::z-seconds (0.000949 sec)
passed 33/135 formatz-%06:::z-threedigit (0.000495 sec)
passed 34/135 formatz-%06:z-hhmm (0.000839 sec)
passed 35/135 formatz-%06:z-seconds (0.000926 sec)
passed 36/135 formatz-%06:z-threedigit (0.000489 sec)
passed 37/135 formatz-%06z-hhmm (0.000954 sec)
passed 38/135 formatz-%06z-seconds (0.001083 sec)
passed 39/135 formatz-%06z-threedigit (0.000492 sec)
passed 40/135 formatz-%07:::z-hhmm (0.000957 sec)
passed 41/135 formatz-%07:::z-seconds (0.001001 sec)
passed 42/135 formatz-%07:::z-threedigit (0.000532 sec)
passed 43/135 formatz-%07:z-hhmm (0.000938 sec)
passed 44/135 formatz-%07:z-seconds (0.000979 sec)
passed 45/135 formatz-%07:z-threedigit (0.000506 sec)
passed 46/135 formatz-%09::z-hhmm (0.000963 sec)
passed 47/135 formatz-%09::z-seconds (0.000970 sec)
passed 48/135 formatz-%09::z-threedigit (0.000526 sec)
passed 49/135 formatz-%0:::z-hhmm (0.000857 sec)
passed 50/135 formatz-%0:::z-seconds (0.000980 sec)
passed 51/135 formatz-%0:::z-threedigit (0.000534 sec)
passed 52/135 formatz-%0::z-hhmm (0.000964 sec)
passed 53/135 formatz-%0::z-seconds (0.001002 sec)
passed 54/135 formatz-%0::z-threedigit (0.000543 sec)
passed 55/135 formatz-%0:z-hhmm (0.000887 sec)
passed 56/135 formatz-%0:z-seconds (0.000970 sec)
passed 57/135 formatz-%0:z-threedigit (0.094870 sec)
passed 58/135 formatz-%0z-hhmm (0.000828 sec)
passed 59/135 formatz-%0z-seconds (0.000983 sec)
passed 60/135 formatz-%0z-threedigit (0.000470 sec)
passed 61/135 formatz-%10:::z-hhmm (0.001001 sec)
passed 62/135 formatz-%10:::z-seconds (0.001000 sec)
passed 63/135 formatz-%10:::z-threedigit (0.000493 sec)
passed 64/135 formatz-%12:::z-hhmm (0.000864 sec)
passed 65/135 formatz-%12:::z-seconds (0.001001 sec)
passed 66/135 formatz-%12:::z-threedigit (0.000515 sec)
passed 67/135 formatz-%12::z-hhmm (0.000959 sec)
passed 68/135 formatz-%12::z-seconds (0.000998 sec)
passed 69/135 formatz-%12::z-threedigit (0.000530 sec)
passed 70/135 formatz-%12:z-hhmm (0.000921 sec)
passed 71/135 formatz-%12:z-seconds (0.001011 sec)
passed 72/135 formatz-%12:z-threedigit (0.000559 sec)
passed 73/135 formatz-%12z-hhmm (0.000956 sec)
passed 74/135 formatz-%12z-seconds (0.001112 sec)
passed 75/135 formatz-%12z-threedigit (0.000514 sec)
passed 76/135 formatz-%3:::z-hhmm (0.000850 sec)
passed 77/135 formatz-%3:::z-seconds (0.000958 sec)
passed 78/135 formatz-%3:::z-threedigit (0.000514 sec)
passed 79/135 formatz-%5z-hhmm (0.000912 sec)
passed 80/135 formatz-%5z-seconds (0.001076 sec)
passed 81/135 formatz-%5z-threedigit (0.000507 sec)
passed 82/135 formatz-%6:z-hhmm (0.000887 sec)
passed 83/135 formatz-%6:z-seconds (0.000965 sec)
passed 84/135 formatz-%6:z-threedigit (0.000530 sec)
passed 85/135 formatz-%9::z-hhmm (0.000967 sec)
passed 86/135 formatz-%9::z-seconds (0.001021 sec)
passed 87/135 formatz-%9::z-threedigit (0.000549 sec)
passed 88/135 formatz-%:::z-hhmm (0.096159 sec)
passed 89/135 formatz-%:::z-seconds (0.000838 sec)
passed 90/135 formatz-%:::z-threedigit (0.000442 sec)
passed 91/135 formatz-%::z-hhmm (0.000822 sec)
passed 92/135 formatz-%::z-seconds (0.000866 sec)
passed 93/135 formatz-%::z-threedigit (0.000466 sec)
passed 94/135 formatz-%:z-hhmm (0.000757 sec)
passed 95/135 formatz-%:z-seconds (0.000848 sec)
passed 96/135 formatz-%:z-threedigit (0.000466 sec)
passed 97/135 formatz-%_12z-hhmm (0.001074 sec)
passed 98/135 formatz-%_12z-seconds (0.001125 sec)
passed 99/135 formatz-%_12z-threedigit (0.000527 sec)
passed 100/135 formatz-%_7z-hhmm (0.000929 sec)
passed 101/135 formatz-%_7z-seconds (0.001055 sec)
passed 102/135 formatz-%_7z-threedigit (0.000501 sec)
passed 103/135 formatz-%_z-hhmm (0.000903 sec)
passed 104/135 formatz-%_z-seconds (0.001031 sec)
passed 105/135 formatz-%_z-threedigit (0.000492 sec)
passed 106/135 formatz-%z-spotcheck (0.000326 sec)
passed 107/135 formatz-illegal-options (0.000445 sec)
passed 108/135 time-stamp-custom-count (0.000538 sec)
passed 109/135 time-stamp-custom-end (0.000311 sec)
passed 110/135 time-stamp-custom-format-tabs-expand (0.000654 sec)
passed 111/135 time-stamp-custom-inserts-lines (0.000468 sec)
passed 112/135 time-stamp-custom-pattern (0.005087 sec)
passed 113/135 time-stamp-custom-time-zone (0.000375 sec)
passed 114/135 time-stamp-format-am-pm (0.000284 sec)
passed 115/135 time-stamp-format-day-number-in-week (0.000231 sec)
passed 116/135 time-stamp-format-day-of-month (0.000470 sec)
Test time-stamp-format-day-of-week backtrace:
signal(ert-test-failed (((should (equal (time-stamp-string "%3a" ref
ert-fail(((should (equal (time-stamp-string "%3a" ref-time1) Mon)) :
#f(compiled-function () #<bytecode 0xbda32adea3e6e3b>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name time-stamp-format-day-of-week :docume
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/time-stamp-tests" "-
command-line()
normal-top-level()
Test time-stamp-format-day-of-week condition:
(ert-test-failed
((should
(equal
(time-stamp-string "%3a" ref-time1)
Mon))
:form
(equal " Mo" "Mo")
:value nil :explanation
(arrays-of-different-length 3 2 " Mo" "Mo" first-mismatch-at 0)))
FAILED 117/135 time-stamp-format-day-of-week (0.000415 sec)
passed 118/135 time-stamp-format-hours-12 (0.000579 sec)
passed 119/135 time-stamp-format-hours-24 (0.000581 sec)
passed 120/135 time-stamp-format-ignored-modifiers (0.000306 sec)
passed 121/135 time-stamp-format-minute (0.000419 sec)
passed 122/135 time-stamp-format-month-name (0.000326 sec)
passed 123/135 time-stamp-format-month-number (0.000418 sec)
passed 124/135 time-stamp-format-multiple-conversions (0.000698 sec)
passed 125/135 time-stamp-format-non-conversions (0.000174 sec)
passed 126/135 time-stamp-format-non-date-conversions (0.000432 sec)
passed 127/135 time-stamp-format-second (0.000424 sec)
Test time-stamp-format-string-width backtrace:
signal(ert-test-failed (((should (equal (time-stamp-string "%#3a" re
ert-fail(((should (equal (time-stamp-string "%#3a" ref-time3) SUN))
#f(compiled-function () #<bytecode -0xd4dc00a92f30942>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name time-stamp-format-string-width :docum
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/time-stamp-tests" "-
command-line()
normal-top-level()
Test time-stamp-format-string-width condition:
(ert-test-failed
((should
(equal
(time-stamp-string "%#3a" ref-time3)
SUN))
:form
(equal " SO" "SO")
:value nil :explanation
(arrays-of-different-length 3 2 " SO" "SO" first-mismatch-at 0)))
FAILED 128/135 time-stamp-format-string-width (0.000539 sec)
passed 129/135 time-stamp-format-time-zone-name (0.000231 sec)
passed 130/135 time-stamp-format-time-zone-offset (0.000485 sec)
passed 131/135 time-stamp-format-year-2digit (0.000393 sec)
passed 132/135 time-stamp-format-year-4digit (0.000225 sec)
passed 133/135 time-stamp-helper-safe-locals (0.000230 sec)
passed 134/135 time-stamp-helper-string-defaults (0.000352 sec)
passed 135/135 time-stamp-helper-zone-type-p (0.000208 sec)
Ran 135 tests, 133 results as expected, 2 unexpected (2021-09-17 20:46:21+0200, 5.091627 sec)
2 unexpected results:
FAILED time-stamp-format-day-of-week
FAILED time-stamp-format-string-width
next prev parent reply other threads:[~2021-09-17 19:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 17:39 bug#49723: 28.0.50; Test in coding.c for NUL bytes in filenames is not reliable Eli Zaretskii
2021-09-14 19:01 ` Federico Tedin
2021-09-14 19:24 ` Eli Zaretskii
2021-09-14 22:17 ` Federico Tedin
2021-09-16 12:25 ` Eli Zaretskii
2021-09-16 16:58 ` Federico Tedin
2021-09-16 18:12 ` Michael Albinus
2021-09-16 18:30 ` Eli Zaretskii
2021-09-16 18:44 ` Michael Albinus
2021-09-16 19:07 ` Eli Zaretskii
2021-09-16 18:38 ` Federico Tedin
2021-09-16 18:51 ` Michael Albinus
2021-09-16 19:13 ` Federico Tedin
2021-09-20 11:59 ` Michael Albinus
2021-09-17 7:49 ` Eli Zaretskii
2021-09-17 19:00 ` Federico Tedin [this message]
2021-09-18 6:51 ` Eli Zaretskii
2021-09-18 17:57 ` Federico Tedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czp7xc1z.fsf@gmail.com \
--to=federicotedin@gmail.com \
--cc=49723@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).