From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Andr=C3=A9?= A. Gomes Newsgroups: gmane.emacs.bugs Subject: bug#50852: [PATCH] Fix search of the look program. Date: Tue, 28 Sep 2021 12:02:35 +0300 Message-ID: <87czot6pjo.fsf@gmail.com> References: <87wnn17t85.fsf@gmail.com> <87zgrxfdog.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40856"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: 50852@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 28 11:03:34 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mV91R-000AOr-OO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 11:03:33 +0200 Original-Received: from localhost ([::1]:41418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mV91Q-0005WO-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 05:03:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mV90w-0005Ue-Pn for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 05:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60479) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mV90w-0004cC-6B for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 05:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mV90w-0006Im-3r for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 05:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Andr=C3=A9?= A. Gomes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Sep 2021 09:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 50852-submit@debbugs.gnu.org id=B50852.163281976524201 (code B ref 50852); Tue, 28 Sep 2021 09:03:02 +0000 Original-Received: (at 50852) by debbugs.gnu.org; 28 Sep 2021 09:02:45 +0000 Original-Received: from localhost ([127.0.0.1]:43792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV90e-0006IH-Uk for submit@debbugs.gnu.org; Tue, 28 Sep 2021 05:02:45 -0400 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:40549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV90d-0006I3-4l for 50852@debbugs.gnu.org; Tue, 28 Sep 2021 05:02:43 -0400 Original-Received: by mail-lf1-f41.google.com with SMTP id b15so88443171lfe.7 for <50852@debbugs.gnu.org>; Tue, 28 Sep 2021 02:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=jouJoyKYEViAmbSEw/KBo1p4mHjLY2nEd/9kALFn47Q=; b=WKVnSnB5nGuEv1zqm4yxz4SCZjsQMKlidbZaMH1aoELWID7NnNkEU4m02rHiLISPWm Af+tVDF2NvHpz9+X3iao3NHMQdjWcmrmL7CrUeMHi22DvfLtfXqwj/T79RQoCiaCPshG U1HN+LNgfZqDF2XQM1q0c/DUhwdJkuRAD4Et09vA9Q6rQUwztdQckBlia0WS+NbiSPfX D6yrNTQp09zxTRYjHY+vApzjmbcRafnsT6p7ymNqiS3dcwIoedxp+XtfggypvsuwTWse KUK6Pr6CN0FYScu+EVDKxIho/HYg/+tOpPyUJMpE8D0kgXzWHkf4k3idlzYyRtt36gzE z+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jouJoyKYEViAmbSEw/KBo1p4mHjLY2nEd/9kALFn47Q=; b=HphmFOsBfg8Hz7pbfRf4aC7OZBIJOlISQNwZjQaKeBJBQLbqdbhlZj3YJWSOMUCE95 XuQucb7OeQzjhPG8EoyvUaXLbjFXXppxUj7PzbTum+lDuzUZCzndnuYRHzGSEqAoUZxK dYXAujR4vXsY42s8FmeMstg8sZ3KwrxXN3PBBkvG81MgL5/OxSz7oHK8KEFkQ4K6uJ0G qcwu2wga8MKN7LrDt1FZXpy/9fmpiQyQ1UEzzmVlINkzhrGRcoqUi4H1PvejgA9iLwqF 4RlKKZjhyfVtC/ltvESPOX4oEfII30YzemDpgdmreiNs48szn4JIrqDRrnHKH0dYFlNp GWMA== X-Gm-Message-State: AOAM532CmzYGAucgapm/xTIJ6XPLgBWyCWXyMSAF8yGDNH9XQ6OUg0TX 2p0+zWV4TswulSmOJuOurVxeOughjG4= X-Google-Smtp-Source: ABdhPJwqbezxNUbnZpJR5tMCS59r94z1jXqxuoKE031ilt/dk0u3TAVCNoF0c/ESTA1zWGu+zsvi7w== X-Received: by 2002:a05:651c:989:: with SMTP id b9mr4515303ljq.136.1632819756777; Tue, 28 Sep 2021 02:02:36 -0700 (PDT) Original-Received: from guix-xps13 (95-29-46-147.broadband.corbina.ru. [95.29.46.147]) by smtp.gmail.com with ESMTPSA id d20sm1851672lfv.117.2021.09.28.02.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 02:02:36 -0700 (PDT) In-Reply-To: <87zgrxfdog.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 28 Sep 2021 07:54:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215759 Archived-At: Lars Ingebrigtsen writes: > Andr=C3=A9 A. Gomes writes: > >> Here's a more robust way to handle the existence of the look program by >> ispell. GNU Guix users will be happy. > > Thanks; applied to Emacs 28 (but I made the ispell-look-p change more > defensive, in case somebody has set ispell-look-command in their init > file). Makes sense. I was naive. >> There's another aspect worth discussing. The look program doesn't have >> the -r flag (as of today), but ispell handles this case (look at >> ispell-look-options). It seems that look was published around 1979. >> Perhaps it's time to deprecate this flag? > > Do you know when the "-r" flag disappeared? That's a good question. As mentioned above, look is the same in both MacOS and GNU/Linux. The -r flag stands for regexp. It seems odd that a binary search program like look would support regexp. My intuition tells me that once upon a time there was a programme named look whose behaviour resembles that of grep. But what does a kid like me know about Unix and the dinosaurs anyway? :) I'd deprecate support for this odd flag. But ispell-lookup-words should definitely use look, by default, instead of grep.=20=20=20 --=20 Andr=C3=A9 A. Gomes "Free Thought, Free World"