From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, larsi@gnus.org, 50798@debbugs.gnu.org
Subject: bug#50798: 28.0.50; Tab line close button is off-center until it is highlighted with the mouse
Date: Mon, 11 Oct 2021 21:28:27 +0300 [thread overview]
Message-ID: <87czob2z78.fsf@mail.linkov.net> (raw)
In-Reply-To: <83sfx8rcc6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Oct 2021 20:58:33 +0300")
close 50798 28.0.60
quit
>> >> (defface test
>> >> '((t :height 2.0))
>> >> "")
>> >>
>> >> (defface test-highlight
>> >> '((default :inherit test-tab))
>> >> "")
>> >
>> > What did you expect to happen with these definitions of faces?
>>
>> My previous patch avoided inheriting from the face that changes the
>> height of the mouse-highlight face. Maybe it was the right solution?
>
> Did you intend that the face which inherited will NOT have the changed
> size like the one it inherited from? If so, not inheriting is
> probably the easiest solution.
Yes, no need to change size on mouse highlighting, so I pushed this fix.
One possible problem is that some themes might break. But I checked
that modus-themes.el is well-designed, so its face inheritance doesn't break
because its parent face doesn't use the face attribute :height:
`(tab-line-highlight ((,class :inherit modus-themes-active-blue)))
next prev parent reply other threads:[~2021-10-11 18:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8735ptxhzs.fsf.ref@yahoo.com>
2021-09-25 6:54 ` bug#50798: 28.0.50; Tab line close button is off-center until it is highlighted with the mouse Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-25 7:17 ` Lars Ingebrigtsen
2021-09-25 8:00 ` Eli Zaretskii
2021-09-25 8:19 ` Lars Ingebrigtsen
2021-09-25 8:22 ` Eli Zaretskii
2021-09-25 8:30 ` Lars Ingebrigtsen
2021-09-25 18:53 ` Juri Linkov
2021-09-25 19:44 ` Eli Zaretskii
2021-09-26 5:33 ` Lars Ingebrigtsen
2021-09-27 15:39 ` Juri Linkov
2021-09-27 18:40 ` Eli Zaretskii
2021-09-28 18:46 ` Juri Linkov
2021-10-02 10:08 ` Eli Zaretskii
2021-10-02 19:36 ` Juri Linkov
2021-10-03 11:49 ` Eli Zaretskii
2021-10-03 16:51 ` Juri Linkov
2021-10-03 17:22 ` Eli Zaretskii
2021-10-03 17:42 ` Juri Linkov
2021-10-03 18:00 ` Eli Zaretskii
2021-10-04 17:41 ` Juri Linkov
2021-10-04 17:52 ` Eli Zaretskii
2021-10-06 7:16 ` Juri Linkov
2021-10-07 10:13 ` Eli Zaretskii
2021-10-07 12:52 ` Eli Zaretskii
2021-10-10 17:04 ` Juri Linkov
2021-10-10 17:58 ` Eli Zaretskii
2021-10-11 18:28 ` Juri Linkov [this message]
2021-09-25 8:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-25 7:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czob2z78.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=50798@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).