From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places Date: Thu, 11 Nov 2021 06:19:17 +0100 Message-ID: <87czn79smi.fsf@gnus.org> References: <87fsxstdiy.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37220"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 48925@debbugs.gnu.org, miha@kamnitnik.top To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 06:20:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml2VW-0009TM-D7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 06:20:18 +0100 Original-Received: from localhost ([::1]:49936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ml2VU-0004fI-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 00:20:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ml2VH-0004f0-9k for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:20:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ml2VH-0007GZ-0b for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:20:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ml2VG-0001kR-Jg for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 00:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 05:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48925 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48925-submit@debbugs.gnu.org id=B48925.16366079896694 (code B ref 48925); Thu, 11 Nov 2021 05:20:02 +0000 Original-Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 05:19:49 +0000 Original-Received: from localhost ([127.0.0.1]:39852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml2V1-0001js-TQ for submit@debbugs.gnu.org; Thu, 11 Nov 2021 00:19:49 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:50008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ml2Uk-0001j5-RT for 48925@debbugs.gnu.org; Thu, 11 Nov 2021 00:19:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oeXpibJwWloyD3CFOzIGcdRmCDVX5/X54AKCzNaHEkY=; b=STjjX514H35pcob/cdVl3JMweL 9kVgE44be5bOvbhr9NOK2daW72a6hNFg0YFG4bqEebyXIiQb2PvnDmG0GjImj1uv2c2RHxIMPf6Yx aWuQT6CboLCNwr3+5AXjtrDv8ySSQum0rDpcBQglPcGl+2/oniqRfEooLkd1KOaDNVhk=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ml2Ua-0002a0-J8; Thu, 11 Nov 2021 06:19:23 +0100 X-Now-Playing: King Crimson's _The Complete 1969 Recordings (26): BBC Sessions_: "The Court Of The Crimson King" In-Reply-To: (Stefan Monnier's message of "Tue, 20 Jul 2021 10:29:40 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219592 Archived-At: Stefan Monnier writes: >> This follows up on changes proposed in bug#45474. > > Thanks, the first patch looks good to me (assuming it works ;-). So I've now applied it to Emacs 29. It didn't lead to any obvious regressions (or test suite failures) that I can see, which is a good sign. >> The second patch is a bit more controversial, but is probably required >> if we want more reliable usage of completion commands in non-innermost >> minibuffers (that is, with minibuffer-follows-selected-frame set >> to nil.) > > The patch is fundamentally right, but as you say it's a bit more > controversial because it risks exposing bugs. Hmm... > > To be on the safer side, I guess we could replace the > > specbind (Qminibuffer_completion_table, Qnil); > > with a use of `minibuffer-with-setup-hook` that sets the var to nil in > the new minibuffer. But doing it in C is awkward so it would best be > done by moving the function to subr.el. Sounds like a good idea to me. Miha, could you do that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no