unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 51384@debbugs.gnu.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap
Date: Mon, 15 Nov 2021 18:48:00 +0100	[thread overview]
Message-ID: <87czn1nwdr.fsf@gmail.com> (raw)
In-Reply-To: <8635nxcow3.fsf@mail.linkov.net> (Juri Linkov's message of "Mon,  15 Nov 2021 19:25:16 +0200")

>>>>> On Mon, 15 Nov 2021 19:25:16 +0200, Juri Linkov <juri@linkov.net> said:

    Andreas> On Okt 25 2021, Robert Pluim wrote:
    >> >> (substitute-command-keys "\\<undo-repeat-map>\\[undo]")
    >> >> => #("C-x u" 0 5 (face help-key-binding font-lock-face help-key-binding))
    >> 
    Andreas> :advertised-binding takes precedence.
    >> 
    >> So it does, which is unfortunate, underdocumented, and unnecessary,
    >> since just not specifying the map will get you the
    >> :advertised-binding anyway.
    >> 
    >> \\(map) anyone, to mean "really only look up in this map"?

    Juri> For readers of this bug report, here is a link to the discussion:
    Juri> https://lists.gnu.org/archive/html/emacs-devel/2021-10/msg01845.html

I have a change that will cause the lookups to happen in the specified
map first, but I still need to audit the 50 or so uses of a command
with an advertised binding in a docstring in the Emacs sources before
I can declare it safe.

Robert
-- 





  reply	other threads:[~2021-11-15 17:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25  9:57 bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Robert Pluim
2021-10-25 10:16 ` Andreas Schwab
2021-10-25 10:39   ` Robert Pluim
2021-11-15 17:25     ` Juri Linkov
2021-11-15 17:48       ` Robert Pluim [this message]
2022-09-14 18:29         ` Lars Ingebrigtsen
2022-09-15  7:39           ` Robert Pluim
2022-09-15  8:55             ` Robert Pluim
2022-09-15  9:00               ` Andreas Schwab
2022-09-15  9:04                 ` Robert Pluim
2022-09-15 11:54                 ` Drew Adams
2022-09-16  9:29             ` Lars Ingebrigtsen
2022-09-16  9:58               ` Robert Pluim
2022-09-16  9:59                 ` Lars Ingebrigtsen
2022-09-20 15:47                   ` Robert Pluim
2022-09-20 15:51                     ` Lars Ingebrigtsen
2022-09-20 16:41                       ` Robert Pluim
2022-09-20 18:03                         ` Stefan Kangas
2022-09-21  7:17                           ` Robert Pluim
2022-09-21  8:55                             ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czn1nwdr.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=51384@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).