unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dick.r.chiang@gmail.com, 52676@debbugs.gnu.org
Subject: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size
Date: Tue, 21 Dec 2021 20:19:48 +0800	[thread overview]
Message-ID: <87czlqw3ob.fsf@yahoo.com> (raw)
In-Reply-To: <83zgouyx5h.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Dec 2021 14:12:26 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> Well, if you or someone else could produce a "emacs -Q" recipe, I'd be
> interested to take a look.

There's no need for you to take a look, because the code in
`window-text-pixel-size' behaves correctly.

dickmao is saying that his code is the equivalent to calling
`window-text-pixel-size' with `ignore-line-at-end' set to t, which is
not true in the presence of a line-prefix or an overlay with a
before-string, which are both use cases that pixel-scroll-precision has
to handle.

Thanks.





  reply	other threads:[~2021-12-21 12:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  2:32 bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size dick
2021-12-20  3:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-20  5:20   ` dick
2021-12-20 17:11     ` Eli Zaretskii
2021-12-21  1:36       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21  3:30         ` Eli Zaretskii
2021-12-21  3:38           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21 12:12             ` Eli Zaretskii
2021-12-21 12:19               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-12-21 17:56                 ` dick
2021-12-21 18:05                   ` Robert Pluim
2021-12-22  0:59                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21 18:06                   ` Eli Zaretskii
2021-12-22  0:58                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21  1:34     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-20 15:19 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czlqw3ob.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=52676@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).