From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#53805: 27.2; NonGNU ELPA: helm does not install dependencies Date: Sun, 06 Feb 2022 10:12:12 +0000 Message-ID: <87czk0z4lf.fsf@posteo.net> References: <8735kx3zct.fsf@posteo.net> <87a6f4ieue.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31199"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 53805@debbugs.gnu.org, pu.stshine@gmail.com To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 06 11:13:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGeYD-0007ty-7O for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 11:13:45 +0100 Original-Received: from localhost ([::1]:49954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGeYA-0006hh-Sh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 05:13:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGeXX-0006dq-9a for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 05:13:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGeXX-0008CY-01 for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 05:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGeXW-00068o-SK for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 05:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Feb 2022 10:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53805 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Stefan Monnier , 53805@debbugs.gnu.org, Xingyu Pu Original-Received: via spool by 53805-submit@debbugs.gnu.org id=B53805.164414234423552 (code B ref 53805); Sun, 06 Feb 2022 10:13:02 +0000 Original-Received: (at 53805) by debbugs.gnu.org; 6 Feb 2022 10:12:24 +0000 Original-Received: from localhost ([127.0.0.1]:36524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGeWt-00067o-Mn for submit@debbugs.gnu.org; Sun, 06 Feb 2022 05:12:23 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:56379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGeWq-00067J-8q for 53805@debbugs.gnu.org; Sun, 06 Feb 2022 05:12:20 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 84AB5240107 for <53805@debbugs.gnu.org>; Sun, 6 Feb 2022 11:12:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1644142334; bh=1/Iii02seRXG2qnLuxfQQjje2PMZ24PDOEIcQwCO1eg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=SHgy9BYEFa9SsAGdr+tDANP5uBuY4vS/zpuBaTU4IWXQ6kcsPP2TkD4zW6jmb6kIF cyGf29eKpInIIVQL8EZT6VOtbY+zW/QRwgQOMC5Fm3Ywc72Pe6x6k1vFORgntAXoSM lemCwkrcxslFdtRzymmA09pIeln/stASUbtDXBd5ZtiPzgWtQu3ndyK2p5Iq5BYmDs oeonG3uHTuKdWo8ZqMJMuCwbSMJYRxgbDVP2D6lQvsAsunTuypVIF01yMfxtgWVf1s mAWASmmO6zkGMcOSxz+MaAXFyezKGDzOUu93p2BOTyOmgQx+1o7fXoFypjcdIHc+Sb 4bfAT06fcXbnw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Js4nn0GDzz6tm5; Sun, 6 Feb 2022 11:12:13 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87a6f4ieue.fsf@posteo.net> (Thierry Volpiatto's message of "Sun, 06 Feb 2022 08:22:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226145 Archived-At: Thierry Volpiatto writes: > Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >>> It seems to me that the core of the issue is that the ELPA build system >>> overrides the existing -pkg.el files, by trying to infer all the package >>> metadata from the main files (helm.el, helm-core.el). If as in the case >>> of helm and helm-core these are empty, this leads to unexpected results. >> >> The best course of action is to fix the upstream. >> They simply shouldn't have any `-pkg.el` file. > > I disagree, in the simple case of async package this didn't cause problems, but > here it does because we have two packages (helm-core+helm) coming from > the same git repo. What is the issue in this case? The ELPAs already have packages that share common upstream repositories. The main issue here that I see is that helm.el and helm-core.el don't have Package-Requires headers, which is why the dependency list is currently empty. >> We will generate the `-pkg.el` in any case because we include more >> information there than what the upstream will have put (e.g. we include >> the commit id from which the tarball is built), > > So what is the problem? Just append the informations fetched from the > upstream *pkg.el files to the *pkg.el file you are usually building. > I guess it is what Melpa does more or less. > >> and and modifying files that are under version control tends to lead >> to problems. > > You are anyway creating a new *pkg.el file so why do you want to modify > the original *pkg.el files? This is also what the patch I proposed above would do. Or rather the -pkg file is parsed, and later overwritten. -- Philip Kaludercic