From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames Date: Wed, 16 Feb 2022 01:56:56 +0100 Message-ID: <87czjn39yf.fsf@web.de> References: <87li9hk5e5.fsf@web.de> <87wqt1vd0o.fsf@mail.jurta.org> <87d2ut4mji.fsf@web.de> <87620lvavl.fsf@mail.jurta.org> <87zjxxsd6c.fsf@web.de> <87vc8ke4os.fsf@mail.jurta.org> <86zgmutwx9.fsf@mail.linkov.net> <87o83ab67d.fsf@web.de> <86r185520f.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8605"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier , 14013@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 16 01:58:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK8e6-00020N-FC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Feb 2022 01:58:14 +0100 Original-Received: from localhost ([::1]:35002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nK8e5-0006k8-Dm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Feb 2022 19:58:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nK8du-0006iJ-CY for bug-gnu-emacs@gnu.org; Tue, 15 Feb 2022 19:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nK8dt-0006fF-W7 for bug-gnu-emacs@gnu.org; Tue, 15 Feb 2022 19:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nK8dt-0004td-UM for bug-gnu-emacs@gnu.org; Tue, 15 Feb 2022 19:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Feb 2022 00:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14013 X-GNU-PR-Package: emacs Original-Received: via spool by 14013-submit@debbugs.gnu.org id=B14013.164497302918667 (code B ref 14013); Wed, 16 Feb 2022 00:58:01 +0000 Original-Received: (at 14013) by debbugs.gnu.org; 16 Feb 2022 00:57:09 +0000 Original-Received: from localhost ([127.0.0.1]:46790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nK8d2-0004r0-Qf for submit@debbugs.gnu.org; Tue, 15 Feb 2022 19:57:09 -0500 Original-Received: from mout.web.de ([212.227.15.4]:35329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nK8d1-0004qG-0t for 14013@debbugs.gnu.org; Tue, 15 Feb 2022 19:57:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1644973017; bh=udoG3cbC+11KAuQFljWOn2HuD2dVt2d2fLa9lfhj3/s=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=JiKhQtJPuMPsYUamprHI4h1cFrZxtPrd9t7jo+yRcjMCu2HFYE07PvCvAziozXT5/ LBtGDdGYqwwPuT2cT955fqMQkJgA4QfXLOK4iOzdu+psMbHQK3NY6snyHJRwb4t2ra og01WsQj0SnuVUIhEneW5M3t8MPfveRFWOpcQcM0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MALeR-1nRaLq1cEt-00BlDl; Wed, 16 Feb 2022 01:56:57 +0100 In-Reply-To: <86r185520f.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 14 Feb 2022 09:41:04 +0200") X-Provags-ID: V03:K1:45RsPkcnhL0WmlKXR5bPqFCYwyQGiecHwVz3PA0fJDSISLPuYas 82R1WdXXAbYQEhS4gb9SxNjwBrVxQ9byuLn11615KRzhaKVc7Knt7t27ZQGVMtP4CTJ/fdK YJSFYOlXs3tH4XgFuHIv/4SMeplDppXjuikL9T/cdiez7FeDzdA3PhK+oS5gwWdLY0yYa87 wBmqNVZHs3XXc5yJRkT4w== X-UI-Out-Filterresults: notjunk:1;V03:K0:xGjVUBFODIQ=:KLZwAOlyM7M8gXs+3SQya6 RKHLVGhfjwVIEOyAYuPoHkDI7WMf6YFtKBzcputlUhMO3LgxyxV1WXm8K+w5AX5q1Vc1H/XyV OMLxdqJLDU3G1THnzUbzG6kZhFLEgzEKnXRZMo6eJY0b1Rgk79ApgKd14RQS0VKg28b7e4A9U IwcFFeegQvzu8rFEXYow+Rv8jpeP0c1CHKKrj+2P5M49cNUjTI0yTELDqYoLnFNGn+oZK7dMu GBpJRVMEI3cgGwzoeFMea28xiwN6vrX2c8oU18CwrUDMj1nhWWyUUqa7ej+XXQJqCPOA4youW QOxX3vQGr9laGLCS8aOydFzc0OE3W0tbFOLxMV6y79fnbJ/IklBz0ZbTMJE2jP+fJAHjO5Zpk yvEXTbImTy/mhvmcgBgQTY5cDkBuL9C8dMVM7f8gel4n1CbFzrSsp70afMGxfR58tXbzCz0ai KgUde2lje2+6bmYnDIbAXJtxxCStoukQjDxDsdN4yJiBGvkdYR/xuVFj4NfeaOYJCwoml2HRW 8DrqEsg4pPpKbIkHVKu6xOWGJfQBpxm8D09agCbn8r/QYpYX36zVvE6gY6idpcUsdKkMoJsPU Fh2/oZrlYelYBKJEUtz1qEOJvW8H6d/Kv/ju0i8VYbWr88x5N7oWiv7YAZG0mmQbilWMqVk+j RE9ZWf2RO0uygF5It0emov7quwX1U0CcJgzbc8wbeiu7vJeQ4YkyefXtUe232T1/2lxU5ZoEv /FPz/qdlILEyiRjLrBNAwF+qqVRyCbi8DravSrWHbdlhmkUcMxW54SBQmJvUr+CvYRlGNRq0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227019 Archived-At: Juri Linkov writes: > >> (defun wdired-change-to-wdired-mode () > >> @@ -238,8 +239,9 @@ wdired-change-to-wdired-mode > >> (setq-local wdired--old-point (point)) > >> (wdired--set-permission-bounds) > >> (setq-local query-replace-skip-read-only t) > >> - (add-function :after-while (local 'isearch-filter-predicate) > >> - #'wdired-isearch-filter-read-only) > >> + (add-function :around (local 'isearch-search-fun-function) > >> + #'dired-isearch-search-filenames) > >> + (setq-local replace-re-search-function #'dired-isearch-search-filenames) > > > > And: Is it intended that this is unconditional (I would expect a > > `dired-isearch-filenames-mode' test)? > > Currently it is unconditional when it's using isearch-filter-predicate. > So maybe it should be kept this way since it's what was used for many years? > Or is there a reason to change the current behavior? Ok, then better let's keep it. A different thing: I found that | + (setq-local replace-re-search-function #'dired-isearch-search-filenames) is not correct - of course, `dired-isearch-search-filenames' is a higher order function (used for the around advice), not something suitable for searching. With the patch installed query-replace in wdired errors. What's the correct value - the current binding of `isearch-search-fun-function'? Thanks, Michael.