From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Date: Sat, 16 Apr 2022 13:50:39 -0700 Message-ID: <87czhgkb1c.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16425"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu) To: 54976@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 16 22:51:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfpNx-00043s-Dq for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Apr 2022 22:51:15 +0200 Original-Received: from localhost ([::1]:36848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfpNw-0005Po-9N for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Apr 2022 16:51:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfpNm-0005Pf-Dj for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 16:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40519) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nfpNm-0007g2-1z for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 16:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nfpNm-00072h-17 for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 16:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Apr 2022 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54976 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165014224727048 (code B ref -1); Sat, 16 Apr 2022 20:51:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Apr 2022 20:50:47 +0000 Original-Received: from localhost ([127.0.0.1]:34416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfpNW-00072C-Sn for submit@debbugs.gnu.org; Sat, 16 Apr 2022 16:50:47 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:52580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nfpNV-000724-F4 for submit@debbugs.gnu.org; Sat, 16 Apr 2022 16:50:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfpNV-0005NK-2U for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 16:50:45 -0400 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:33289) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfpNT-0007dZ-0B for bug-gnu-emacs@gnu.org; Sat, 16 Apr 2022 16:50:44 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2820B3201FD3 for ; Sat, 16 Apr 2022 16:50:41 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 16 Apr 2022 16:50:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1650142240; x=1650228640; bh=B4LvRv5wyWqgVbtf3Xjxi26xy/bhLZ70WLp Lvjwyszw=; b=VlWClGN0puudYyi1XPxjDJUJc89mvfKQOha+NxqEsu26UUMKXEA vD5HlgRvUOL2M99IF0EUQFU9Y1ELWojr4ncZCIAkDcLJCAeMRz6+v0/dLIVokdyc LTGVI1SsmQZWeq12AwpJv5bb+82RWtXvb53RGM9th02kQtVxSfNs9MVVUQCAyDqQ U0r/CRasc5xtonxpqJEexjJ60oj+NVY3zIKbZxB7GnzQdvB2MJQPjv8/nvs+kTJg mYM13ySdkOXBe86z/gUucSJ1BuUg3wXAQB9Ob7PO+UJD78Iqwy+xWMMeuY03sEx9 EA3RJ82QGDYYeYzv2fh52F23Xp+JWYAK+4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1650142240; x=1650228640; bh=B4LvRv5wyWqgV btf3Xjxi26xy/bhLZ70WLpLvjwyszw=; b=F07SdXyZbAg3g0JI9pjs3cqJPjOcN d1Cs5fi8LZbnkoGZTHpxiDHTdkhsVTCRE4A6mWMUFn+Y9AWhfr1UcMkvo04Y9buz NLGs7ydNS3P9rXyCwxU4uMXZunE2K7k1khSmnbEHE9fQ39vBRjDU1RsPOXdeqjFI lDEfc/4r8Vmg+T1zp9CD6ecVvF+khkX5rg3g9RvbkeV7+/4qZkG62bTgaNU5Z9f9 3zumFK/SJPaCvrUGDnwnPG16FqLWf9z8HPVkJ7zYrprJDmICh8aEqTSQcMEchl8g Xb/6YWlB0MjRrwv3sFqsmX2t20l0buP5eyV1JdCkV27074FGQ9x2QfSWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeljedgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepkeffveegfeetvdetud fhtefffeefheehkeejfeehieffvdejleeltedtueeivdeinecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 16 Apr 2022 16:50:40 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 689437E511F; Sat, 16 Apr 2022 13:50:39 -0700 (MST) Received-SPF: pass client-ip=64.147.123.25; envelope-from=spwhitton@spwhitton.name; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230020 Archived-At: Hello, Suppose you put this in your init.el: (add-to-list 'eshell-modules-list 'eshell-elecslash) because you want to use the new em-elecslash.el module I'm working on. Then if you try to M-x eshell on an older version of Emacs which lacks em-elecslash, Eshell will fail to initialise at all. It is easy add a guard (when (locate-library ...)) or similar, but this is not possible if you have added eshell-elecslash using the customise interface. In that case, by enabling the module, youq just make your init unusable with older Emacs. It would be better to print a warning, say, rather than error. -- Sean Whitton