From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#4359: bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell Date: Thu, 05 May 2022 14:42:49 +0200 Message-ID: <87czgsqhfa.fsf_-_@gnus.org> References: <4E0D7000.7040802@swipnet.se> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 15775@debbugs.gnu.org, Jan =?UTF-8?Q?Dj=C3=A4rv?= , schwab@linux-m68k.org, Ulrich Neumerkel , 4359@debbugs.gnu.org To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 05 14:44:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmaq7-0004QD-KI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 14:44:15 +0200 Original-Received: from localhost ([::1]:42144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmaq6-0001cD-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 08:44:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmapv-0001Yb-9I for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 08:44:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmapu-0007Qc-27 for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 08:44:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmapu-0000vc-03 for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2022 12:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4359 X-GNU-PR-Package: emacs Original-Received: via spool by 4359-submit@debbugs.gnu.org id=B4359.16517545903417 (code B ref 4359); Thu, 05 May 2022 12:44:01 +0000 Original-Received: (at 4359) by debbugs.gnu.org; 5 May 2022 12:43:10 +0000 Original-Received: from localhost ([127.0.0.1]:44676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmaoy-0000sq-IW for submit@debbugs.gnu.org; Thu, 05 May 2022 08:43:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmaow-0000sI-Th; Thu, 05 May 2022 08:43:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v1OKFyVADpDvM3xlAUPN8bwtiVf2BMe0NlPGscHSaAQ=; b=l83io5/x4xzoBIMR5O+5JT/E+f TFQQDrP3NLhMRk3tXEBkoRtE+fSBJ7QHUMEmoRjK4F8xQJQJZNsvCknsJ+he1eMQKxUTrDO+U+c9s zAX+VhFbHnOe0De4tvoKL8ex0u5xplj5K8MmkneyO1yQ7nco9eb5N2W6X9nfum67RH4s=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmaoj-0001qs-Kj; Thu, 05 May 2022 14:42:51 +0200 X-Now-Playing: Kiko Dinucci's _Rastilho_: "=?UTF-8?Q?Olod=C3=A9?=" In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sat, 02 Jul 2011 14:35:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231428 Archived-At: This change makes "git grep" work as a grep command with `M-x grep' (if you remove --null). It's shouldn't have a negative impact on much anything else (because no pagers should be used anywhere here), but perhaps it should be done in grep.el instead of compile.el... Anybody got any comments? diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 6753cf0b02..c88eb10693 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1895,6 +1895,9 @@ compilation-start (and (derived-mode-p 'comint-mode) (comint-term-environment)) (list (format "INSIDE_EMACS=%s,compile" emacs-version)) + ;; Some external programs (like "git grep") use a pager; + ;; defeat that. + (list "PAGER=") (copy-sequence process-environment)))) (setq-local compilation-arguments (list command mode name-function highlight-regexp)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no