bug#4359: 23.1.50; ^G in M-x grep mode with git grep

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Ulrich Neumerkel]

--text follows this line--

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I am in the source directory of emacs, according to git describe
merge-multi-tty-to-trunk-16449-gd32e271

I want to git grep for something.   I do M-x grep
and add git in front of the grep command:

---------- Buffer: *grep* ----------
-*- mode: grep; default-directory: "/opt/gupu/src/emacs/" -*-
Grep started at Sun Sep  6 17:58:37

git grep -n -e git.describe
WARNING: terminal is not fully functional
^Glisp/org/org.el:112:      (if (eql 0 (shell-command "git describe --abbrev=4 HEAD"))

Grep finished (matches found) at Sun Sep  6 17:58:38
This is the -!-contents of foo.
---------- Buffer: *grep* ----------

Now, I cannot do C-c C-c on the line above.

(I changed the actual ^G to ^ G)


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/opt/gupu/emacs-git/share/emacs/23.1.50/etc/DEBUG for instructions.


In GNU Emacs 23.1.50.1 (i686-pc-linux-gnu, X toolkit)
 of 2009-09-06 on gupu2
Windowing system distributor `The X.Org Foundation', version 11.0.10603000
configured using `configure  '--without-toolkit-scroll-bars' '--prefix' '/opt/gupu/emacs-git''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Grep

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> C-x 
b C-g C-h i M-x e m a <tab> v e r <tab> <return> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> M-x m e n u <tab> b <tab> m 
<tab> <return> M-x t o o <tab> - <tab> <return> C-h 
n C-s f u l l s c r e e n C-s C-s C-a C-s C-s C-s C-a 
C-s C-s C-a <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <escape> <escape> < <escape> > C-s <escape> 
< C-x C-f C-g C-x C-f C-g C-x C-f / o p t / g u <tab> 
s r c / g i t - <backspace> <backspace> <backspace> 
<backspace> e m a c s <tab> - <tab> <backspace> <backspace> 
<backspace> <backspace> <backspace> <return> M-! g 
i t - g r e p SPC <return> M-! <up> <M-right> <right> 
<backspace> SPC C-e g i t SPC d <backspace> <backspace> 
. d e s c r i b e <return> M-x g r e p <return> C-a 
g o t <backspace> <backspace> i t SPC <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <left> <left> <backspace> C-e g i t . d e s 
c r o b <backspace> <backspace> i b e <return> C-x 
p C-x o <down> <down> <down> <down> <down> M-x s e 
n d <tab> C-g M-x m e n <tab> b <tab> m <tab> <return> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:
Tool-Bar mode disabled
View mode: type C-h for help, h for commands, q to quit.
Mark saved where search started [3 times]
Mark set [2 times]
Quit [2 times]
/bin/bash: git-grep: command not found
lisp/org/org.el:	  (if (eql 0 (shell-command "git describe --abbrev=4 HEAD"))
Grep finished (matches found)
Quit
Menu-Bar mode enabled

Load-path shadows:
None found.

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Andreas Schwab]

Ulrich Neumerkel <ulrich@complang.tuwien.ac.at> writes:

> ---------- Buffer: *grep* ----------
> -*- mode: grep; default-directory: "/opt/gupu/src/emacs/" -*-
> Grep started at Sun Sep  6 17:58:37
>
> git grep -n -e git.describe
> WARNING: terminal is not fully functional
> ^Glisp/org/org.el:112:      (if (eql 0 (shell-command "git describe --abbrev=4 HEAD"))

The WARNING line and the ^G is written by less.  You can work around
that by disabling the pager or setting it to cat.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Ulrich Neumerkel]

Andreas Schwab <schwab@linux-m68k.org>
>> git grep -n -e git.describe
>> WARNING: terminal is not fully functional
>> ^Glisp/org/org.el:112:      (if (eql 0 (shell-command "git describe --abbrev=4 HEAD"))
>
>The WARNING line and the ^G is written by less.  You can work around
>that by disabling the pager or setting it to cat.

This would be an ad-hoc workaround that does not work for the next
tool.  What is needed is that the command is called such that git or
the pager doesn't think they are in an interactive environment.

I.e.,

git grep -n -e git.describe | cat

does work correctly.  Not sure how to do this in a clean manner.

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Andreas Schwab]

Ulrich Neumerkel <ulrich@complang.tuwien.ac.at> writes:

> This would be an ad-hoc workaround that does not work for the next
> tool.  What is needed is that the command is called such that git or
> the pager doesn't think they are in an interactive environment.

That is easy, use a pipe instead of a pty (see process-connection-type).

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Sven Joachim]

On 2009-09-06 19:05 +0200, Ulrich Neumerkel wrote:

> Andreas Schwab <schwab@linux-m68k.org>
>>> git grep -n -e git.describe
>>> WARNING: terminal is not fully functional
>>> ^Glisp/org/org.el:112:      (if (eql 0 (shell-command "git describe --abbrev=4 HEAD"))
>>
>>The WARNING line and the ^G is written by less.  You can work around
>>that by disabling the pager or setting it to cat.
>
> This would be an ad-hoc workaround that does not work for the next
> tool.  What is needed is that the command is called such that git or
> the pager doesn't think they are in an interactive environment.

I set the pager in my .emacs:

(setenv "PAGER" "/bin/cat")

Works fine in all programs.

Sven

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Lars Magne Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

>> This would be an ad-hoc workaround that does not work for the next
>> tool.  What is needed is that the command is called such that git or
>> the pager doesn't think they are in an interactive environment.
>
> That is easy, use a pipe instead of a pty (see process-connection-type).

Are there any reasons why `M-x grep' and friends
(i.e. `compilation-start', really) shouldn't bind
`process-connection-type' to nil?

That is, do any of the `compile'-derived functions need a pty?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Ulrich Neumerkel]

Lars Magne Ingebrigtsen:
>Are there any reasons why `M-x grep' and friends
>(i.e. `compilation-start', really) shouldn't bind
>`process-connection-type' to nil?

M-x grep highlights the actual matches.  So this is not a simple pipe.

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Lars Magne Ingebrigtsen]

Ulrich Neumerkel <ulrich@complang.tuwien.ac.at> writes:

> Lars Magne Ingebrigtsen:
>>Are there any reasons why `M-x grep' and friends
>>(i.e. `compilation-start', really) shouldn't bind
>>`process-connection-type' to nil?
>
> M-x grep highlights the actual matches.  So this is not a simple pipe.

Right, so when grep detects that it's not a PTY, it switches the
GREP_COLOR(S) stuff off?  And there's no way to force that to be on?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Juri Linkov]

>>>Are there any reasons why `M-x grep' and friends
>>>(i.e. `compilation-start', really) shouldn't bind
>>>`process-connection-type' to nil?
>>
>> M-x grep highlights the actual matches.  So this is not a simple pipe.
>
> Right, so when grep detects that it's not a PTY, it switches the
> GREP_COLOR(S) stuff off?  And there's no way to force that to be on?

Yes, grep switches colors off if it's not a PTY:

http://thread.gmane.org/gmane.emacs.devel/83316/focus=83449

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Jan Djärv]

2011-07-01 02:01, Lars Magne Ingebrigtsen skrev:
> Ulrich Neumerkel<ulrich@complang.tuwien.ac.at>  writes:
>
>> Lars Magne Ingebrigtsen:
>>> Are there any reasons why `M-x grep' and friends
>>> (i.e. `compilation-start', really) shouldn't bind
>>> `process-connection-type' to nil?
>>
>> M-x grep highlights the actual matches.  So this is not a simple pipe.
>
> Right, so when grep detects that it's not a PTY, it switches the
> GREP_COLOR(S) stuff off?  And there's no way to force that to be on?
>

grep --color=always

	Jan D.

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Lars Magne Ingebrigtsen]

Jan Djärv <jan.h.d@swipnet.se> writes:

> grep --color=always

Hm.  But I guess people don't want to have that explicitly on the
command line they're editing when doing `M-x grep'?

The original problem was that the user had used a command that has
"less" as part of its pipeline, if running under a PTY.  Many other
commands react to the PTY in different ways (some that we want, like the
GREP_COLOR thing), and some that we don't want (like running less).

I'm not sure there's a fix here that will satisfy all use cases.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Dan Nicolaescu]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Jan Djärv <jan.h.d@swipnet.se> writes:
>
>> grep --color=always
>
> Hm.  But I guess people don't want to have that explicitly on the
> command line they're editing when doing `M-x grep'?
>
> The original problem was that the user had used a command that has
> "less" as part of its pipeline, if running under a PTY.  Many other
> commands react to the PTY in different ways (some that we want, like the
> GREP_COLOR thing), and some that we don't want (like running less).
>
> I'm not sure there's a fix here that will satisfy all use cases.

Does setting
GREP_OPTIONS to --color=always
work?

bug#4359: 23.1.50; ^G in M-x grep mode with git grep

[Lars Magne Ingebrigtsen]

Dan Nicolaescu <dann@gnu.org> writes:

> Does setting
> GREP_OPTIONS to --color=always
> work?

Yes.  But if the user then types "grep foo *.el | bar", the bar command
will then be getting the escape sequences, which probably isn't what we
want.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4359: bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell

[Lars Ingebrigtsen]

This change makes "git grep" work as a grep command with `M-x grep' (if
you remove --null).  It's shouldn't have a negative impact on much
anything else (because no pagers should be used anywhere here), but
perhaps it should be done in grep.el instead of compile.el...

Anybody got any comments?

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 6753cf0b02..c88eb10693 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1895,6 +1895,9 @@ compilation-start
               (and (derived-mode-p 'comint-mode)
                    (comint-term-environment))
 	      (list (format "INSIDE_EMACS=%s,compile" emacs-version))
+              ;; Some external programs (like "git grep") use a pager;
+              ;; defeat that.
+              (list "PAGER=")
 	      (copy-sequence process-environment))))
         (setq-local compilation-arguments
                     (list command mode name-function highlight-regexp))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#4359: bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> This change makes "git grep" work as a grep command with `M-x grep' (if
> you remove --null).  It's shouldn't have a negative impact on much
> anything else (because no pagers should be used anywhere here), but
> perhaps it should be done in grep.el instead of compile.el...
>
> Anybody got any comments?

[...]

> +              ;; Some external programs (like "git grep") use a pager;
> +              ;; defeat that.
> +              (list "PAGER=")

Nobody had any comments, and it doesn't seem likely that this will
regress anything, so I've now pushed this to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell

[Dmitry Gutov]

On 02.06.2022 16:07, Lars Ingebrigtsen wrote:
> Lars Ingebrigtsen<larsi@gnus.org>  writes:
> 
>> This change makes "git grep" work as a grep command with `M-x grep' (if
>> you remove --null).  It's shouldn't have a negative impact on much
>> anything else (because no pagers should be used anywhere here), but
>> perhaps it should be done in grep.el instead of compile.el...
>>
>> Anybody got any comments?
> [...]
> 
>> +              ;; Some external programs (like "git grep") use a pager;
>> +              ;; defeat that.
>> +              (list "PAGER=")
> Nobody had any comments, and it doesn't seem likely that this will
> regress anything, so I've now pushed this to Emacs 29.

Hi Lars,

Back when I filed bug#15775, Glenn merged it with bug#4359.

Looks like you are fixing only the latter bug here.

The package I mentioned in the original report, inf-ruby, derives from 
comint-mode.

It doesn't derive from compilation-mode, so the pushed change can't 
affect it or fix the problem there.

N.B.: Even a decade later, I still have

   (setenv "PAGER" (executable-find "cat"))

in my init script.

bug#4359: bug#15775: 24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell

[Lars Ingebrigtsen]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Back when I filed bug#15775, Glenn merged it with bug#4359.
>
> Looks like you are fixing only the latter bug here.

Sorry; didn't catch that.  I've now unmerged the bug reports, and
reopened bug#15775.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no