unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Pieter van Prooijen <pieter.van.prooijen@teloden.nl>
Cc: wilde@sha-bang.de, 55463@debbugs.gnu.org
Subject: bug#55463: [PATCH] Fix font options compilation with gsettings disabled
Date: Tue, 17 May 2022 09:05:10 +0800	[thread overview]
Message-ID: <87czgdnf3t.fsf@yahoo.com> (raw)
In-Reply-To: <6f99df01f4a1e7a3ddec018dc2e00b4977208055.camel@teloden.nl> (Pieter van Prooijen's message of "Mon, 16 May 2022 22:22:23 +0200")

Pieter van Prooijen <pieter.van.prooijen@teloden.nl> writes:

> Hello All,
>
> This is a small patch to make the recent gsettings font rendering
> changes compile when pgtk is configured but gsettings is not.

Thanks.

> -/* Return the cairo font options, updated from the gsettings font
> -   config entries.  The caller should call cairo_font_options_destroy
> -   on the result.  */
> +/* Return the cairo font options, optionally updated from the gsettings
> +   font config entries.  The caller should call
> +   cairo_font_options_destroy on the result.  */

I think this change is extraneous.  That comment doesn't have to be so
detailed, since building Emacs without GSettings support is a rather
oddball configuration, and it obviously cannot be used without support
being built-in.

Otherwise, LGTM.





  reply	other threads:[~2022-05-17  1:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 20:22 bug#55463: [PATCH] Fix font options compilation with gsettings disabled Pieter van Prooijen
2022-05-17  1:05 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-17  8:28   ` Pieter van Prooijen
2022-05-17 10:15     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czgdnf3t.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=55463@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=pieter.van.prooijen@teloden.nl \
    --cc=wilde@sha-bang.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).