From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Date: Sun, 19 Jun 2022 15:26:20 -0700 Message-ID: <87czf4l27n.fsf@athena.silentflame.com> References: <87czhgkb1c.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 54976@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 20 00:27:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o33Nx-000620-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 00:27:13 +0200 Original-Received: from localhost ([::1]:46310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o33Nw-0004kH-2K for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jun 2022 18:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o33Nm-0004j6-NS for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 18:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o33Nm-0002bW-Ey for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 18:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o33Nm-0003dk-Bu for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2022 18:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jun 2022 22:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54976 X-GNU-PR-Package: emacs Original-Received: via spool by 54976-submit@debbugs.gnu.org id=B54976.165567759113955 (code B ref 54976); Sun, 19 Jun 2022 22:27:02 +0000 Original-Received: (at 54976) by debbugs.gnu.org; 19 Jun 2022 22:26:31 +0000 Original-Received: from localhost ([127.0.0.1]:53382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o33NH-0003d1-LN for submit@debbugs.gnu.org; Sun, 19 Jun 2022 18:26:31 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:47319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o33NE-0003cm-Rp for 54976@debbugs.gnu.org; Sun, 19 Jun 2022 18:26:30 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id C4CC632007CF; Sun, 19 Jun 2022 18:26:22 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 19 Jun 2022 18:26:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1655677582; x=1655763982; bh=Fk wjBd+gZ/lR7wXOyyZxLaTQw6+euhyZG848GSOo6rI=; b=RNHeAvidIO3m/4Ccel ZLFugyEnvq0MFUKAUp2gAWFPTJP2HO+CBCuFMts8boR5M+ECe0EeWjgO3eg6PYsA x3jkap1yNdzAwYdONOzr3ThmDfPwxKijemiJzSA9BApd0KrsrrlJx27KnfEwZI6V KMn3SKJq2rm0ui0lpyMdYmFFqLVqUeRsbZCvyOaYJfFcHYg/OJpv4RguhOC1hVHo DwHMie6Q/nJK58mv+sHdjweJmYdco3dDoa1CNt+7vDZo4HQ+/0t85o208Ggr47dW wIEf+tMUab/Y0auZzuM4QbHaInf1URUbVP1tDLA1UoDfZB4SeQMMVvBAM56y6VFo /rKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655677582; x=1655763982; bh=FkwjBd+gZ/lR7wXOyyZxLaTQw6+e uhyZG848GSOo6rI=; b=BwLZzOPVPrn0QwGsVqbXke+12V7yukHTRIiRdwczWBLp GltFWUi9ws1H23cXKGZJinMGZgNfBegD+jzP9xnTP2yecW5nLoa/t1ld1e5OiaJq pgZN1OAyjJg7X/BKh6lDGIvvKSA71dKyfTyGw5iutJQ6egPEpNoRfrDvEjAlrX/j dA0P4PabT5JA/n7uUpCbXMB04MliNiTqvkiiDRyMHGSm86lLTkmRv8UDZ9u7f8b9 c82lhDy3xLlS4Vh9A2w/q18HLmo0cU5KxM7XIqBdw1bSmuPtNQbtpB+NeH07er4D D84vF5BuEi7BKl9g/QwX36xO+nHo+M5yLONZEuU1TA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeftddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedvjeettdeiteejgeejkefggfehtdekledtfedtteekgfeu keeftdduhfetleejkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Jun 2022 18:26:21 -0400 (EDT) Original-Received: by athena.silentflame.com (Postfix, from userid 1000) id C43EE1B630C; Sun, 19 Jun 2022 22:26:20 +0000 (UTC) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234817 Archived-At: Hello, On Sun 19 Jun 2022 at 07:57am -07, Stefan Kangas wrote: > close 54976 29.1 > thanks > > Sean Whitton writes: > >> Suppose you put this in your init.el: >> >> (add-to-list 'eshell-modules-list 'eshell-elecslash) >> >> because you want to use the new em-elecslash.el module I'm working on. >> >> Then if you try to M-x eshell on an older version of Emacs which lacks >> em-elecslash, Eshell will fail to initialise at all. >> >> It is easy add a guard (when (locate-library ...)) or similar, but this >> is not possible if you have added eshell-elecslash using the customise >> interface. In that case, by enabling the module, youq just make your >> init unusable with older Emacs. >> >> It would be better to print a warning, say, rather than error. > > I agree that it makes more sense to warn here instead of refusing to > start. So I have now done that in Emacs 29 (commit d6b4803850). Many thanks for this! -- Sean Whitton