* bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list
@ 2022-04-16 20:50 Sean Whitton
2022-06-19 14:57 ` Stefan Kangas
0 siblings, 1 reply; 3+ messages in thread
From: Sean Whitton @ 2022-04-16 20:50 UTC (permalink / raw)
To: 54976
Hello,
Suppose you put this in your init.el:
(add-to-list 'eshell-modules-list 'eshell-elecslash)
because you want to use the new em-elecslash.el module I'm working on.
Then if you try to M-x eshell on an older version of Emacs which lacks
em-elecslash, Eshell will fail to initialise at all.
It is easy add a guard (when (locate-library ...)) or similar, but this
is not possible if you have added eshell-elecslash using the customise
interface. In that case, by enabling the module, youq just make your
init unusable with older Emacs.
It would be better to print a warning, say, rather than error.
--
Sean Whitton
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list
2022-04-16 20:50 bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Sean Whitton
@ 2022-06-19 14:57 ` Stefan Kangas
2022-06-19 22:26 ` Sean Whitton
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Kangas @ 2022-06-19 14:57 UTC (permalink / raw)
To: Sean Whitton; +Cc: 54976
close 54976 29.1
thanks
Sean Whitton <spwhitton@spwhitton.name> writes:
> Suppose you put this in your init.el:
>
> (add-to-list 'eshell-modules-list 'eshell-elecslash)
>
> because you want to use the new em-elecslash.el module I'm working on.
>
> Then if you try to M-x eshell on an older version of Emacs which lacks
> em-elecslash, Eshell will fail to initialise at all.
>
> It is easy add a guard (when (locate-library ...)) or similar, but this
> is not possible if you have added eshell-elecslash using the customise
> interface. In that case, by enabling the module, youq just make your
> init unusable with older Emacs.
>
> It would be better to print a warning, say, rather than error.
I agree that it makes more sense to warn here instead of refusing to
start. So I have now done that in Emacs 29 (commit d6b4803850).
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list
2022-06-19 14:57 ` Stefan Kangas
@ 2022-06-19 22:26 ` Sean Whitton
0 siblings, 0 replies; 3+ messages in thread
From: Sean Whitton @ 2022-06-19 22:26 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 54976
Hello,
On Sun 19 Jun 2022 at 07:57am -07, Stefan Kangas wrote:
> close 54976 29.1
> thanks
>
> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> Suppose you put this in your init.el:
>>
>> (add-to-list 'eshell-modules-list 'eshell-elecslash)
>>
>> because you want to use the new em-elecslash.el module I'm working on.
>>
>> Then if you try to M-x eshell on an older version of Emacs which lacks
>> em-elecslash, Eshell will fail to initialise at all.
>>
>> It is easy add a guard (when (locate-library ...)) or similar, but this
>> is not possible if you have added eshell-elecslash using the customise
>> interface. In that case, by enabling the module, youq just make your
>> init unusable with older Emacs.
>>
>> It would be better to print a warning, say, rather than error.
>
> I agree that it makes more sense to warn here instead of refusing to
> start. So I have now done that in Emacs 29 (commit d6b4803850).
Many thanks for this!
--
Sean Whitton
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-19 22:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-16 20:50 bug#54976: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list Sean Whitton
2022-06-19 14:57 ` Stefan Kangas
2022-06-19 22:26 ` Sean Whitton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).