From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeronimo Pellegrini via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56723: CHECK_INTEGER reports the wrong predicate -- see for example (ash 1.0 1) Date: Sat, 23 Jul 2022 08:47:56 -0300 Message-ID: <87czdwhwyb.fsf@socrates.mail-host-address-is-not-set> Reply-To: Jeronimo Pellegrini Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2894"; mail-complaints-to="usenet@ciao.gmane.io" To: 56723@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 23 13:49:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFDdB-0000X9-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jul 2022 13:49:16 +0200 Original-Received: from localhost ([::1]:43324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFDd9-0006Om-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jul 2022 07:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFDd1-0006NA-HV for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 07:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFDd0-0002oA-95 for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 07:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFDd0-0006CI-5L for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 07:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jeronimo Pellegrini Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2022 11:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56723 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165857689123717 (code B ref -1); Sat, 23 Jul 2022 11:49:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Jul 2022 11:48:11 +0000 Original-Received: from localhost ([127.0.0.1]:43690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFDcA-0006AS-KA for submit@debbugs.gnu.org; Sat, 23 Jul 2022 07:48:10 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFDc8-0006AE-N4 for submit@debbugs.gnu.org; Sat, 23 Jul 2022 07:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFDc8-0005li-FG for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 07:48:08 -0400 Original-Received: from mail.aleph0.info ([66.228.54.186]:53680 helo=aleph0.info) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFDc6-0002im-2N for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 07:48:08 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by aleph0.info (Postfix) with ESMTP id 8CBA942395; Sat, 23 Jul 2022 08:47:59 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aleph0.info; s=mail; t=1658576879; bh=BYHeaB8HBcYGJ/DHI+pycRBHujxV/3QsWxjE/NbQ6MI=; h=From:To:Subject:Date:From; b=VydT4lwmTrsZjDoAmW0rBFTuIO0qWcLpRzNw/nwX3mJzOQrPT75pomHzuQtNrsyCB 6k4qT7Eu8MHRBikwtYOg3gvOucSmmdBPpy0+PTt2C6aNDSerCTs9/dOctM/wDUufLv wOzpstRQ3dqoG3Iv/4L9O9zYfLt0C9i4cJI4pJ0D6tnq14+3lt/QkPH11jQTt2OCjd URMXo1ZfCP+RRWvgqkXm2V3nosfGyQmp2oiw3SNPAgN4Tvy01AJAr4csGlBm0+Xivj IOzyroMAryHHUXSNXc4hdiHbl0t6it3czPR1I59IyPBQzo27E3ST8zO/UNIcoihjEC DAEIjD5iube8w== Original-Received: from aleph0.info ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id f7xjVPzAUZOS; Sat, 23 Jul 2022 08:47:59 -0300 (-03) Original-Received: from socrates.aleph0.info (unknown [177.141.17.65]) (Authenticated sender: je) by aleph0.info (Postfix) with ESMTPSA id 4048742393; Sat, 23 Jul 2022 08:47:59 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aleph0.info; s=mail; t=1658576879; bh=BYHeaB8HBcYGJ/DHI+pycRBHujxV/3QsWxjE/NbQ6MI=; h=From:To:Subject:Date:From; b=VydT4lwmTrsZjDoAmW0rBFTuIO0qWcLpRzNw/nwX3mJzOQrPT75pomHzuQtNrsyCB 6k4qT7Eu8MHRBikwtYOg3gvOucSmmdBPpy0+PTt2C6aNDSerCTs9/dOctM/wDUufLv wOzpstRQ3dqoG3Iv/4L9O9zYfLt0C9i4cJI4pJ0D6tnq14+3lt/QkPH11jQTt2OCjd URMXo1ZfCP+RRWvgqkXm2V3nosfGyQmp2oiw3SNPAgN4Tvy01AJAr4csGlBm0+Xivj IOzyroMAryHHUXSNXc4hdiHbl0t6it3czPR1I59IyPBQzo27E3ST8zO/UNIcoihjEC DAEIjD5iube8w== Original-Received: from socrates (localhost [127.0.0.1]) by socrates.aleph0.info (Postfix) with ESMTP id 1BC2180249B; Sat, 23 Jul 2022 08:47:57 -0300 (-03) Received-SPF: pass client-ip=66.228.54.186; envelope-from=j_p@aleph0.info; helo=aleph0.info X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237737 Archived-At: Package: emacs Version: 29.0.50 -- 9171fa09332df615832240e98c247638019c0211 Severity: minor Hello! CHECK_INTEGER, defined in lisp.h, seems to report the wrong predicate, although it does check the argument correctly: INLINE void CHECK_INTEGER (Lisp_Object x) { CHECK_TYPE (INTEGERP (x), Qnumberp, x); ^^^^^^^^ That makes, for example (ash 1.1 1) signal an error with the message "Wrong type argument: numberp, 1.1" (it should be integerp, not numberp). The same for logcount, and other functions that require integers -- they will all complain that "1.1" is not a number. Perhaps Qnumberp should be changed to Qintegerp in line 3149 of lisp.h? That seems to fix it for me. (I don't include a patch because there were issues in the past with me trying to contribute to tramp. Nothing serious: my employer, a public University, is happy to release the code under the GNU GPL, but won't transfer copyright) J.