bug#56714: 28.1.90; html-mode-map binds M-o

bug#56714: 28.1.90; html-mode-map binds M-o

[Daniel Mendler]

In Emacs 28 the global M-o binding for the face menu was removed. The
html-mode-map still binds the key, such that it is not free to use by
the user. Is it possible to (re)move this binding? html-mode uses the
face menu functionality. If a full removal is not possible, the face
menu could be moved to another key.

In GNU Emacs 28.1.90 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw scroll bars)
 of 2022-06-30 built on projects
Repository revision: f5421104e9753a2d3ead19ba31ac5ed1f3a5c03a
Repository branch: emacs-28
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

bug#56714: 28.1.90; html-mode-map binds M-o

[Lars Ingebrigtsen]

Daniel Mendler <mail@daniel-mendler.de> writes:

> In Emacs 28 the global M-o binding for the face menu was removed. The
> html-mode-map still binds the key, such that it is not free to use by
> the user. Is it possible to (re)move this binding? html-mode uses the
> face menu functionality. If a full removal is not possible, the face
> menu could be moved to another key.

facemenu-keymap is useful in html-mode, so it was kept.  Removing it
there, too, would be too annoying, so we decided not to do that.

So this is working as designed, and I'm therefore closing this bug
report.

bug#56714: 28.1.90; html-mode-map binds M-o

[Daniel Mendler]

On 7/23/22 07:52, Lars Ingebrigtsen wrote:
> Daniel Mendler <mail@daniel-mendler.de> writes:
> 
>> In Emacs 28 the global M-o binding for the face menu was removed. The
>> html-mode-map still binds the key, such that it is not free to use by
>> the user. Is it possible to (re)move this binding? html-mode uses the
>> face menu functionality. If a full removal is not possible, the face
>> menu could be moved to another key.
> 
> facemenu-keymap is useful in html-mode, so it was kept.  Removing it
> there, too, would be too annoying, so we decided not to do that.
> 
> So this is working as designed, and I'm therefore closing this bug
> report.

Why not use another key binding instead, such that M-o is truly free to
use by the user? In Emacs 28 the global binding was freed for that
reason. I think it would be better to free that binding consistently
across all modes.

bug#56714: 28.1.90; html-mode-map binds M-o

[Lars Ingebrigtsen]

Daniel Mendler <mail@daniel-mendler.de> writes:

> Why not use another key binding instead, such that M-o is truly free to
> use by the user? In Emacs 28 the global binding was freed for that
> reason. I think it would be better to free that binding consistently
> across all modes.

We have to weigh annoying people with changes versus consistency.

bug#56714: 28.1.90; html-mode-map binds M-o

[Daniel Mendler]

On 7/23/22 09:34, Lars Ingebrigtsen wrote:
> Daniel Mendler <mail@daniel-mendler.de> writes:
> 
>> Why not use another key binding instead, such that M-o is truly free to
>> use by the user? In Emacs 28 the global binding was freed for that
>> reason. I think it would be better to free that binding consistently
>> across all modes.
> 
> We have to weigh annoying people with changes versus consistency.

Of course. But given that you removed the much more intrusive global
binding it looks like an oversight that html-mode still occupies the
binding. I argue that the small added annoyance due to the change of
html-mode-map would get lost in the noise of the big annoyance that is
the removal of the global face-menu. But actually the big annoyance was
a big relief and now we are left with the stumbling block that is M-o in
html-mode.

Iirc you removed M-o experimentally and waited for user feedback? Why
not do the same for html-mode? Move the keybinding and wait for feedback?

bug#56714: 28.1.90; html-mode-map binds M-o

[Daniel Mendler]

I took another look at the Emacs 28 news entry. As I understood it, the
M-o binding was removed everywhere. But it seemed that at the same time
you introduced M-o as local binding in the html-mode-map and the
enriched-mode-map. This is not obvious from the news entry.

At least this explains your reaction that the feature is working as
intended. However this looks like a bad compromise given that the
situation is now even worse than before, since the users have to move
two keybindings now instead of a single one if they want to get rid of
M-o consistently.

Daniel

bug#56714: 28.1.90; html-mode-map binds M-o

[Augusto Stoffel]

On Sat, 23 Jul 2022 at 10:01, Daniel Mendler <mail@daniel-mendler.de> wrote:

> At least this explains your reaction that the feature is working as
> intended. However this looks like a bad compromise given that the
> situation is now even worse than before, since the users have to move
> two keybindings now instead of a single one if they want to get rid of
> M-o consistently.

I agree that not actually freeing M-o defeats the purpose of freeing it.

I would also like to add for the record that diff-mode suffers from the
same issue.  I believe the following diff would suffice to fix it.

modified   lisp/vc/diff-mode.el
@@ -196,7 +196,7 @@ diff-mode-map
           ;; We want to inherit most bindings from
           ;; `diff-mode-shared-map', but not all since they may hide
           ;; useful `M-<foo>' global bindings when editing.
-          (dolist (key '("A" "r" "R" "g" "q" "W" "z"))
+          (dolist (key '("A" "r" "R" "g" "q" "W" "z" "o"))
             (keymap-set map key nil))
           map)
   ;; From compilation-minor-mode.