From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#50849: 28.0.50; Proposal for Emacs daemon to signal when being busy Date: Fri, 09 Sep 2022 10:47:23 +0200 Message-ID: <87czc57x44.fsf@gmail.com> References: <86czouksh2.fsf@protected.rcdrun.com> <87a67d1vyg.fsf@gnus.org> <83ilm1jkss.fsf@gnu.org> <87v8q1b2ij.fsf@gmail.com> <83czc8k7zw.fsf@gnu.org> <83czc7j4bs.fsf@gnu.org> <87leqvbhhg.fsf@gmail.com> <838rmvig8f.fsf@gnu.org> <83wnaefltf.fsf@gnu.org> <87pmg63w8l.fsf@gnus.org> <83zgfadlt8.fsf@gnu.org> <87pmg6yo60.fsf@gnus.org> <83sfl2dkqv.fsf@gnu.org> <8735d2ymzv.fsf@gnus.org> <83pmg6dkb6.fsf@gnu.org> <87czc67xtv.fsf@gmail.com> <83mtb9etw5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10661"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50849@debbugs.gnu.org, stefankangas@gmail.com, bugs@gnu.support, visuweshm@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 09 10:49:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWZhg-0002cE-5L for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Sep 2022 10:49:36 +0200 Original-Received: from localhost ([::1]:60976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWZhe-0003l1-LQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Sep 2022 04:49:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWZgB-0003kp-3K for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 04:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWZgA-0000lR-Ng for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 04:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWZg9-0007SW-V8 for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 04:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Sep 2022 08:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50849 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50849-submit@debbugs.gnu.org id=B50849.166271325728543 (code B ref 50849); Fri, 09 Sep 2022 08:48:01 +0000 Original-Received: (at 50849) by debbugs.gnu.org; 9 Sep 2022 08:47:37 +0000 Original-Received: from localhost ([127.0.0.1]:60863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWZfl-0007QI-28 for submit@debbugs.gnu.org; Fri, 09 Sep 2022 04:47:37 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:42662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWZff-0007Q1-HP for 50849@debbugs.gnu.org; Fri, 09 Sep 2022 04:47:35 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id o25so1542736wrf.9 for <50849@debbugs.gnu.org>; Fri, 09 Sep 2022 01:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=qwtIHHHTB7qpZq79kuyCKUD+h/YqdgHDAr4KukfbW2c=; b=GqgG2XlwVEf6b/FYoXxIezbHMRyIFSoUgS5aSWTO2F+QZSG/9BMBYIj+CaE5mtYPw0 jPYajcXBbpXBDBzRogjAmuK/KL+AEzsDfAcQQay250a3H2lrxQQWi5BK0FF980j2Y6IA WUtmwRjp/clOst8N+nOZq9TZPCxO5VSXquDAqFO30UUpfwLHek1upBFEZxrkz6BS0dUX qEqw00Ppx0Au1Rm1sJFXY3I9huDHKPmaSVUUemYGuYN2qNsQMGO5FeUiKaoFYzt/8zrF c44Gh7o/P6/FSJ/1K/5lziEpGNiM5odlLhAkaDkSDU6VzgXddmYDW8vFKIvgYDoMGpwi fZNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=qwtIHHHTB7qpZq79kuyCKUD+h/YqdgHDAr4KukfbW2c=; b=e1goxRTcJ32zCZg3Lc/Hpbe8Kgs8cA8KC34vuU60EIgxddZypg1b0gJCkpLgeP7B6w Sl7SexbaAhDOx7H0l4mV9hWSqw2GQCPvYaDPX1CRRBmWCyiCqBT1LmMu4S32B9HTY9B9 vTmu4uxPLdTRix1JRkul6w4lXtwupD6EEy9U0NP8P5IHSmB82ZNOfN/zd/oxFoxvVshP +PG7WEvbDeeOZfwqMPJLJh5HddFJjNg2ttizLWsbnaunbPEpJDrz4X+zCDFwscOMoGFz NX3Ay4pgOBjBhkJQccB5jWF8fqDmIlSSYxVxKaZMUIc1lC4VLUNpticNq3h5tG9yTumN INTQ== X-Gm-Message-State: ACgBeo3Z5MCd37uunJGRURwxHbuKIkJQ+PEfX282oMjOKtFwePED+gKv lXUtgZf516TvxGS9bdMgZfJECvMpvHNWog== X-Google-Smtp-Source: AA6agR4GKEYlfVCssYewUVGCQjrEgs8amzPVStDXVV7kFtFgKE0ZGHx2OczpKFmTCrF3KNgH0qeKfg== X-Received: by 2002:adf:fbd1:0:b0:228:6406:23d8 with SMTP id d17-20020adffbd1000000b00228640623d8mr7358028wrs.45.1662713245008; Fri, 09 Sep 2022 01:47:25 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:a290:d8f3:806c:3938]) by smtp.gmail.com with ESMTPSA id h10-20020a1c210a000000b003b340cca018sm1398118wmh.16.2022.09.09.01.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Sep 2022 01:47:24 -0700 (PDT) In-Reply-To: <83mtb9etw5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2022 19:02:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241959 Archived-At: >>>>> On Thu, 08 Sep 2022 19:02:50 +0300, Eli Zaretskii said: >> So if we set DEFAULT_TIMEOUT to 0, people who do nothing get no >> messages, and people who do --timeout get messages. I think that >> satisfies Eli=CA=BCs concern about compatibility Eli> Yes, I think so. >> (I=CA=BCd even go so far as not setting the timeout at all if it=CA= =BCs not >> requested. Why yes, I am paranoid about changing old code). Eli> I agree. So this simplifies the code considerably, and in fact removes the whole retry thing completely. diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c index 49d90a989f..b9ade602e4 100644 --- a/lib-src/emacsclient.c +++ b/lib-src/emacsclient.c @@ -66,8 +66,6 @@ Copyright (C) 1986-2022 Free Software Foundation, Inc. =20 #endif /* !WINDOWSNT */ =20 -#define DEFAULT_TIMEOUT (30) - #include #include #include @@ -2137,35 +2135,24 @@ main (int argc, char **argv) } fflush (stdout); =20 - set_socket_timeout (emacs_socket, timeout > 0 ? timeout : DEFAULT_TIMEOU= T); + if (timeout > 0) + set_socket_timeout (emacs_socket, timeout); bool saw_response =3D false; + /* Now, wait for an answer and print any messages. */ while (exit_status =3D=3D EXIT_SUCCESS) { - bool retry =3D true; - bool msg_showed =3D quiet; do { act_on_signals (emacs_socket); rl =3D recv (emacs_socket, string, BUFSIZ, 0); - retry =3D check_socket_timeout (rl); - if (retry && !saw_response) - { - if (timeout > 0) - { - /* Don't retry if we were given a --timeout flag. */ - fprintf (stderr, "\nServer not responding; timed out after %lu seconds= ", - timeout); - retry =3D false; - } - else if (!msg_showed) - { - msg_showed =3D true; - fprintf (stderr, "\nServer not responding; use Ctrl+C to break"); - } - } + if (timeout > 0 + && check_socket_timeout (rl) + && !saw_response) + fprintf (stderr, "\nServer not responding; timed out after %lu second= s", + timeout); } - while ((rl < 0 && errno =3D=3D EINTR) || retry); + while (rl < 0 && errno =3D=3D EINTR); =20 if (rl <=3D 0) break; Robert --=20