From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Date: Wed, 14 Sep 2022 10:19:48 -0700 Message-ID: <87czbxub4b.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29453"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 57807@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 14 19:36:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYWJ3-0007P7-TF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 19:36:14 +0200 Original-Received: from localhost ([::1]:42906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYWJ2-0004gw-Vt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Sep 2022 13:36:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYW3P-0007Px-2h for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYW3O-0007DF-O0 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYW3O-0000Fe-IF for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57807 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1663176001958 (code B ref -1); Wed, 14 Sep 2022 17:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Sep 2022 17:20:01 +0000 Original-Received: from localhost ([127.0.0.1]:55972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYW3N-0000FG-84 for submit@debbugs.gnu.org; Wed, 14 Sep 2022 13:20:01 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:33242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYW3J-0000F5-Pn for submit@debbugs.gnu.org; Wed, 14 Sep 2022 13:19:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYW3F-0007CK-Tv for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:19:55 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYW3D-0007CD-E4 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:19:53 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B00E75C00F0 for ; Wed, 14 Sep 2022 13:19:49 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Sep 2022 13:19:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1663175989; x=1663262389; bh=UnqKUoO930WCqRlYsPk7Ql4dq7u+dWw5WMK T/ZTUrBY=; b=e4j9/qMDfF45Wt5dGUC74+Gv4ugZxvDfyqvAKz2a9cPMG9eBt6l CrTuQJ/enfIKoPT9TGyVPkkqfUkngtjRmu/6k0R3tkkFpIMO4xFFSaZt+uTOVsnx 9D0o+IRwXBC01OIqJ7x6kHqiBovTV+rYT0i2xMNS+CPm6b8umgROQyVIeeHKCvz+ NpsfwJf7WM0WT4RBOeuNi2REDuWXgUGdgAP/wLXHvCkuIAs1CVroiwm3bEbWIUBc peu+XTSTS2Z621ZVLsmzKO36VXA87zAwk/qpP0lRlzwAk2oFqTK7pEF27A0wY0Er Ekduq/+/P7urYhX7kTpjf94j6xZn7Q0pNhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663175989; x= 1663262389; bh=UnqKUoO930WCqRlYsPk7Ql4dq7u+dWw5WMKT/ZTUrBY=; b=b q/jHc9rlt4IDnmeiKLQZeuaxDjodl9xEcl9/S0qqlGwgKvf14repdmydXaBdN6qa tmYqF1p3D9IBBA+bL03kg+mu1wwEppDCE0977XS3uyXP5wkAqG0W3gWCoUTol9uF sZfB7Hnl3qn8ifKarr6tv93nHhwuOWxpV9c3BJhSIqKuLxsuaESJNPf8b3Y85Fk1 qAVHRgh99pLhPg3b6OWuDFeF4LhARjCrdX7LkZ5MgEHVWf1WXPTAdIOrAYXb5QVt oUD9eHwJgIbi0YSqMfvvJlnM7NgTGWFYMq13AItCBzbukZSu2fBUfyBuf5Bbuf+L mY3hnhQZDu7ZiOahD3/wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfffgheeggffgheeuvd ethfekuddtgffgtdeukeegkedttefftdeghfdvgfdtjeelnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 14 Sep 2022 13:19:49 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id BF8BF7F1678; Wed, 14 Sep 2022 10:19:48 -0700 (MST) Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242492 Archived-At: Hello, vc-git-log-edit-mode is already able to properly understand git-log(1) output which logs multiple branches. Here's a hack to demonstrate that: (let ((default-directory "~/src/emacs/") (vc-git-log-switches (cons "origin/scratch/posix-spawn" vc-git-log-switches))) (call-process-shell-command "git branch -f tmp 4b2ca6bfc0") (vc-print-branch-log "tmp")) (4b2ca6bfc0 is an old tip of master close to scratch/posix-spawn.) An example of a case in which it is useful to produce logs like this is when you're trying to figure out how several feature branches relate to each other and to the trunk. I don't think the idea of producing a log showing more than one branch at once is fundamentally git-specific. So I would like to extend vc-print-branch-log to allow logging more than one branch, or alternatively, add a vc-print-branch-logs command. I believe that there are two design issues, on which I'm requesting review/input: (1) Extending the VC history functions API to permit expressing a request for the backend to print a log of multiple branches. We could allow the START-REVISION argument to `print-log' to take a list of branches, or add an additional optional argument ADDITIONAL-START-REVISIONS. The latter seems more robust to me. (2) How could vc-print-branch-log prompt the user for multiple branch names? Magit has the user separate branch names with commas, offering completion for each branch name. But I suppose commas never appearing in branch names is git-specific. So the command could prompt the user repeatedly for branch names, until the user hits RET to input a zero-length branch name, indicating they've input them all. -- Sean Whitton