From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Thu, 10 Nov 2022 11:00:18 +0000 Message-ID: <87cz9v9irh.fsf@gmail.com> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6064"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58790@debbugs.gnu.org, felician.nemeth@gmail.com, stefankangas@gmail.com, Danny Freeman , dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 12:00:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot5IK-0001P6-LV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 12:00:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot5Hx-0005LC-KO; Thu, 10 Nov 2022 06:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot5Hv-0005GC-GR for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 06:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot5Hv-0005pJ-0I for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 06:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ot5Hu-0000IJ-Sc for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 06:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.16680779511041 (code B ref 58790); Thu, 10 Nov 2022 11:00:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 10 Nov 2022 10:59:11 +0000 Original-Received: from localhost ([127.0.0.1]:42105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot5H5-0000Gj-Fi for submit@debbugs.gnu.org; Thu, 10 Nov 2022 05:59:11 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:38562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot5H3-0000GW-Lp for 58790@debbugs.gnu.org; Thu, 10 Nov 2022 05:59:10 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id h133-20020a1c218b000000b003cf4d389c41so3118690wmh.3 for <58790@debbugs.gnu.org>; Thu, 10 Nov 2022 02:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TKoS1ZcD9QWQR/e7BvL2CFbPVbaf38Diyasum3oDqws=; b=HudLmpcMx//lJlrCZoYf3U/VJBzPbwkysfru4CKLBu7LgxHoimeO9K1kAMe2weGoTI U0Q8v5kEb0EXZbXKDT26cDXQXOGP8SIfuEvzDLydxNymZ5d7ZQnAyUT40j2mLAi4kS9M Vktc+JaJC4HSKevQ/RXTNtXbzkeBAMkecOSxFODwp7/IuMZ3bcYcyB2yBU9iFJJz6HFT HjBVsEqCrXFxvBmeNH6Dp3bsXL/dJAnvTkqbEyz1xm97mwRahE8S2fKB4YBB4PK2wQHM kLsWQQbWhjULyYwlGDcwLStfWfVi611vxgjluxMzc8J6qymw4GpGrgY2vGHdjX5Ue7+n QH8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TKoS1ZcD9QWQR/e7BvL2CFbPVbaf38Diyasum3oDqws=; b=dJ0SbXD5XEXcTy4p3arit6hXBcJfPI5/55QHJKSTdUrwv+juKQNPabR2K5QHpPKZuR Duc1caSY5BdJZKnCrTHJCXfHLLeio+3AwiustUw1DDXR5VbXUkLPDV0+R5AGGY1kR1KL qnec8Nt+EYT8SP/ttaCiQ43dLh2UQt9XJkG27GCCfjdBWkOPnirNWtx9gPD9ncb6OU1P Xrf8RDC6u776iFMuMSq+JHarhuRMr4A9a10+jc9HIVRh2JkjgaRYxl825fciq+q76ENj MShdP7aR2mQoVT7Houf+iyC8FiZ7lHhKhK2XezgxRBLX0cTpWGWxBRL3k2KYDUy4eGnW iGEw== X-Gm-Message-State: ACrzQf2w9BZCpkCSJszMFPnTR+RPiom0N+vw+Qca0MAO/m92Pjb27jnP 0IkENv6EURI6U04Cd+kde+Y= X-Google-Smtp-Source: AMsMyM5bs9ICyGzL6qVksCDusZFpjW4YIhKkt4f8CLvJkrK3eCWfKLrcQGwRcZSGohLbxMw1LFlZ/Q== X-Received: by 2002:a05:600c:35cb:b0:3c6:e382:62fb with SMTP id r11-20020a05600c35cb00b003c6e38262fbmr41903050wmq.22.1668077943501; Thu, 10 Nov 2022 02:59:03 -0800 (PST) Original-Received: from krug (87-196-81-1.net.novis.pt. [87.196.81.1]) by smtp.gmail.com with ESMTPSA id ay19-20020a05600c1e1300b003c6bbe910fdsm5729358wmb.9.2022.11.10.02.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 02:59:03 -0800 (PST) In-Reply-To: <83edubrvf0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Nov 2022 11:49:39 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247510 Archived-At: Eli Zaretskii writes: > Ping! Jo=C3=A3o, any comments on this patch? Hi Eli, thanks for pinging. Yes, had a look and _both_ patches look fine. The first patch touches a sensitive part. I hoped at this point to have Eglot's automated test running in Emacs's repo, but I don't. So I trust Danny has given some minimal testing to this, hopefully also with some other server, for good measure. The second patch is a little riskier because it has the potential to cause much warning noise, but I'd wait and see what it does in the wild. If it does happen I think we have some means of toning down warnings without making package's warning logic too complex. So again, both patches should be pushed. I'm in the middle of a bisection here, so if you can commit and push the patches, I'd be thankful. Else, I will attend to that later. Jo=C3=A3o