From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#60147: 30.0.50; vc-prepare-patch: Add numbered patch file names Date: Sun, 18 Dec 2022 10:45:17 +0000 Message-ID: <87cz8hyoqq.fsf@posteo.net> References: <87y1r64bof.fsf@posteo.net> <87r0wxv9d1.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12929"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60147@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 11:46:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6rBT-0003BE-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 11:46:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6rBH-0008OO-93; Sun, 18 Dec 2022 05:46:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6rBC-0008O2-Hz for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 05:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6rBC-0007fj-9F for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 05:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6rBC-0007AT-0S for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 05:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 10:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60147 X-GNU-PR-Package: emacs Original-Received: via spool by 60147-submit@debbugs.gnu.org id=B60147.167136032627538 (code B ref 60147); Sun, 18 Dec 2022 10:46:01 +0000 Original-Received: (at 60147) by debbugs.gnu.org; 18 Dec 2022 10:45:26 +0000 Original-Received: from localhost ([127.0.0.1]:33214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rAb-0007A6-QR for submit@debbugs.gnu.org; Sun, 18 Dec 2022 05:45:26 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:36747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6rAa-00079y-2R for 60147@debbugs.gnu.org; Sun, 18 Dec 2022 05:45:25 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 00712240027 for <60147@debbugs.gnu.org>; Sun, 18 Dec 2022 11:45:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671360318; bh=tqtrVvB/avY7doY3PmfHipoqDOKy/RDU5EUrb6fSIm4=; h=From:To:Cc:Subject:Date:From; b=V/5dCRhE2LZGTfxr4+Moq8MciMme22goyKy9iCsSie+NNCbYLoK5hXU5gf7N0wz+q 60e1vLUtRdWILovWFTNFs/bK78NfsFZJHx+BfZkJ9z7TG7zkWnaQjg0oOIBZOCerf2 XOrQUyExSvWH/zvwjh2Q/OyvIhbKg88kaBjycQnQ9TDWMI3jOd3lWLm/L0M/Xfa67m Gz5OOmEOzSGv9DLTc1o2zdOx90KvgNUokUIozPmtO3iYimSrQZA/Mj7tA0uguT/T0w u1S/T73urd+rVp5gbQSra2Ao9N00SpVSVNer9bL7RjOz+bFMkeIaeD0i47XNygA4m6 579k9khITKhmw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NZfcX29psz9rxD; Sun, 18 Dec 2022 11:45:13 +0100 (CET) In-Reply-To: <87r0wxv9d1.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 17 Dec 2022 17:33:30 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251351 Archived-At: Sean Whitton writes: > Hello, > > On Sat 17 Dec 2022 at 09:33AM GMT, Philip Kaludercic wrote: > >>> + (filename >>> + (concat >>> + (string-trim >>> + (replace-regexp-in-string >>> + "\\W" "-" (if (length> stripped-subject 50) >>> + (substring stripped-subject 0 50) >>> + stripped-subject)) >> >> Is limiting the file names to ~50 characters a Git thing? > > Git does it, yes, and I thought it seemed like a good idea in general. OK, then it should be a good convention. And if the file names are numbered, then there shouldn't be any conflicts when downloading patches. >>> + (mml-attach-buffer >>> + (buffer-name (plist-get patch :buffer)) >>> + "text/x-patch" >>> + patch-subject >>> + "attachment" >>> + (format "%04d-%s" (cl-incf i) filename)))))) >> >> Is the new additional argument really necessary, or couldn't we just >> rename the generated buffer? We could specify that the buffer must be >> fresh/renameable. > > The description and the filename for an attachment are not the same > thing -- I don't believe MUAs will save the files with the correct name > unless there is the filename= field. And I think it's a useful general > addition to mml-attach-buffer. I see, in that case this should be fine. Can you apply the patch?