From: Robert Pluim <rpluim@gmail.com>
To: 63236@debbugs.gnu.org
Subject: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible
Date: Tue, 02 May 2023 19:06:14 +0200 [thread overview]
Message-ID: <87cz3ill2x.fsf@gmail.com> (raw)
I attempted to upgrade my packages today using `list-packages', which
errored out when regenerating the autoloads for vlf-write.el:
Debugger entered--Lisp error: (search-failed "\n\f\n;;;")
search-forward("\n\f\n;;;")
loaddefs-generate("/home/rpluim/.emacs.d/elpa/vlf-20191126.2250" "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250/vlf-a..." nil "(add-to-list 'load-path (or (and load-file-name (f...")
package-generate-autoloads(vlf "/home/rpluim/.emacs.d/elpa/vlf-20191126.2250")
The vlf-autoloads.el file ends like this:
--begin--
\f
;;; Generated autoloads from vlf-tune.el
(register-definition-prefixes "vlf-tune" '("vlf-"))
\f
;;; Generated autoloads from vlf-write.el
(register-definition-prefixes "vlf-write" '("vlf-"))
\f
;; Local Variables:
;; version-control: never
;; no-byte-compile: t
;; no-update-autoloads: t
;; coding: utf-8
;; End:
;;; vlf-autoloads.el ends here
--end--
which doesnʼt contain "\n\f\n;;;" after the vlf-write entry.
The code in question from loaddefs-gen.el:629 is
(when (file-exists-p loaddefs-file)
;; If we're updating an old loaddefs file, then see if
;; there's a section here for this file already.
(goto-char (point-min))
(if (not (search-forward head nil t))
;; It's a new file; put the data at the end.
(progn
(goto-char (point-max))
(search-backward "\f\n" nil t))
;; Delete the old version of the section.
(delete-region (match-beginning 0)
(and (search-forward "\n\f\n;;;")
(match-beginning 0)))
(forward-line -2)))
So itʼs assuming that the entry ends with ";;;"
This is a really old package, and itʼs probably somewhat obsolete, but
perhaps we should support such an old format without erroring anyway.
In GNU Emacs 29.0.90 (build 8, x86_64-pc-linux-gnu, GTK+ Version
3.24.24, cairo version 1.16.0) of 2023-05-02 built on rltb
Repository revision: 16ecbf5af6d4fcb500941ede4d029cffd8eac757
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
System Description: Debian GNU/Linux 11 (bullseye)
next reply other threads:[~2023-05-02 17:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 17:06 Robert Pluim [this message]
2023-05-03 8:40 ` bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible Robert Pluim
2023-05-03 8:48 ` Andreas Schwab
2023-05-03 11:21 ` Eli Zaretskii
2023-05-03 13:47 ` Robert Pluim
2023-05-03 15:02 ` Robert Pluim
2023-05-03 15:50 ` Eli Zaretskii
2023-05-04 8:45 ` Robert Pluim
2023-05-04 10:42 ` Eli Zaretskii
2023-05-04 14:04 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz3ill2x.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=63236@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).