From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sun, 04 Jun 2023 17:37:16 +0000 Message-ID: <87cz2buo1f.fsf@posteo.net> References: <83a5xf7pi5.fsf@gnu.org> <87ttvnoehl.fsf@posteo.net> <8335377iyo.fsf@gnu.org> <87h6rnoa8v.fsf@posteo.net> <83v8g35ybo.fsf@gnu.org> <87cz2bo3qu.fsf@posteo.net> <83pm6b5t1i.fsf@gnu.org> <878rczo28v.fsf@posteo.net> <83o7lv5sjc.fsf@gnu.org> <874jnno1bi.fsf@posteo.net> <83mt1f5rab.fsf@gnu.org> <87zg5fmkgk.fsf@posteo.net> <83a5xf5k65.fsf@gnu.org> <87cz2bxkz5.fsf@posteo.net> <834jnn5gxh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 63757@debbugs.gnu.org, artscan@list.ru To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 19:38:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5rgJ-0006bp-Rh for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 19:38:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5rg5-0003yb-En; Sun, 04 Jun 2023 13:38:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5rg2-0003yK-8i for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 13:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5rg2-00008M-0V for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 13:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5rg1-0000T5-Sj for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 13:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.16859002621764 (code B ref 63757); Sun, 04 Jun 2023 17:38:01 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 4 Jun 2023 17:37:42 +0000 Original-Received: from localhost ([127.0.0.1]:47078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5rfT-0000Rp-Pt for submit@debbugs.gnu.org; Sun, 04 Jun 2023 13:37:42 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:48657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5rfQ-0000RV-0W for 63757@debbugs.gnu.org; Sun, 04 Jun 2023 13:37:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7C880240103 for <63757@debbugs.gnu.org>; Sun, 4 Jun 2023 19:37:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685900238; bh=4XGAWObOcSgw+lvv2lko+Pn982ms5m46NHIRJmOUyLg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=gvrzcqdZbBgWJjuy9UqE0ixdo+qA/jGp/slqXNLKJXn75z7OpWn2Fth0RAzlmrPcr 4Qh26y8xOWiAesvEf/4KZUFUPBlg9TBogw4V7rOZyWhy2owHjCsBXldRGdKIHLok0I /+VEcEQkg8JsY3XQ4Q1tlUD2SDQK8APrjY+kcQrwG7jKrBjn7RDYeYTqWF8Y12GG9p lV4uVjZ6u+MSAbX4jFuqTGayDjRNR+yYLujgng7s2CNspCIRdAzl5j5Ax5eFbGL7fq t12IkVblmS1rJi61GzFmloMX1pqsVPU7psdcwP4Faa7ogUFruh8n1CyPfmmyUC0HW3 xWxNURGuKSvxw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QZ3pP2Lcvz9rxG; Sun, 4 Jun 2023 19:37:17 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Sun, 04 Jun 2023 12:53:55 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262983 Archived-At: Stefan Monnier writes: >> So what exactly was the change installed back in Aug 2022 supposed to >> improve? > > I believe its intention was only to give preference to the VC packages > (I still don't know why it moved the "prefer built-in packages" part > (and then changed it to test `package-disabled-p`); I presume it was an > accident). This is true, it was my mistake made when refactoring package-vc. > So my patch *may* be a regression for users of `package-vc`, but since > it's a new feature in Emacs-29, I think it's perfectly acceptable. > Especially because the sort it implemented is wrong (because the sort > predicate fails to define a partial order, so the output will depend on > arbitrary details of how `sort` happens to pass elements to the > predicate), so it's not at all clear that it does what it intends to > do anyway. > Furthermore I believe that it is mostly redundant: VC packages should > almost always already be sorted first by virtue of the version being > almost always higher than non-VC packages. I'll do some more testing to see if everything still works, but from what I see it seems like it is doing the right thing. The issue I was trying to solve back then did not exist. -- Philip Kaludercic