From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#64433: 30.0.50; Fix and improve setting priority of todo-mode items Date: Mon, 03 Jul 2023 14:23:08 +0200 Message-ID: <87cz195glv.fsf@gmx.net> References: <87h6ql5nkr.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28380"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 64433-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 03 14:24:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGIbe-0007BF-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Jul 2023 14:24:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGIb6-0005kD-MO; Mon, 03 Jul 2023 08:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGIb4-0005iQ-O7 for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 08:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGIb4-0001Eo-Eh for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 08:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGIb3-0007x8-TG for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 08:24:01 -0400 Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2023 12:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64433 X-GNU-PR-Package: emacs Mail-Followup-To: 64433@debbugs.gnu.org, stephen.berman@gmx.net, stephen.berman@gmx.net Original-Received: via spool by 64433-done@debbugs.gnu.org id=D64433.168838699930512 (code D ref 64433); Mon, 03 Jul 2023 12:24:01 +0000 Original-Received: (at 64433-done) by debbugs.gnu.org; 3 Jul 2023 12:23:19 +0000 Original-Received: from localhost ([127.0.0.1]:33424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGIaM-0007w4-NL for submit@debbugs.gnu.org; Mon, 03 Jul 2023 08:23:19 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:42727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGIaK-0007vq-27 for 64433-done@debbugs.gnu.org; Mon, 03 Jul 2023 08:23:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1688386990; x=1688991790; i=stephen.berman@gmx.net; bh=QpFilS/B7JFe0j8BMotlQ8MwoC9cI+6X28wc1WFyQ1c=; h=X-UI-Sender-Class:From:To:Subject:In-Reply-To:References:Date; b=R1sK5olD2NqK5tsemLjPnXLmR+/UDm8PaJWgAdEKfg0qW4E45mDgbqGrOHlfLOjMbzb9YDM eWSzL9dnHSRE/qEuBEqBPTwJ9arYc3+zP8E6DbCqaHSkHL0pocuODoo21+u8j3G2JWYgpz/GI 3rUOPGuvnbPKKkgEry4rW7UYH0jqT60FYqZdDEtzng+xAa3fVi0zm3Kdx6u+Oy76s6v7Bi5MG kz9l/tHMXSIBxL1hB5fBVDHDq+FLLX8+p2SwoSfyegVkaLMba4TTZq0A13iisvs51lvXISXIG H0KJ8ES7HbdA+7ukBC+VWJSXpz+yYJbdzq0FXC36Y+s+NpmfPrRA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([94.134.196.66]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQMuX-1qcchA3pNB-00MNoS for <64433-done@debbugs.gnu.org>; Mon, 03 Jul 2023 14:23:10 +0200 In-Reply-To: <87h6ql5nkr.fsf@gmx.net> (Stephen Berman's message of "Mon, 03 Jul 2023 11:52:36 +0200") X-Provags-ID: V03:K1:GDTIAopo9ZlxMdFSIW/0AoysVXtB1RLc1lWXLVLQjmrxrJpVTDI Eg/5waaPFc7yU2FDoWictyKaWNqv/VxiS2y5HmptyV72KdVjPFSGY8Znuy+GwbygrcZCPr3 UpE0ICZpNct0nA5tQ1WG0vrBEH22YccN/QWc6G1ZwqM29YPFnmBT31NqANCgZ93P5NI7o0a i3Ya2/nSzRFKPLSZ+HpnA== UI-OutboundReport: notjunk:1;M01:P0:p0rvusRH49Y=;qJIceyLJQhhVUsG0uuawfMxhVAO arByE/TDZBH0K6/sO5DUdGmIuGzrnS0hKfgMhBrwS1vcV66tbRcXASEunYs1HTWMIVtaNPj+o KUWtcS9soha1y5puU+6R3pQxOlvVUpGwSA4xIbv8Y+mC0mgL2u51/WgJuJJXIx5Z4lVcvX3sL +S47qsoJn3XxVpK2UsRWguoONonzVwbwul8GRB6tcU2MX0WgJzecB5e5xGJHolh/3VSJejzgE ji92TgH5WIk51zTG+kb9g2wbQrjQj18PC8c8aUiHdyoZIkAQeuiJcu3RjdoFkAV3PdsXtlPKq p3uHSS+03AAxTTwzRmrb0VaHSEnFeZvEMlZFbpXoly5G/z/HuYVed5rNO41AzakJWu0tbdZuN 154i5ZqHLtAfrv7uvAHjN1cVjRK59QhFQ/S23sKb6Eh6IM4XUi5j4PBnsRgCO3ICZHKknCcXq 023gKf4fGthIH8ZtRQ42CygiODMgHquEMGbonf5BxW41DGDqP/hgzkUZOV3pGpgQj+ydtvcsR Y5VV3M5XERH+4KLPXWPXxIcGkKnG8o+S5U8bXexcexjwXFwDK52TjL47oZg7bwR1n4ysv4+vT /W9pwYxu6JwJmDaUDUsMHcgPrW1aPUh+SYe494tebl+T1VklDfjuvDr7TMGzCrk4rCVPlSWxL nEjC2qXA6H1PhaZBW7lku7rmZRq6Iqk03+7r5y2GdkNAvME9iTqX3tdjpn3S4ktsmQMv1gW9k u5XIlleWlMpyol0J632a8Ig4tDOlHAeHr/zCL2wbhhU9zV/x2rpW3HduLTykRfZgu3aSAEw3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264522 Archived-At: On Mon, 03 Jul 2023 11:52:36 +0200 Stephen Berman wrote: > There are several bugs in setting the priority of todo items in > todo-mode: > > - On typing `#' you are prompted to enter a priority; for example, in a > category with 7 items the prompt is this: > Set item priority (1-7) (default 1): > If you enter a number outside of this range, there is another prompt: > Priority must be an integer between 1 and 7. > (default 1) > This prompt is infelicitous, occupying two lines and lacking a colon > to indicate an expected input. > > - You can also set the priority by passing a numerical prefix argument, > e.g. `C-u 7 #' or simply `7 #' sets the priority to 7 directly without > prompting. However, here out-of-range prefix arguments are accepted > and the result is at least in two cases odd: typing `0 #' sets the > priority in a category with 7 items 1 by default (1 is always the > highest priority). And typing `8 #' or e.g. `8761 #' sets the > priority to 7, which may seem reasonable; however, with a negative > prefix, e.g. `-3 #', the priority is also set to 7. > > - If, in a category with, say, 7 items, with point on the item with > priority 4, you type `#' and at the prompt enter 4, or if you invoke > `4 #', then the priority of the item is correctly unchanged, however, > the buffer is marked as modified. Since setting the priority to the > item's current priority is useless, doing so is probably > unintentional, so it would be better for todo-mode to respond with a > prompt for a different priority. (An exception is moving an item to > another category: it is and should remain possibly to move an item > from a category in which it has priority 4 to another category and > there give it priority 4.) > > I have a fix for these bugs and will install it on master when I get a > bug number. > > In addition, I will install a minor improvement in the usability of > priority setting: making the minibuffer history for priority setting > consist of the range of item numbers (or in the case of adding a new > item, the maximum priority number is one more then the last item > number). This is useful to quickly invert the default (set by a user > option); e.g., with the default priority 1, in a category with 37 items, > typing `M-p' at the prompt to enter the priority will insert 37 in the > minibuffer (or 38 if a new item is being inserted in the category). Pushed to master as 14ae2101412, closing bug. Steve Berman