From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Davide Masserut via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65604: [PATCH] Display the exit code if the last command failed in Eshell Date: Thu, 31 Aug 2023 11:31:53 +0200 Message-ID: <87cyz38rj2.fsf@mssdvd.com> References: <87cyz5wjtm.fsf@mssdvd.com> <05108d35-d095-c975-78b8-6b00fc7e6a08@gmail.com> <87o7iolg6o.fsf@mssdvd.com> <83v8cwfphy.fsf@gnu.org> <87wmxc4ah3.fsf@mssdvd.com> <83fs40fi35.fsf@gnu.org> <87msy8s344.fsf@mssdvd.com> <83a5u7g6f3.fsf@gnu.org> Reply-To: Davide Masserut Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13821"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65604@debbugs.gnu.org, jporterbugs@gmail.com, me@eshelyaron.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 31 11:57:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbeQT-0003Jo-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Aug 2023 11:57:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbeQG-000415-VW; Thu, 31 Aug 2023 05:57:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbeQF-00040x-J6 for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 05:57:07 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbeQ2-0001tv-Pl for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 05:57:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbeQA-0003OA-Fu for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 05:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Davide Masserut Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65604-submit@debbugs.gnu.org id=B65604.169347577412963 (code B ref 65604); Thu, 31 Aug 2023 09:57:02 +0000 Original-Received: (at 65604) by debbugs.gnu.org; 31 Aug 2023 09:56:14 +0000 Original-Received: from localhost ([127.0.0.1]:54897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbePM-0003Mz-4E for submit@debbugs.gnu.org; Thu, 31 Aug 2023 05:56:14 -0400 Original-Received: from out-250.mta0.migadu.com ([91.218.175.250]:31636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbePG-0003Mj-Cb for 65604@debbugs.gnu.org; Thu, 31 Aug 2023 05:56:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mssdvd.com; s=key1; t=1693475756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yFdjiPoyGqTa2vzMmF+yCpuMs/IxEDG3zB6rLmjrk8Y=; b=UDcVjdoD4IT75lCHm+CA6WZXnjGvheV0zhWG0uEfafkrHd2p7Mf70jht4YjYXqE7NMjfvn UzV4mcbISJiZNIDl1oL/6cMhPiyTDo1Z1WY5mz47cFC4UQJEFDM7RBYxAvNLgYeJUMoHuL Lg0YCkiNqvv7fDVDX2fpSdNWzXfLli812uhYRWQtnjOYj5NibnkuIRW4T/XzWe4z9O11Uu 0p9MXv2d4FPWG2IVvOYgHgOY9lJ3WKXuPYuu8TflF1UPfxMOhFSM8SjZyLJPQVa6e8Bepk xYS99Ocd1uXJXOeCD+8hP9sBlaLJH2On87V7dEfAmMyV+vi/nZV6kvj3qh+tIA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <83a5u7g6f3.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268805 Archived-At: Eli Zaretskii writes: > Ah, that. Yes, the properties will be ignored. But do we > really need > fancy faces on that display? They make the error stand out. > (FWIW, I personally don't like the idea of showing this on the > mode > line: the mode line is already quite cramped I agree with you, this is one of the main reasons I had in mind when I made the first patch. > and OTOH Bash does show abnormal exit codes as part of its > prompt. But feel free to disregard > my opinions, as I'm not a heavy user of Eshell.) fish and some zsh distributions also show the error in the prompt.