From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65919: 29.1; build without xinput does not get focused when hovering over window Date: Fri, 15 Sep 2023 13:17:46 +0800 Message-ID: <87cyyk10cl.fsf@yahoo.com> References: <87led9rxw0.fsf@ipvych.com> <87edj12lbk.fsf@yahoo.com> <87fs3hrriy.fsf@ipvych.com> <87a5tp2eyz.fsf@yahoo.com> <87y1h817qd.fsf@yahoo.com> <87ttrwulzt.fsf@gnu.org> <87h6nw126w.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12762"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65919@debbugs.gnu.org, Lars Ingebrigtsen , Ivan Popovych , Amin Bandali , Bob Rogers To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 07:19:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh1Ee-000366-Kj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 07:19:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh1EI-0005ng-9L; Fri, 15 Sep 2023 01:18:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh1EG-0005nA-Hk for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 01:18:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh1EG-0000Vz-9R for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 01:18:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh1EM-0003DQ-Cx for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 01:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 05:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65919 X-GNU-PR-Package: emacs Original-Received: via spool by 65919-submit@debbugs.gnu.org id=B65919.169475509612278 (code B ref 65919); Fri, 15 Sep 2023 05:19:02 +0000 Original-Received: (at 65919) by debbugs.gnu.org; 15 Sep 2023 05:18:16 +0000 Original-Received: from localhost ([127.0.0.1]:41788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh1Db-0003By-KY for submit@debbugs.gnu.org; Fri, 15 Sep 2023 01:18:15 -0400 Original-Received: from sonic311-25.consmr.mail.ne1.yahoo.com ([66.163.188.206]:42974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh1DY-0003Bh-9S for 65919@debbugs.gnu.org; Fri, 15 Sep 2023 01:18:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694755080; bh=on5P8KSo/gIdtDtiK1MpiVNYPbM4M2NMNAldsQfa1zE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=MrqJfx1MZLrzpnopdcPbZAb67TDoaoxKZz+ysM7dU5yVgCOXpoWYPo8MsjpzXuNPnkjQ+kl7GoBVlCyvg6o/sYfCMS9VZtmCwTGV+ZtfNzwID9c5RM67ntjZOq3h94ayIsE+HUfkaOeJ+beKkZ5veATe5SkgG3Ldvu+hzaRBgayS2Bfcpq3B5PqRfXCu6It1clehzR3llX+a1cfRBvV/MkuPqNPnVuqdukl3s4MmKlZXoEQXWJPzsGgRqkB9ioosNO/Ibfb4ZaqbQ13x3+yN45kDe3wXbh9yga5rPfMiYaE889unlC+qnTFe2ctKycyVG3OGmIjlRW01Q0h6aNZH3A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694755080; bh=wRBeRth8cRkm8SYJ6CqmJnkd3mu1RRZmjgyXADIyaiS=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=kj/kjfmNyu9ufDvNXnqOr79ArYrFYufwVtoYbdjJRaJ6tHead9ezF0E2UOgk1RduagixHuq8rc6whypZRND8obnOhCarFzi0JTn/XzHSFi1nCkyg9jJqoXYRmfJ0o+afb0MveQsVT88GtB92hSIsksIwxm7mY7D4oQ+2gMrUCTtZfKyDnaipbjcZyY++L0rGO34CBoalny8eHPmDJ6UdCp/ZVP3f/+7wfQkBA3GaGF8DdFtF5gDwprTivjvefMPOZM9SDQiFXAs9KvabC7OW4jp9+dJiMX5/JkwyakU5h7lDS1GWbPE7eMGXteAfynIg83dDymS34m4lNkSlIkcFlA== X-YMail-OSG: FR12mwkVM1ntZCp.lZWHMXt4DiKiLkNIvLxAs1JOaLIkKB.TqVnf_Zy11OghioZ JkbIjrxniOqzufzjLJGhVZsMe0zcVAvEFiDWBC.9_xuAXc5fQ5APYHUT.VZVGSRtowyKsnE2TAOX BBqVFlJq972EBxiwj1J84O7f0ZeLeP8lLAJDSK_lM.2NsxqC7yFJTbzDYwaY33fWgVEQF2LxyP06 4mDOwxdx66IKnrpmG.MGWWcS_JlfTbOKIHPYj0JPuBOuBbgmm13oOxTTm.6LARttvvKJwHbsevv5 hfw.qFToxtT7kLxJV1Dr7iq8bF7wszbknD8rT6gEsh2atbbjbZh.HncmD51mqZAec_.ie1FV_7d9 t1WIu8bm9jXQ0nyS6Wa_cEGcxSHHvG3S25Mb2bQdoRNhrFmjST6In9_NJ75qNAHvpDZqGKvWTBY_ CA2Zp9yt6PDiU5t3mDdpDVV1GaeyxkLu0MKJaHp4yTzJ2qKE9S9Z0_X8Mz4JPs.jgL699EBRkS8o HGGDbpuQoAfQk4meex14uVIKGt5skvHSp3Wm59swKlBKkEJalWbU_4DnRx93iZjbGyRrLY1gVMF8 cRx7r0IYX4CBn7x6xllTt7FmSP.4pXx1dbcu39m70gOZibNMLE6RGRlBkIrZjzcf.eiyYfJ_ZebV HVv_.9Xo2z_ys0.vqs6aUdlO3KP_bExQwYtyIzk_6TVQYGCX4kFgSRKZJzdXGaDDNsudPTy5ZnGf Tf6YOHZI7NhuOZ.jEEQe83dEb5Ss0c6Q2JbjinaXB9Gl_ff6.UPN0dQkH_ltBAYl7W1kIWRXjRyx JvNQiVA4hb.HIO6BaQEkgsgzd9cYb6UNEjOzS38x7v X-Sonic-MF: X-Sonic-ID: b16e7020-bdfc-4e6b-9608-eaa870be12a7 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Fri, 15 Sep 2023 05:18:00 +0000 Original-Received: by hermes--production-sg3-55c667b499-fc69l (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b40d15680c3cda39ffbac9634ca4caee; Fri, 15 Sep 2023 05:17:53 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Thu, 14 Sep 2023 22:06:17 -0700") X-Mailer: WebService/1.1.21797 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270482 Archived-At: Stefan Kangas writes: > Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: > >>> FYI your e1a730017d6 patch introduces the following compiler warning: >>> >>> process.c: In function =E2=80=98child_signal_notify=E2=80=99: >>> process.c:7436:54: warning: suggest braces around empty body in an =E2= =80=98if=E2=80=99 statement [-Wempty-body] >>> 7436 | /* emacs_perror ("writing to child signal FD") */; >>> | ^ >> >> Thanks. Does this silence the warning? > > AFAIU, the point here is to fix a warning in > > if (emacs_write (fd, &dummy, 1) !=3D 1) > /* emacs_perror ("writing to child signal FD") */; > > for which the easiest solution should be > > emacs_write (fd, &dummy, 1); > > This avoids having to disable -Wempty-body everywhere, which IMO doesn't > seems justified just to silence this one warning. > > What am I missing? It's not to fix a warning, but to communicate that we would like to call `emacs_perror' there, yet cannot, given that it is not a reentrant function.