From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Fri, 22 Sep 2023 13:30:41 +0000 Message-ID: <87cyyawd1a.fsf@localhost> References: <878r919qfh.fsf@localhost> <72c93fb0-bf3e-3dad-69c0-2147cfa40f57@gutov.dev> <875y42xyex.fsf@localhost> <87zg1ewfc2.fsf@localhost> <834jjm749q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40910"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 15:30:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjgEY-000ARs-Nu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 15:30:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjgEE-0003fi-O7; Fri, 22 Sep 2023 09:29:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjgEC-0003f0-PM for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 09:29:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjgEC-0007Pm-9t for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 09:29:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjgEM-0006a6-DA for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.169538938825251 (code B ref 66117); Fri, 22 Sep 2023 13:30:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 22 Sep 2023 13:29:48 +0000 Original-Received: from localhost ([127.0.0.1]:35671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjgE7-0006ZD-TL for submit@debbugs.gnu.org; Fri, 22 Sep 2023 09:29:48 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:47203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjgE3-0006Yw-JP for 66117@debbugs.gnu.org; Fri, 22 Sep 2023 09:29:46 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D9A63240027 for <66117@debbugs.gnu.org>; Fri, 22 Sep 2023 15:29:26 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RsY5f0dy8z6tvn; Fri, 22 Sep 2023 15:29:25 +0200 (CEST) In-Reply-To: <834jjm749q.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271096 Archived-At: Eli Zaretskii writes: >> Will it be acceptable to implement the cache using variable watchers? > > I don't like us using variable watchers for such stuff. > > Why cannot we just cache the correspondence between files and buffers > in some hash-table? Because `buffer-file-name' can be modified from Lisp (via `set-visited-file-name' or directly). Same for `buffer-file-truename' and `buffer-file-number'. Or should we just assume that these variables remain unchanged other than by primitives? >> The regression might happen when the number of buffers is small - >> when hash tables become slower compared to simple list lookup. >> But in such scenario, we will be talking about very small absolute >> runtimes anyway, so it should probably not matter in practice. > > Alternatively, only create the hash-table when the number of buffers > exceeds some threshold. Indeed, this is a good idea. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at