From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Sun, 28 Jan 2024 11:28:26 -0800 Message-ID: <87cytlqmqh.fsf@breatheoutbreathe.in> References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87msx8sbpv.fsf@web.de> <87bkdoh1gy.fsf@breatheoutbreathe.in> <87h6ngs85e.fsf@web.de> <87ttr7nzyj.fsf@breatheoutbreathe.in> <83pm1u6f8l.fsf@gnu.org> <83fs2o2wb0.fsf@gnu.org> <83v8bj2794.fsf@gnu.org> <83r0m70zwp.fsf@gnu.org> <83sf6mzcz6.fsf@gnu.org> <878r72odzs.fsf@breatheoutbreathe.in> <87il4uvoob.fsf@breatheoutbreathe.in> <8734v7vsjy.fsf@breatheoutbreathe.in> <87a5otqggx.fsf@breatheoutbreathe.in> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, Eli Zaretskii , philipk@posteo.net, 66187-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 28 20:32:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUAsv-0003Vj-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jan 2024 20:32:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUAso-0002VD-DE; Sun, 28 Jan 2024 14:31:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUAsl-0002Uq-VB for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 14:31:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rUAsl-0001zx-7L for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 14:31:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rUAss-0006qz-Jw for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2024 14:32:02 -0500 Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jan 2024 19:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 66187 X-GNU-PR-Package: emacs Mail-Followup-To: 66187@debbugs.gnu.org, joseph@breatheoutbreathe.in, joseph@breatheoutbreathe.in Original-Received: via spool by 66187-done@debbugs.gnu.org id=D66187.170647026226256 (code D ref 66187); Sun, 28 Jan 2024 19:32:02 +0000 Original-Received: (at 66187-done) by debbugs.gnu.org; 28 Jan 2024 19:31:02 +0000 Original-Received: from localhost ([127.0.0.1]:58383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUArt-0006pN-Ma for submit@debbugs.gnu.org; Sun, 28 Jan 2024 14:31:02 -0500 Original-Received: from out-186.mta1.migadu.com ([95.215.58.186]:58789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUArq-0006p7-VD for 66187-done@debbugs.gnu.org; Sun, 28 Jan 2024 14:31:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1706470249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jB9Vx/LyAJvheCsz/vGkZyyVDr0yQ4YVnJBE5caMzwE=; b=ncBujYPybUxXBv8iShoXGV4dggBKhpAY8lUzNyaFmJs7d+CH09qlUYfBR5ZhJlaVRrn92W hX4EYpnn0M+P2gCOV7VB3vU/HRajvWxZBw5x1BOpYXHBlQMqAm+tOpkwXV99Rmg/Q4zPcL 9ye5SpF/SjqS8W9BQaZ/KrgOZoeOcZg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279103 Archived-At: Stefan Monnier writes: >> Ping! I hope a fix like this can be merged into Emacs 29 still :) > > Duh, I can't believe I left you waiting for so long, this is awful. > I just pushed this to `emacs-29`, thank you. > I hope there might still be a next time, so I get a chance to do better. It's all good!! Life is happening :) Thank you!! Joseph > > Stefan > > >> From 609bf4964f88b01f4843e29b2cf71ee1cd2f6125 Mon Sep 17 00:00:00 2001 >> From: Joseph Turner >> Date: Sun, 12 Nov 2023 13:21:50 -0800 >> Subject: [PATCH] Fix completing-read functional REQUIRE-MATCH behavior >> >> * lisp/minibuffer.el (completion--complete-and-exit): If >> minibuffer-completion-confirm is a function which returns nil, >> immediately fail to complete. >> >> See bug#66187. >> --- >> lisp/minibuffer.el | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >> index 3e30b68d5e9..9fad3e71fad 100644 >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -1847,10 +1847,13 @@ appear to be a match." >> ;; Allow user to specify null string >> ((= beg end) (funcall exit-function)) >> ;; The CONFIRM argument is a predicate. >> - ((and (functionp minibuffer-completion-confirm) >> - (funcall minibuffer-completion-confirm >> - (buffer-substring beg end))) >> - (funcall exit-function)) >> + ((functionp minibuffer-completion-confirm) >> + (if (funcall minibuffer-completion-confirm >> + (buffer-substring beg end)) >> + (funcall exit-function) >> + (unless completion-fail-discreetly >> + (ding) >> + (completion--message "No match")))) >> ;; See if we have a completion from the table. >> ((test-completion (buffer-substring beg end) >> minibuffer-completion-table