From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Collin Funk Newsgroups: gmane.emacs.bugs Subject: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90 Date: Thu, 08 Feb 2024 19:00:02 -0800 Message-ID: <87cyt6nxzh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15578"; mail-complaints-to="usenet@ciao.gmane.io" To: 68996@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 09 06:15:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYJEG-0003mS-22 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Feb 2024 06:15:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYJDu-0005Qh-3a; Fri, 09 Feb 2024 00:14:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYJDs-0005O9-9Z for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 00:14:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYJDs-0006i4-0u for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 00:14:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYJE6-0001i7-LF for bug-gnu-emacs@gnu.org; Fri, 09 Feb 2024 00:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Collin Funk Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Feb 2024 05:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68996 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17074556716475 (code B ref -1); Fri, 09 Feb 2024 05:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Feb 2024 05:14:31 +0000 Original-Received: from localhost ([127.0.0.1]:34092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYJDY-0001gH-3r for submit@debbugs.gnu.org; Fri, 09 Feb 2024 00:14:30 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:43302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYH9c-0004E4-2P for submit@debbugs.gnu.org; Thu, 08 Feb 2024 22:02:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYH9H-0008LI-I1 for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 22:01:55 -0500 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYH9F-0005PH-Lu for bug-gnu-emacs@gnu.org; Thu, 08 Feb 2024 22:01:55 -0500 Original-Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1da0cd9c0e5so4245495ad.0 for ; Thu, 08 Feb 2024 19:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707447711; x=1708052511; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Iq+e1vCR0nXzei4u3jXTtA/pB3ZeIfxf72oTkKh4bGk=; b=i36OomHtp7CfUicP4Pd2M3V4mIZhuN1IxtG+n4klLMME5qpgQ/v3rK49k2NE8SCJor WMQSjC0xaE59gDMc+shLgQ456YujNkx8XKsVtsDdgJjm1zMqB4u9rph/LbDRBBHA+cTq NTvppw6syA/Wof/nIc6UQ9W1UazHLngtigweTXPGCJk4lzAtU5gj8G3RezbH4IxRU7i1 ZoWGzDwdwdBsgito+oqkXW0JjXQXnypkiz907ocO49a9zxZm2Ur7lrfFYcfaUWohrRT/ DJOtQU1R3TpsC6wqjflq+oNkcc6i9KYLCN1RM+ngcWCcDCfpe0uLq/QOSvydqf1gxb4e DclA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707447711; x=1708052511; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Iq+e1vCR0nXzei4u3jXTtA/pB3ZeIfxf72oTkKh4bGk=; b=KZA6sJ6jEkHvfGwgXsddqrPjdcV1547ONvVPS6cbrQ/n4ybWd4sAprG9HUEEGSqDlQ x6/j7ZChBmEIAfuTZ36B6KAY84Rg4ArKgDWtlGDIj7hApJWWY2GU7A/jlN95EXvLm8OF XvbW32nHmILf3CjvoEmOoE+BGKX/GcEE5y2R+bLZK/8WnVo7/QAh0RT3oXsFdxq0WxeS NObKN1P4Kf7PK8PiyoiRad44i2Ko46aN7nYVpyN00OgKRZyMvGs92IX0Vvvzm8HEGEC7 W2xjLCSO5kBdqpaAl2/aTkbrcuzBL5S6rbORUVyy3lrS1h85WkTHWatDs2TYxKa8livz STSQ== X-Gm-Message-State: AOJu0YxHxglOA7ImIPthK+hY3C6JdSAIicjvf9clTA6j5y0KAHlxHWW+ 8MI+5mkol0ENEODrcAP1OXIjsq3DZ/1ILD+C6AfucIbWOq/xCmkzdl2Y0UJ2XWM= X-Google-Smtp-Source: AGHT+IGbO32+gr/a+AFdZiOZIYAbQSqWMbMa1V6lsLyRua/VZddxhCvztzewyQXLAVVDkRGAlkeEmg== X-Received: by 2002:a17:902:cece:b0:1d8:e1c0:1bb8 with SMTP id d14-20020a170902cece00b001d8e1c01bb8mr573041plg.27.1707447710921; Thu, 08 Feb 2024 19:01:50 -0800 (PST) Original-Received: from debian (c-73-189-213-139.hsd1.ca.comcast.net. [73.189.213.139]) by smtp.gmail.com with ESMTPSA id e13-20020a170902d38d00b001d9c8b313d8sm475869pld.182.2024.02.08.19.01.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 19:01:50 -0800 (PST) X-Google-Original-From: Collin Funk Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=collinfunk38@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 09 Feb 2024 00:14:26 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279675 Archived-At: --=-=-= Content-Type: text/plain Tags: patch Tags: patch When building Emacs with recent versions of GNU Make every object file built will result in a warning like so: ../src/verbose.mk:58: warning: invalid variable reference ' ' CC emacs-module.o This doesn't prevent Emacs from building but makes it slightly harder to see any build output. I attached a patch that should work for all versions of GNU Make, both before and after the change. However it also causes the indentation to disappear in-front of CC and ELC which looks a bit strange. It doesn't seem like there is a valid way to do this at the moment. More discussion about this change can be seen here: https://savannah.gnu.org/bugs/?65273 Feel free to change my patch if you see a better way to solve these warnings. Also, I have never committed to Emacs. This change feels trivial but results in 34 lines changed. Therefore I was unsure if this patch could be Copyright-paperwork-exempt tagged. Feel free to email me off list if I must fill them out. Thanks Collin In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-02-07 built on debian Repository revision: ed2450e79b597e0306f14b542e934a90dfd9786f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --prefix=/home/collin/.local --with-sound=no --with-libsystemd --without-gconf --without-compress-install --with-native-compilation=yes --with-cairo --with-x=yes --with-x-toolkit=gtk3 --with-harfbuzz --with-tree-sitter --with-json --with-imagemagick' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Respect-warnings-added-in-GNU-Make-4.4.90.patch >From dee15de965a10f3cc9816c0e177b9a3208f367a8 Mon Sep 17 00:00:00 2001 From: Collin Funk Date: Thu, 8 Feb 2024 18:19:45 -0800 Subject: [PATCH] Respect warnings added in GNU Make 4.4.90 * src/verbose.mk.in: Get rid of invalid variable references in the info function. These were used to indent messages in build output but cause warning spam in GNU Make 4.4.90 and later. More information about this can be found here: https://savannah.gnu.org/bugs/?65273 --- src/verbose.mk.in | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/verbose.mk.in b/src/verbose.mk.in index e72c182f276..d2c28909436 100644 --- a/src/verbose.mk.in +++ b/src/verbose.mk.in @@ -53,38 +53,38 @@ have_working_info = $(filter notintermediate,$(value .FEATURES)) # The workaround is done only for AM_V_ELC and AM_V_ELN, # since the bug is not annoying elsewhere. -AM_V_AR = @$(info $ AR $@) +AM_V_AR = @$(info AR $@) AM_V_at = @ -AM_V_CC = @$(info $ CC $@) -AM_V_CXX = @$(info $ CXX $@) -AM_V_CCLD = @$(info $ CCLD $@) -AM_V_CXXLD = @$(info $ CXXLD $@) +AM_V_CC = @$(info CC $@) +AM_V_CXX = @$(info CXX $@) +AM_V_CCLD = @$(info CCLD $@) +AM_V_CXXLD = @$(info CXXLD $@) ifeq ($(HAVE_NATIVE_COMP)-$(NATIVE_DISABLED)-$(ANCIENT),yes--) ifneq (,$(have_working_info)) -AM_V_ELC = @$(info $ ELC+ELN $@) -AM_V_ELN = @$(info $ ELN $@) +AM_V_ELC = @$(info ELC+ELN $@) +AM_V_ELN = @$(info ELN $@) else -AM_V_ELC = @echo " ELC+ELN " $@; -AM_V_ELN = @echo " ELN " $@; +AM_V_ELC = @echo "ELC+ELN " $@; +AM_V_ELN = @echo "ELN " $@; endif else ifneq (,$(have_working_info)) -AM_V_ELC = @$(info $ ELC $@) +AM_V_ELC = @$(info ELC $@) else -AM_V_ELC = @echo " ELC " $@; +AM_V_ELC = @echo "ELC " $@; endif AM_V_ELN = endif -AM_V_GEN = @$(info $ GEN $@) -AM_V_GLOBALS = @$(info $ GEN globals.h) +AM_V_GEN = @$(info GEN $@) +AM_V_GLOBALS = @$(info GEN globals.h) AM_V_NO_PD = --no-print-directory -AM_V_RC = @$(info $ RC $@) +AM_V_RC = @$(info RC $@) # These are used for the Android port. -AM_V_JAVAC = @$(info $ JAVAC $@) -AM_V_D8 = @$(info $ D8 $@) -AM_V_AAPT = @$(info $ AAPT $@) +AM_V_JAVAC = @$(info JAVAC $@) +AM_V_D8 = @$(info D8 $@) +AM_V_AAPT = @$(info AAPT $@) AM_V_SILENT = @ endif -- 2.39.2 --=-=-=--