From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Fri, 01 Mar 2024 14:20:23 +0530 Message-ID: <87cysee3ow.fsf@gmx.net> References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20417"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 69232@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 01 09:51:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfycX-00057W-Rc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Mar 2024 09:51:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfycC-00011l-K8; Fri, 01 Mar 2024 03:51:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfycA-0000vn-Og for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2024 03:51:34 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfycA-0006R8-Gk for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2024 03:51:34 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rfycc-0002Fz-3c for bug-gnu-emacs@gnu.org; Fri, 01 Mar 2024 03:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Mar 2024 08:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.17092830808620 (code B ref 69232); Fri, 01 Mar 2024 08:52:02 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 08:51:20 +0000 Original-Received: from localhost ([127.0.0.1]:36069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfybu-0002Ex-V2 for submit@debbugs.gnu.org; Fri, 01 Mar 2024 03:51:20 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:53461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfybe-0002E3-80 for 69232@debbugs.gnu.org; Fri, 01 Mar 2024 03:51:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1709283028; x=1709887828; i=jimjoe@gmx.net; bh=Pvz2fd4kH7VrTY+87/MlfVXhraecuUSf2yTyS43Ejr4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=e2AVU27RmKXfGE/Ug3diMFlJoJlKmKsPu4e3cz15SJXiB0vNYTZIyzZEocm9BcCZ W38+gQAaB6nY5vs5Q2Y1Mu/zJfq1B1ukWTmFmVIqBQ+K9icg/W2ulyrk6KATdbEMn wMth3w4hRymup3oVh+EkGut7jvmgQUN1UWgb4WRZi4/vEsxJrwPvCXfzBubJFEtL5 MkIQmW7fyD6uRiTjurXXcM6uQRAsnuSOMwvdCRmvbapKRc/7kay9A/PfN2x87v3Vl QZQ6wrpwid1OLtnJ7r5zhG7H17ZYNSxeG+HCUsxqLrlAWm++zZdvA3DjRZjRk8knV i+nB3q9XImTAHsrz3g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-15-5518 ([117.216.1.160]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1N9MpS-1qlp711ike-015FhP; Fri, 01 Mar 2024 09:50:27 +0100 In-Reply-To: <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> (Jim Porter's message of "Thu, 29 Feb 2024 18:10:19 -0800") X-Provags-ID: V03:K1:9+j3QQpk0sfKXkwJEo42r+bpr59h3QdhZzSc78wrXQQ1+ccYiGG VvayarKJlxbUsahLWH3VzbbV7oIp0iJs8wmbQMq6ya3Lk/fzmcsoHZ2Iu0idZjU26mh8iVb JUHnC7kjp02iw+J2PErAahQOCJ5LsEdUfrEzVPVOrUMamXKPOpWjiMGXl4imcFaB1ulP4nA JTp76i0zqwjX+X0yKoxGw== UI-OutboundReport: notjunk:1;M01:P0:4fvCZYlqqiM=;l8ENa4IdM+H8ZFIkv2g7bDsQ9kc NomCdabF3X2b8TgOIQYbTqh+GwnV5F3yvYKxb9TJNsyTtwSI6BSc6RuGD5LI7zk78pDUwwXl3 HZykeIm4NT3Ry5fvqBpVlK5dqApnkACSa/eVVRW8C/89SMrYeHw9du/xJvsYtVfOpb8w1RXFb BJDNMgPi2E5swC77L/o4LLg0wzNid2k5lz9Lk1GDyvfYgezLFlvR8y6QeyO2jmaMKUI70c3D2 be7JVTLJ8KpTHEOjiCWC7ohK3O/7yT6zkH0ibVV5x1iMvoshC09C+X65YUDoarvfkDOTN+MEr vaB5oC/lg2hF97fRQ7TazY1xXnU7UCrWGS9huaTimfZWwUhM8ObO7k6e1C8LyjrTcejlOrQnr CmxLMuiRly3GVut7sKY32b2oO2TiBUmxH9pEjdhtZngVv66qwCUDhPyTH9GJdjACzX6+AzvIh fSZJJhX5ZyGjzxgD1VvA6GcJORlrYg/myfSuTyl18FJgf6ctlxsQEpXSG3qodpbeCYq/YN+eD vSGVtqNOdFHGT3+TiXkNrVOG572mP2bmSHgZfmUZYmp3dZZt2NiCilQczFKf6qHwbEOBJTEEt mWThNd5sorWwPcZzx92By/cbIVhyG+8AWoubXraiRxowjzrCGVI9JyIgc5PSZEqEbLStXdXZS qeLGlipfp49svV16TrOc8rDmli7AoN6R8KuvYWfmWeEh4rODb4vRV/QOT0Ua+VsoxjRUr6mtW p5IiE7j3v6J95kyKLMSuwoF5R0LRo9RC9Za/jZrcJVHvl6YokK+NoOhy9ByAyr7/XkXD3cXF X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280849 Archived-At: Jim Porter wrote: > On 2/29/2024 5:00 PM, Jim Porter wrote: >> I already found one issue with reloading messing up history, but >> that was an easy fix. Once I finish up the other parts of my v3 >> patch, I'll post it here. > > I've only lightly tested this so far, but this version adds an > 'eww-before-browse-function' option which lets you customize how EWW > manipulates history before browsing to a new page. I've added > functions for the default behavior ('eww-clear-future-history'), and > for cloning all the "parent" entries > ('eww-clone-previous-history')[1]. You can also set it to 'ignore', > which will just preserve the old entries and add the new page to the > end (which is the behavior v1 of my patch had). > > I've also added more regression tests to make sure this all works as > expected. > > How does this look? I'm using it with the following: --8<---------------cut here---------------start------------->8--- (defun eww-clone-previous-history-upto-first () "Like `eww-clone-previous-history', but only clone up to the first occurrence of the current page in the history." (when (> eww-history-position 1) (setq eww-history (append (cl-subseq eww-history (- 0 (cl-position-if (lambda (elt) (equal (plist-get elt :url) (eww-current-url))) eww-history :from-end) 1)) eww-history)))) (setq eww-before-browse-function #'eww-clone-previous-history-upto-first) --8<---------------cut here---------------end--------------->8--- ...for getting the behaviour I'd referred to earlier: > ... so because that might sometimes be too much, (adding to the end) > only the entire history up to the first occurrence of the source page. Will report back if I see any problems. Regards, James