From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72305: [PATCH] Fix DocView's text conversion on tty Emacs Date: Fri, 26 Jul 2024 22:48:00 +0100 Message-ID: <87cymzakq7.fsf@jeremybryant.net> References: <878qxorw4k.fsf@ledu-giraud.fr> Reply-To: Jeremy Bryant Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9812"; mail-complaints-to="usenet@ciao.gmane.io" Cc: manuel@ledu-giraud.fr To: 72305@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 26 23:49:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sXSoN-0002NA-Tc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Jul 2024 23:49:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sXSo3-0001vB-VP; Fri, 26 Jul 2024 17:48:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXSo1-0001ua-SQ for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 17:48:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sXSo1-0000S0-KH for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 17:48:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sXSoA-0007KH-Ft for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 17:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2024 21:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72305 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 72305@debbugs.gnu.org, Manuel Giraud Original-Received: via spool by submit@debbugs.gnu.org id=B.172203050428095 (code B ref -1); Fri, 26 Jul 2024 21:49:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jul 2024 21:48:24 +0000 Original-Received: from localhost ([127.0.0.1]:40181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXSnY-0007J4-89 for submit@debbugs.gnu.org; Fri, 26 Jul 2024 17:48:24 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sXSnV-0007Iw-65 for submit@debbugs.gnu.org; Fri, 26 Jul 2024 17:48:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXSnL-0001q8-7d for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 17:48:11 -0400 Original-Received: from out-179.mta1.migadu.com ([2001:41d0:203:375::b3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sXSnG-0007Y5-TL for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2024 17:48:10 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1722030482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k/KX6I5wgC2R21yIYRr1bpGqg8cL6Hy04WDifb3zIAM=; b=MVns1qqkNLRObCBLiHaN4grK0EfBBh2aR5ZuNPZj76QJ007FAvCWzcRJCw+3wbAi05/lUf OMeFqD0sSOARkgIZkCnynpFKoBWtXlajhCsOrsGWih3ILk7AEamgwJNcZmHKTgpYV8U/40 P4hD1dIM9c/yI134R063gCPhow2dse3qL9v26wYWgz3wp5bAVaKYKriPfrxMvRlKbADG1G V25N8JBIK4P5PirUkEmivvenJjZrEvbNRQc9c5dpEUyNdnG/evX4+aqGFVE2irnR1r+UKI Du1gdsk6aB8BCx7NYcJcfm6pHYi3OpKr7jtx3xowfYpgyGFgjY2QyRf3WxIC2g== In-Reply-To: <878qxorw4k.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Fri, 26 Jul 2024 17:49:47 +0200") X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::b3; envelope-from=jb@jeremybryant.net; helo=out-179.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289394 Archived-At: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Tags: patch > > Hi, > > When doing 'M-x doc-view-mode' on document buffer in "emacs -nw", Emacs > proposes to convert this document to the text version and if the user > says "yes" it calls `doc-view-open-text'. > > `doc-view-open-text' tries to get the current page by calling the > `doc-view-current-page' but this latter relies on > `image-mode-window-get' which most probably return nil on a tty. I can't reproduce this bug on 29.4, could you provide a more complete recipe starting from emacs -Q? > > In GNU Emacs 31.0.50 (build 1, x86_64-unknown-openbsd7.5, cairo version > 1.18.0) of 2024-07-26 built on computer > Repository revision: 52cae67e1e73615fff184abcc8e635d80f8846ad > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 > System Description: OpenBSD computer 7.5 GENERIC.MP#207 amd64 > > Configured using: > 'configure CC=egcc CPPFLAGS=-I/usr/local/include > LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs > --bindir=/home/manuel/bin --with-x-toolkit=no --with-cairo > --without-compress-install' > > [2. text/patch; 0001-Fix-DocView-s-text-conversion-on-tty-Emacs.patch]...