From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Xiyue Deng Newsgroups: gmane.emacs.bugs Subject: bug#72992: 29.4; towards xoauth2 support in Emacs Date: Sun, 22 Sep 2024 23:39:59 -0700 Message-ID: <87cyku50w0.fsf@debian-hx90.lan> References: <87h6ayfo87.fsf_-_@debian-hx90.lan> <87r09i14cm.fsf@posteo.net> <87msk5pji2.fsf@debian-hx90.lan> <87o74ldpby.fsf@posteo.net> <87sets416y.fsf@debian-hx90.lan> <87tte89gmn.fsf@posteo.net> <87ikun4ade.fsf@debian-hx90.lan> <87tte67v1v.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Emacs/29.4 (x86_64-pc-linux-gnu) Cc: 72992@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 23 08:41:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssclg-0008GR-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Sep 2024 08:41:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssclS-0003wv-UT; Mon, 23 Sep 2024 02:41:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssclP-0003wi-Sv for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 02:41:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ssclP-0007O9-Bf for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 02:41:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Swqk7YvG3m5qqAuH2faG+v8+zJwRkekLq4mNCD4wdUw=; b=gq9zUl9vaNhEYXvG2Iz7cXX7lmH+GFYQNpe7NtRI9EgIGqFteo4zKYol0KeqyZBGroRrMqEh+hE602ze1H92k5XX65WCWHyVutqjd3w5ppmm2nJTb6JMtk5BxenD7eqTGsymRy8gX13VMFmUXiHJ2K3ZqDgBSU3bHf5FZQ/N5zg1Y2H/bzgHURKv7pSEIUiupfXeQjv06ndv8G1l0GjKYXA5LVpikNRSDPRQt3IlYxwZ7HQczt6yP73bsxeUkT/iJ6L97BDogpmvv2MJ9dz0vPfsmGCJVRAKV1pBf7u41xsiMIVeZqDZpTRnaYzhzdwwwZYMZyqdbUqCc9K3V4aw+A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sscll-0000KG-TR for bug-gnu-emacs@gnu.org; Mon, 23 Sep 2024 02:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Xiyue Deng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Sep 2024 06:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72992 X-GNU-PR-Package: emacs Original-Received: via spool by 72992-submit@debbugs.gnu.org id=B72992.17270736951197 (code B ref 72992); Mon, 23 Sep 2024 06:42:01 +0000 Original-Received: (at 72992) by debbugs.gnu.org; 23 Sep 2024 06:41:35 +0000 Original-Received: from localhost ([127.0.0.1]:43096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssclK-0000J9-Va for submit@debbugs.gnu.org; Mon, 23 Sep 2024 02:41:35 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:53731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ssclI-0000Iq-CZ for 72992@debbugs.gnu.org; Mon, 23 Sep 2024 02:41:33 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7db174f9050so706058a12.3 for <72992@debbugs.gnu.org>; Sun, 22 Sep 2024 23:41:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727073603; x=1727678403; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Swqk7YvG3m5qqAuH2faG+v8+zJwRkekLq4mNCD4wdUw=; b=Om/GKDNCZd2ybIgDOOhFSmdU/YenqFg4Telp9+CVy6bU63BfEvpKgfnhccWFfYqaDL pn9BqJJYQ0OwxGKLcG73S5rTErt01XkeQ0NQAbtsGbLnQ7B+eiJjfHG3Ey97kAZ+aCFj CR8SsmjCSljVxz+qhyHzqcQR7QgUKb6h0A0jOUfqOcmacMv2zZcYghTXWuHnlN5g4Fxr JTBFCS5MJqKHSmzlLT1szLFQT7VSFlCcHJMVa27FTDndte+Jm0uOCag9G9/oa6wRUbxa hNWq4Hrssft+XB4DisCg9a7Agrc9ZreoNsL8yYdwLnxs3RHd99hTUrIP/qEG27VpXMDo C9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727073603; x=1727678403; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Swqk7YvG3m5qqAuH2faG+v8+zJwRkekLq4mNCD4wdUw=; b=lPDLeXRw4iNwpdQ0OGkDMdbRpXvRz+Xcwd4amuCjQHXW9jod3OBo1Zq0VIZDddmVvs VBO9371+4vvouY6rsKUJUuJY4Tp11pxEa6+45XxNe2U0TdeA2+gS+A7Qijbt9kWVeJLK jeT92wql44YkGzPsonS9t1V2GIUvZEsLT5fkaxMXsFUhbXoIol1oqRSVPXTKjXSJVAFT Wza74KYBEcjeL8OObgj0+M8todUiaTMVSre5LsGGCVOCbJdoqJQdAif3HKVLEyhindER MHtPixsxduitfd2KsHjxMT4e35jUknWHi4TPQQALZPt3bxf/widim/qk+lQBh9Z59pBw mK2g== X-Gm-Message-State: AOJu0Yzf2gKSl31Nj0AavXctitfMiCiq6+6ZSGGbgwg8eVMz0onq/N0u 468Vcc+zMPH1L/8kHxR1602W9RR+SOUn1d8NCwfghJZvRXSzIH4lg320sw== X-Google-Smtp-Source: AGHT+IGPSNUiksMpVlGRPw/zaqDZc9EGp+Pdl828nO8bfBIDKlFMbOhYb2z4oSKwYQ0CLOHKZDWKIQ== X-Received: by 2002:a17:90b:3b8f:b0:2d8:8430:8a91 with SMTP id 98e67ed59e1d1-2dd7f3cc3f4mr14419421a91.10.1727073603464; Sun, 22 Sep 2024 23:40:03 -0700 (PDT) Original-Received: from debian-hx90 (syn-076-094-249-045.res.spectrum.com. [76.94.249.45]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dd52e2eb85sm12197813a91.1.2024.09.22.23.40.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Sep 2024 23:40:02 -0700 (PDT) In-Reply-To: <87tte67v1v.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292263 Archived-At: Philip Kaludercic writes: > Xiyue Deng writes: > > > [...] > >>> diff --git a/auth-source-xoauth2-plugin.el b/auth-source-xoauth2-plugin.el >>> index cdcc9e7..caf5baf 100644 >>> --- a/auth-source-xoauth2-plugin.el >>> +++ b/auth-source-xoauth2-plugin.el >>> @@ -41,7 +41,7 @@ >>> ;; or with use-package: >>> >>> ;; (use-package auth-source-xoauth2-plugin >>> -;; :config >>> +;; :custom >>> ;; (auth-source-xoauth2-plugin-mode t)) >>> >> >> Quick question: I wonder whether customizing the minor mode variable is >> preferred over toggling through the minor mode function? (I assume both >> will run the minor mode body.) > > You are right, it doesn't matter. I changed this when adding the > autoload cookie, and somehow I had convinced myself that this would only > work as a user option, which of course is not the case. Thanks for confirming! I have incorporated your suggestions and pushed to my repo. Thanks again for your review! > > [...] > > > -- > Philip Kaludercic on siskin -- Xiyue Deng