From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74090: 31.0.50; Problems with dabbrev-expand Date: Thu, 31 Oct 2024 11:00:17 +0100 Message-ID: <87cyjgwq1a.fsf@gmx.net> References: <878qu6j0tx.fsf@gmx.net> <86zfml4uay.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9371"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74090@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 31 11:01:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6RzX-0002DO-2K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Oct 2024 11:01:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6RzF-0006ix-Hq; Thu, 31 Oct 2024 06:01:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6RzE-0006ip-0m for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 06:01:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6RzD-00038h-Gq for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 06:01:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3NsZi119ooz1f6KQyugkpr+Eu56TG4QtN17RRlw4jDI=; b=RjGeEKfWP/YhoZ20krv5304PbphtvPLEDWo1zixh6bRbxd4md+h14fR4c/633CAZerb8yhaod+KEQccODe1J6wf4QGn9o3s3k2dpfo2xEmSAK+vALVVRteGSOG5JAq/RAYm3JXNomROvQ/HxtEOvvp35J2BSx/dWk2IJ/00hzFbAqOvjqSI7qE1hEuyyLzuR/00W/bl59vBfjvnTS44i6xkIpOqiJBLV89/amUJU+pnL0tJkx17n8qBKox1FR3Bm9eepyjqAY/64RpED7jfMJa+kdjgzED0ZOnoyTQlHMfsJbnav8VN3iexZ1uqlkxR+iZkoWczU4Su/uJubs4YoDg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6RzC-0001lB-A6 for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 06:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2024 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74090 X-GNU-PR-Package: emacs Original-Received: via spool by 74090-submit@debbugs.gnu.org id=B74090.17303688326720 (code B ref 74090); Thu, 31 Oct 2024 10:01:02 +0000 Original-Received: (at 74090) by debbugs.gnu.org; 31 Oct 2024 10:00:32 +0000 Original-Received: from localhost ([127.0.0.1]:41310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6Ryh-0001kK-Ap for submit@debbugs.gnu.org; Thu, 31 Oct 2024 06:00:32 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:39529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6Ryb-0001kC-3C for 74090@debbugs.gnu.org; Thu, 31 Oct 2024 06:00:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1730368819; x=1730973619; i=stephen.berman@gmx.net; bh=3NsZi119ooz1f6KQyugkpr+Eu56TG4QtN17RRlw4jDI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=HSItAMtG2Q2UCV93AzrMGt6WimC7z3zacJaOBoBVrkwnpNPlkNI2x1ooCj2OiXHh fTk++RwANbgQ5fAcYFpH+X/BRHT+bFeBJ+Gaetw9l9eqlS6+EnWhs2DfQwPx3B+Ba 8HTlRMdVdAMD7uZ1tTN2xq62DPa1TX6t99RUEg5S23cb3F9x6Q6qBovZYkLwAPnCr 5QeA97E22s8MlmvCSPAyICSQ7VgonIAMOFrG7+CtVMpNRv1+JxP5WaA9oXEIoFgZ/ BTFX6Gz4T8lSR5uvqpx4E7onh4zHmmnxKhoI48lmFo/L6m4aDEiuy3WsG6ZGwl3cA 2RTpOM6vtf+PLjfiGQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([94.134.95.122]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M9nxn-1tBeVC00nt-002jUv; Thu, 31 Oct 2024 11:00:19 +0100 In-Reply-To: <86zfml4uay.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Oct 2024 15:03:17 +0200") X-Provags-ID: V03:K1:pKh5CPZGTj0JnWmFIzF7TsuEbQS7GN32DWGB2S51gEGYI/nMCWT fGBgTk67ExBkPgE5e6i+waOjtAojRSUBLD24J1pxDbWzTWCt5DzPKGb88Ynqq8wFwpp85d7 39KUMiOT3Pnh99/KRmyrxb7B5KQMUr0BO+Of1/XoYEPebYQQxFSfhPLIGkZ3Zs1eT+jf6ax bWMT87WSIJVdppy7whX6Q== UI-OutboundReport: notjunk:1;M01:P0:/Vx9Z/35hqI=;mPOqsKmpCvoxRjliHLdgntN+MGw ltBiCwaby1CEzNSrJNUVRRB6Z1P7rtNvtisFfkpquaaUziFPNidP/aAhF7WGDwieDTDo4BQ0V 7pNxjXuwyRxowHhz47CS7jVaNx69FRKVzHJDCc8b4nQcjb6pCQ8o3SZNVBDXoO/Ow4Wo1YY/c dziqnUsi2t2FW2PQSZGoUTPA9ox+DrJ/CT+7iH8vrUSne6Lto9PSe+wB8Mo3Yv92bFFa3b6yT mRUnxLd7zrD8Eq1d50XGvbTT/bMVSnvDV99+tHjIsr+RnJ8Z2MGg2bF4oTU0qJ7rf74OF4Rwp 0JyhHahrhP+jDTIb25tLbO204zM3i58QRMU5w9/kxVre4tUuzBV2mMii20cHgq501U4dzOOkY WKEWH2I00gBjzCi0+oGGrqPkeTDWTZH0sbibW0LIamrQVLIf/3SE01arOkgUaMIedODRim2ZC WP+9D9tx/d8r8LW8q4SiMdxhShfh1FnVqICVK9Yu3abho1Ool9MYFn+apdsLzYm9DXZk9THT5 kO/MF3IvBf2K7x0PQ2NYRrH7XoZYGclKAUAVHc8YXQCwGXyA46ByEFmsttwNLguBK+pOURg5e Fp5v3uvVQaXroJRoReexdFcQQMgG2ZsbBqo5/TuGBUJt/X5iZNs4/qs5/nrmmH8b8F1dCMqNf KtdC+K+BXnAGTXqRkT48ZMT5DCIqszn/X8vdYmIu6bt63uyn1VPd05v/Idh7hbnU9mZjYjFDU pcCoXJvBEfWa+zEpyCpWboyJctu/871whmFODlVTl4co+XcPNefAIVqQAeSqX73IuXvYgOR4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294601 Archived-At: On Wed, 30 Oct 2024 15:03:17 +0200 Eli Zaretskii wrote: >> Date: Tue, 29 Oct 2024 18:06:18 +0100 >> From: Stephen Berman via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> >From my debugging of these problems, I think they arise because the co= de >> in dabbrev-expand that sets up looking for an expansion (either >> directly, or after a space, or as a replacement for the current >> expansion) wrongly using positions in the buffer from which >> dabbrev-expand was invoked instead of the buffer in which the expansion >> is found. The attached patch fixes these problems, according to my >> tests. The patch includes comments justifying or at least motivating >> the changes. > > Thanks, feel free to install on the emacs-30 branch. > >> + ;; Comparing with point only makes sense in the buffe= r >> + ;; where we called dabbrev-exand, but if that differs > ^^^^^^^^^^^^^ > Typo. Thanks, typo corrected and pushed as commit f6c359cb66a -- but to master, I just now noticed that you said emacs-30. I tried reverting but I don't know how. What should I do? Sorry for the snafu. Steve Berman