bug#74193: 30.0.92; noquery argument ignored when creating a TLS connection

[Augusto Stoffel <arstoffel@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Sun,  3 Nov 2024 at 19:44, Eli Zaretskii wrote:

>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Sun, 03 Nov 2024 17:27:00 +0100
>> 
>> If I evaluate the form below and then run C-x C-c, I get asked if I want
>> to kill the network process.
>> 
>>   (open-network-stream "test" nil "www.gnu.org" 443 :type 'tls :noquery t)
>> 
>> If I removed the `:type 'tls' option, then :noquery takes effect as
>> expected.
>
> AFAICT, open-gnutls-stream doesn't support :noquery, so Emacs
> basically ignores :noquery in this case and starts a network process
> with query-on-exit flag set.

Indeed, the fix is trivial:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-net-gnutls.el-open-gnutls-stream-Use-noquery-op.patch --]
[-- Type: text/x-patch, Size: 785 bytes --]

From 01d73dea9243d2b57b6ed2bd0fa37e0935ef7a74 Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Sun, 3 Nov 2024 19:11:54 +0100
Subject: [PATCH] * lisp/net/gnutls.el (open-gnutls-stream): Use :noquery
 option

---
 lisp/net/gnutls.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/net/gnutls.el b/lisp/net/gnutls.el
index b5fb4d47d57..e8614bfc6d3 100644
--- a/lisp/net/gnutls.el
+++ b/lisp/net/gnutls.el
@@ -200,6 +200,7 @@ open-gnutls-stream
          (process (open-network-stream
                    name buffer host service
                    :nowait nowait
+                   :noquery (plist-get parameters :noquery)
                    :tls-parameters
                    (and nowait
                         (cons 'gnutls-x509pki
-- 
2.47.0