From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74775: [PATCH] Update browse-url-kde variables Date: Wed, 11 Dec 2024 16:03:30 +0200 Message-ID: <87cyhyuxjh.fsf@thaodan.de> References: <86jzc64cod.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15057"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74775@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 15:04:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLNKB-0003gz-Nj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 15:04:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLNK4-0005n6-Er; Wed, 11 Dec 2024 09:04:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLNJu-0005kf-T4 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 09:04:07 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLNJr-0005Mi-93 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 09:04:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=B8CAi1s4BW/VurnDSv+dxt608p3VI52iZoZXDynFgiE=; b=sLSQwxtu3v9bF5+RvhimDOPrEBghQ6v3lgggNNHkDVcpxIipKkflgPgCCU3qrsZie2rrA1ULZidNi8BPo9TgG3iaTULoK4xeDJ9qs41sdIcU8hSid2ciJGaM9F5exOrWdzcmBrLKd9pIR1UjVX927eZ7J3nKgEmOgBC1zAxVEqSoqFQWdCaSSLzBqpzCV4TIFFkRSNSZKfau3BOyAaP0k/rKxFnm2GsY/Jji2aMXhtJOvtaSqBJdOB1afgkGzaDYLy1EZEDL2rPEOrit8XDY1VT+t40KKUyjs6jCRjAYtF86UUy1jbGaVgKR3sSHcYs0M2bU7cb2PEuqpQQ5830XSQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLNJr-0001dw-1W for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 09:04:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74775 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74775-submit@debbugs.gnu.org id=B74775.17339258256281 (code B ref 74775); Wed, 11 Dec 2024 14:04:02 +0000 Original-Received: (at 74775) by debbugs.gnu.org; 11 Dec 2024 14:03:45 +0000 Original-Received: from localhost ([127.0.0.1]:33604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLNJU-0001d7-WD for submit@debbugs.gnu.org; Wed, 11 Dec 2024 09:03:44 -0500 Original-Received: from thaodan.de ([185.216.177.71]:53834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLNJS-0001cs-61 for 74775@debbugs.gnu.org; Wed, 11 Dec 2024 09:03:38 -0500 Original-Received: from NordStern (unknown [185.252.118.71]) by thaodan.de (Postfix) with ESMTPSA id 3F997D00055; Wed, 11 Dec 2024 16:03:32 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1733925812; bh=9IljZkd/2k/HPpApycxvvXJUVE9bTBiKEjgFoh7bdjY=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ZE2VPteiyB+B81RS9QhI6bDO22P0sHPbp+DioxcpsE6FgEoj7ZPBM9p0Dr3wvO94K jFk2U6jV5Y/w8+FA10BfWyRvB2iABffkrnuUS/iFZ1h/hqE0EJeYHxOhDolO848y5k 6dBAicXABoZq4ie5aHth9503Nx8f8Knhxr+RyUFJKDvFrYxh8SsOjIn8T9oYIEY67D MFFmPNqUc7sZN7gl5BONUQgJ2Ogiqe5igi4sbjisVIU1x4n6K2Uie3j9gZVrtg85Ou YFW4+HN4flLOaivGCT8zV1iouunmjONFxlDMaftq7r9vXop5m7EmgWlPzzeai6brma ZGcqho1RAaFT30PVNvaHcp7jDV/Cd+o/p0lhrBe1swChqi5XwJFSXgvbuHI7Y+QBPL Gml/260BT98zCi82fttuUP/iPlHBeWj0BtaUqb5hf6iQN3yhTZ0vSVuD52lDJncQ4V YxjRC2DzQdFrkFp3bn6YfhRbLJOXMTEccMyJh/COnf5H6qvOwI9ZUYDHcHXYg0B0JH hN8Mjl6dO6TCSoF57mhWrnfocHBD885+M/6Mhxa6tR42Is7B8o+tXNzQiqocP9VAQd tVdIc4kGy1njL4UNwsXmWKMWX3CMnPb4s25K+5QcUE0Eb90pVORBOi18Yb/6SATszd JDfmd/5fNkKCoBBFof8IkUb4= In-Reply-To: <86jzc64cod.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Dec 2024 14:38:42 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296826 Archived-At: Eli Zaretskii writes: >> Date: Wed, 11 Dec 2024 01:04:56 +0200 >> From: Bj=C3=B6rn Bidar via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Update browse-url-kde's variables. > > Thanks, but when we change the default value of a user option, we need > to update its :version tag (so that commands like customize-changed > could notice that). Will do good call. >> -(defcustom browse-url-kde-program "kfmclient" >> +(defcustom browse-url-kde-program "kde-open" >> "The name by which to invoke the KDE web browser." > > Should we offer the other name as a (non-default) alternative? It is > still available, right? The other one is still available but kde-open is then installed at the same time too. Both to the same thing it doesn't make sense to still offer kfmclient here. >> :type 'string > > Should this be 'file instead? Does 'file for programs in path? >> -(defcustom browse-url-kde-args '("openURL") >> +(defcustom browse-url-kde-args nil >> "A list of strings defining options for `browse-url-kde-program'." > > Should the default value depend on the value of > browse-url-kde-program? E.g., if that is customized to kfmclient, the > value of this variable should probably not be '("openURL"), right? For kfmclient it should be '("openURL") for others not. I think it would make sense to apply this change to Emacs 30 too as it isn't a functionality change but a fix to not use kfmclient which is not installed anymore these days as the default file manager for KDE is Dolphin and not Konqueror which includes kfmclient.