From: Kevin Ryde <user42@zip.com.au>
To: bug-gnu-emacs@gnu.org
Subject: bug#5026: 23.1; add-hook buffer local vs single func
Date: Tue, 24 Nov 2009 08:04:41 +1100 [thread overview]
Message-ID: <87bpitlzpy.fsf@blah.blah> (raw)
Evaluating
(progn
(defvar foo nil)
(defun func1 ()
(error "this is func 1"))
(defun func2 ()
(message "this if func 2"))
(setq foo 'func1)
(add-hook 'foo 'func2
nil ;; prepend
t) ;; buffer-local
(run-hooks 'foo))
returns nil, where I expected the run-hooks to run both func2 and func1,
raising the error in func1.
The elisp manual under "Setting Hooks" says
`add-hook' can handle the cases where ... its value is
a single function;
but that doesn't seem to be so when extending a single function to a
buffer-local value.
I suspect it's run-hooks which should be blamed rather than add-hook.
Should run-hooks allow a single-function global value when it follows a
`t' from a local value?
I expect this arises only rarely. But if it does then it's a pretty
subtle way to miss out on a function you thought you had in a hook.
In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
of 2009-09-14 on raven, modified by Debian
configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_AU
value of $XMODIFIERS: nil
locale-coding-system: iso-latin-1-unix
default-enable-multibyte-characters: t
next reply other threads:[~2009-11-23 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ljghg2z5.fsf@stupidchicken.com>
2009-11-23 21:04 ` Kevin Ryde [this message]
2009-11-24 1:43 ` bug#5026: 23.1; add-hook buffer local vs single func Stefan Monnier
2009-11-27 0:34 ` Kevin Ryde
2009-11-27 4:16 ` Stefan Monnier
2009-11-28 3:10 ` Richard Stallman
2009-12-29 23:54 ` Kevin Ryde
2009-12-27 22:48 ` Kevin Ryde
2009-12-29 15:50 ` Stefan Monnier
2010-01-01 17:17 ` bug#5026: marked as done (23.1; add-hook buffer local vs single func) Emacs bug Tracking System
2010-01-02 21:17 ` bug#5026: 23.1; add-hook buffer local vs single func Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bpitlzpy.fsf@blah.blah \
--to=user42@zip.com.au \
--cc=5026@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).