unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face))
@ 2010-06-19  6:51 Dan Nicolaescu
  2010-11-22  0:29 ` Chong Yidong
  0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2010-06-19  6:51 UTC (permalink / raw)
  To: 6465


When using C-x v v to check something in, there's a lot of messages
like this in the *Messages* buffer:

Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face)) [3 times]

Probably the cause is this change to `log-edit-font-lock-keywords':

2010-04-21  Stefan Monnier  <monnier@iro.umontreal.ca>

            Make the log-edit comments use RFC822 format throughout.

            * vc.el (vc-checkin, vc-modify-change-comment):
            Adjust to new vc-start/finish-logentry.
            (vc-find-conflicted-file): New command.
            (vc-transfer-file): Adjust to new vc-checkin.
            (vc-next-action): Improve scoping.

            * vc-hg.el (vc-hg-log-edit-mode): Remove.
            (vc-hg-checkin): Remove extra arg.  Use log-edit-extract-headers.

            * vc-git.el (vc-git-log-edit-mode): Remove.
            (vc-git-checkin): Remove extra arg.  Use log-edit-extract-headers.
            (vc-git-commits-coding-system): Rename from git-commits-coding-system.

            * vc-dispatcher.el (vc-log-edit): Shorten names for log-edit-show-files.
            (vc-start-logentry): Remove argument `extra'.
            (vc-finish-logentry): Remove extra args.

            * vc-bzr.el (vc-bzr-log-edit-mode): Remove.
            (vc-bzr-checkin): Remove extra arg.  Use log-edit-extract-headers.
            (vc-bzr-conflicted-files): New function.

            * log-edit.el (log-edit-extra-flags)
            (log-edit-before-checkin-process): Remove.
            (log-edit-summary, log-edit-header, log-edit-unknown-header): New faces.
            (log-edit-headers-alist): New var.
            (log-edit-header-contents-regexp): New const.
            (log-edit-match-to-eoh): New function.
            (log-edit-font-lock-keywords): Use them.
            (log-edit): Insert a "Summary:" header as default.
            (log-edit-mode): Mark font-lock rules as case-insensitive.
            (log-edit-done): Cleanup headers.
            (log-view-process-buffer): Remove.
            (log-edit-extract-headers): New function to replace it.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face))
  2010-06-19  6:51 bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face)) Dan Nicolaescu
@ 2010-11-22  0:29 ` Chong Yidong
  2010-11-22  6:38   ` Dan Nicolaescu
  0 siblings, 1 reply; 6+ messages in thread
From: Chong Yidong @ 2010-11-22  0:29 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: 6465

> When using C-x v v to check something in, there's a lot of messages
> like this in the *Messages* buffer:
>
> Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face)) [3 times]
>
> Probably the cause is this change to `log-edit-font-lock-keywords':
>
> 2010-04-21  Stefan Monnier  <monnier <at> iro.umontreal.ca>
>
>             Make the log-edit comments use RFC822 format throughout.

Is this still happening to you?





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face))
  2010-11-22  0:29 ` Chong Yidong
@ 2010-11-22  6:38   ` Dan Nicolaescu
  2010-11-27 19:46     ` Chong Yidong
  0 siblings, 1 reply; 6+ messages in thread
From: Dan Nicolaescu @ 2010-11-22  6:38 UTC (permalink / raw)
  To: Chong Yidong; +Cc: 6465

Chong Yidong <cyd@stupidchicken.com> writes:

>> When using C-x v v to check something in, there's a lot of messages
>> like this in the *Messages* buffer:
>>
>> Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face)) [3 times]
>>
>> Probably the cause is this change to `log-edit-font-lock-keywords':
>>
>> 2010-04-21  Stefan Monnier  <monnier <at> iro.umontreal.ca>
>>
>>             Make the log-edit comments use RFC822 format throughout.
>
> Is this still happening to you?

I can see it on the emacs-23 branch.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face))
  2010-11-22  6:38   ` Dan Nicolaescu
@ 2010-11-27 19:46     ` Chong Yidong
  2010-11-28 17:25       ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Chong Yidong @ 2010-11-27 19:46 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: 6465

Dan Nicolaescu <dann@gnu.org> writes:

>>> When using C-x v v to check something in, there's a lot of messages
>>> like this in the *Messages* buffer:
>>>
>>> Error during redisplay: (error No match 4 in highlight (4
>>> font-lock-warning-face)) [3 times]
>>>
>>> Probably the cause is this change to `log-edit-font-lock-keywords':
>>>
>>> 2010-04-21  Stefan Monnier  <monnier <at> iro.umontreal.ca>
>>>
>>>             Make the log-edit comments use RFC822 format throughout.
>>
>> Is this still happening to you?
>
> I can see it on the emacs-23 branch.

The final "\\|\\(.*\\)" in log-edit-font-lock-keywords looks bogus (it
was also the reason for the loop in Bug#6343).  Since Stefan hasn't
commented on this issue yet, I went ahead and removed that part of the
regexp.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face))
  2010-11-27 19:46     ` Chong Yidong
@ 2010-11-28 17:25       ` Stefan Monnier
  2010-12-04 21:53         ` Chong Yidong
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2010-11-28 17:25 UTC (permalink / raw)
  To: Chong Yidong; +Cc: Dan Nicolaescu, 6465

>>>>> "Chong" == Chong Yidong <cyd@stupidchicken.com> writes:

> Dan Nicolaescu <dann@gnu.org> writes:
>>>> When using C-x v v to check something in, there's a lot of messages
>>>> like this in the *Messages* buffer:
>>>> 
>>>> Error during redisplay: (error No match 4 in highlight (4
>>>> font-lock-warning-face)) [3 times]
>>>> 
>>>> Probably the cause is this change to `log-edit-font-lock-keywords':
>>>> 
>>>> 2010-04-21  Stefan Monnier  <monnier <at> iro.umontreal.ca>
>>>> 
>>>> Make the log-edit comments use RFC822 format throughout.
>>> 
>>> Is this still happening to you?
>> 
>> I can see it on the emacs-23 branch.

Thos things are trivial to solve: add a `lax' argument to the `4'
font-lock rule.

> The final "\\|\\(.*\\)" in log-edit-font-lock-keywords looks bogus (it
> was also the reason for the loop in Bug#6343).  Since Stefan hasn't
> commented on this issue yet, I went ahead and removed that part of the
> regexp.

That's OK as well, it was not an important case,


        Stefan





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face))
  2010-11-28 17:25       ` Stefan Monnier
@ 2010-12-04 21:53         ` Chong Yidong
  0 siblings, 0 replies; 6+ messages in thread
From: Chong Yidong @ 2010-12-04 21:53 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Dan Nicolaescu, 6465

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>>> I can see it on the emacs-23 branch.
>
> Thos things are trivial to solve: add a `lax' argument to the `4'
> font-lock rule.

Adding a `lax' argument led to an infloop (Bug#6343), because of the way
log-edit-match-to-eoh works.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-12-04 21:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-19  6:51 bug#6465: Error during redisplay: (error No match 4 in highlight (4 font-lock-warning-face)) Dan Nicolaescu
2010-11-22  0:29 ` Chong Yidong
2010-11-22  6:38   ` Dan Nicolaescu
2010-11-27 19:46     ` Chong Yidong
2010-11-28 17:25       ` Stefan Monnier
2010-12-04 21:53         ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).