bug#8258: INFOPATH bug on Windows

bug#8258: INFOPATH bug on Windows

[Ralph Schleicher]

Hi,

on Windows, Emacs 23.3 fails to parse INFOPATH due to a hard-coded
colon as path separator.  Below is a patch together with a change
log entry.


2011-03-11  Ralph Schleicher  <rs@ralph-schleicher.de>

	* info.el (info-initialize): Replace all uses of `:' with
	path-separator for compatibility with non-Unix systems.
	Cache quoting of path-separator.


--- emacs-23.3/lisp/info.el.orig	2011-01-08 12:45:14 +0100
+++ emacs-23.3/lisp/info.el	2011-03-11 11:45:14 +0100
@@ -588,15 +588,15 @@
 (defun info-initialize ()
   "Initialize `Info-directory-list', if that hasn't been done yet."
   (unless Info-directory-list
-    (let ((path (getenv "INFOPATH")))
+    (let ((path (getenv "INFOPATH"))
+	  (sep (regexp-quote path-separator)))
       (setq Info-directory-list
 	    (prune-directory-list
 	     (if path
-		 (if (string-match ":\\'" path)
-		     (append (split-string (substring path 0 -1)
-					   (regexp-quote path-separator))
+		 (if (string-match (concat sep "\\'") path)
+		     (append (split-string (substring path 0 -1) sep)
 			     (Info-default-dirs))
-		   (split-string path (regexp-quote path-separator)))
+		   (split-string path sep))
 	       (Info-default-dirs)))))))
 
 ;;;###autoload


-- 
Ralph

bug#8258: INFOPATH bug on Windows

[Juanma Barranquero]

> on Windows, Emacs 23.3 fails to parse INFOPATH due to a hard-coded
> colon as path separator.

In fact, the current code parses INFOPATH (quite by accident), but
fails to take into account the case where INFOPATH should be appended
to Info-default-directory-list.

So, yours is a valid fix and I've committed it to the emacs-23 branch.

Thanks,

    Juanma

bug#8258: INFOPATH bug on Windows

[Glenn Morris]

Hi,

I noticed that we do not have a copyright assignment from you that would
cover these changes (we only have ones specifically for libc.el and
battery.el). The current change is small enough not to need an
assignment, but I notice you have sent a few other patches recently (not
yet applied), plus you seem to have some old changes installed for
info-look.el.

The simplest solution is if you just complete one more, general
assignment for all of Emacs. Are you willing to do that?
If so, let me know and I will send you the form to get started.

Thanks.