From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#9361: 24.0.50; default value of `dired-do-chmod' Date: Sun, 11 Sep 2011 17:41:24 -0400 Message-ID: <87bouqlptn.fsf@stupidchicken.com> References: <03BC028E352D4173B985B3B34DF3193A@us.oracle.com> <87zkiyabea.fsf@mail.jurta.org> <1BDADB23B4434E0C9330F1B010F1E1CE@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315777315 17781 80.91.229.12 (11 Sep 2011 21:41:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 11 Sep 2011 21:41:55 +0000 (UTC) Cc: 'Lars Magne Ingebrigtsen' , 9361@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 11 23:41:50 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rmf-0005Q3-DJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2011 23:41:49 +0200 Original-Received: from localhost ([::1]:49794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2rmf-0003F7-14 for geb-bug-gnu-emacs@m.gmane.org; Sun, 11 Sep 2011 17:41:49 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:47655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2rmc-0003DM-Ow for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:41:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R2rmb-0003XQ-Tv for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:41:46 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R2rmb-0003XL-SO for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2011 17:41:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R2rqk-0005hq-Tp; Sun, 11 Sep 2011 17:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2011 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 9361-submit@debbugs.gnu.org id=B9361.131577754721257 (code B ref 9361); Sun, 11 Sep 2011 21:46:02 +0000 Original-Received: (at 9361) by debbugs.gnu.org; 11 Sep 2011 21:45:47 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rqU-0005WB-Ps for submit@debbugs.gnu.org; Sun, 11 Sep 2011 17:45:47 -0400 Original-Received: from vm-emlprdomr-02.its.yale.edu ([130.132.50.143]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R2rqS-0005Tt-Cl for 9361@debbugs.gnu.org; Sun, 11 Sep 2011 17:45:45 -0400 Original-Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-02.its.yale.edu (8.14.4/8.14.4) with ESMTP id p8BLfOxG005571 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 11 Sep 2011 17:41:25 -0400 In-Reply-To: <1BDADB23B4434E0C9330F1B010F1E1CE@us.oracle.com> (Drew Adams's message of "Sun, 11 Sep 2011 08:00:58 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.143 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 11 Sep 2011 17:46:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51005 Archived-At: I think there's a problem here, indeed. It's a bad idea to take an empty input to mean a certain default permission---especially when that default permission is not displayed in the prompt. The following patch makes dired-do-chmod demand a non-empty input. The precomputed permission is still available in the M-n `future history'. *** lisp/dired-aux.el 2011-08-04 00:58:07 +0000 --- lisp/dired-aux.el 2011-09-11 21:38:35 +0000 *************** *** 267,272 **** --- 267,280 ---- (format "%s: error" operation) nil)))) + (defun dired--read-permission-string (prompt default) + (let ((result "")) + (while (equal result "") + (setq result + (read-from-minibuffer prompt nil nil + nil nil default))) + result)) + ;;;###autoload (defun dired-do-chmod (&optional arg) "Change the mode of the marked (or next ARG) files. *************** *** 284,292 **** (match-string 1 modestr) (match-string 2 modestr) (match-string 3 modestr))))) ! (modes (dired-mark-read-string ! "Change mode of %s to: " nil ! 'chmod arg files default)) (num-modes (if (string-match "^[0-7]+" modes) (string-to-number modes 8)))) (dolist (file files) --- 292,303 ---- (match-string 1 modestr) (match-string 2 modestr) (match-string 3 modestr))))) ! (modes ! (dired-mark-pop-up nil 'chmod files ! 'dired--read-permission-string ! (format "Change mode of %s to: " ! (dired-mark-prompt arg files)) ! default)) (num-modes (if (string-match "^[0-7]+" modes) (string-to-number modes 8)))) (dolist (file files)