From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Mon, 27 Feb 2012 09:04:24 +0100 Message-ID: <87bookhfcn.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <87d395y1w0.fsf@gmail.com> <87zkc8x04p.fsf@gmail.com> <87vcmwwvk7.fsf@gmail.com> <834nugtwqf.fsf@gnu.org> <87r4xkwhky.fsf@gmail.com> <83vcmws3bs.fsf@gnu.org> <87ehtkwaiz.fsf@gmail.com> <87wr7cgsm3.fsf@gmx.de> <8762eww77b.fsf@gmail.com> <83pqd4roav.fsf@gnu.org> <87haygx97t.fsf@gmx.de> <87aa47rj6z.fsf@gmail.com> <878vjrxpej.fsf@gmx.de> <87pqd3i8ky.fsf@gmail.com> <87ipiuvsbw.fsf@gmx.de> <87k439gyu5.fsf@gmail.com> <87fwdwhizm.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330329922 26100 80.91.229.3 (27 Feb 2012 08:05:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Feb 2012 08:05:22 +0000 (UTC) Cc: 10489@debbugs.gnu.org, Michael Albinus To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 27 09:05:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S1vaB-0002Ua-D1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2012 09:05:19 +0100 Original-Received: from localhost ([::1]:38284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1vaA-0002EA-LU for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2012 03:05:18 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1va5-0002Ds-Rm for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 03:05:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1va4-00071w-Ei for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 03:05:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1va4-00071s-9f for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 03:05:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S1vcn-0003Mv-OS for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 03:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Feb 2012 08:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.133033004112904 (code B ref 10489); Mon, 27 Feb 2012 08:08:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 27 Feb 2012 08:07:21 +0000 Original-Received: from localhost ([127.0.0.1]:58833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1vc8-0003M4-Q0 for submit@debbugs.gnu.org; Mon, 27 Feb 2012 03:07:21 -0500 Original-Received: from mail-ww0-f46.google.com ([74.125.82.46]:54961) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1vc6-0003Lx-JZ for 10489@debbugs.gnu.org; Mon, 27 Feb 2012 03:07:20 -0500 Original-Received: by wgbdq11 with SMTP id dq11so561267wgb.15 for <10489@debbugs.gnu.org>; Mon, 27 Feb 2012 00:04:28 -0800 (PST) Received-SPF: pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.83.97 as permitted sender) client-ip=10.180.83.97; Authentication-Results: mr.google.com; spf=pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.83.97 as permitted sender) smtp.mail=thierry.volpiatto@gmail.com; dkim=pass header.i=thierry.volpiatto@gmail.com Original-Received: from mr.google.com ([10.180.83.97]) by 10.180.83.97 with SMTP id p1mr25188367wiy.19.1330329868206 (num_hops = 1); Mon, 27 Feb 2012 00:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=g0AGFuqFda04tBgLuiAP7k2365ouxkCkJ8b6J3zv5hg=; b=K0F5a1qwGANhpZx6Vic5aqHxDVxkpO7nTNT12ust7181RzM0kvMu1IYIpOwiozxwDr bRM0lYSTyz5LIK5Y3AvzWqf5AhSeNd/j9JPti8Id4Q2CjuAG2hmmREpmJE8Zh0uIntcC km6/rL4BBElSnTyYx2vUBvo+0VpLsJ4x0T5ro= Original-Received: by 10.180.83.97 with SMTP id p1mr20003183wiy.19.1330329868128; Mon, 27 Feb 2012 00:04:28 -0800 (PST) Original-Received: from thierry-MM061 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id s4sm43973017wiy.5.2012.02.27.00.04.26 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Feb 2012 00:04:27 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Mon, 27 Feb 2012 02:45:58 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57272 Archived-At: Stefan Monnier writes: >> I have modified files-equal-p and file-subdir-of-p to work with >> non--existing files, > > Calling files-equal-p on non-existing files makes no sense, so I don't > think we should support it (at least not until we have concrete > evidence that it is needed, at which point we can decide what we intend > it to mean). It is useful to handle e.g (copy-directory "~/test" "~/test/test1") where test1 is a non--existing directory. Actually a check is done once test1 is build and stop the loop, so this would avoid creating an unuseful new directory. We could give an optional arg noexist to files-equal-p. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997