From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#15910: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Date: Mon, 25 Nov 2013 09:54:32 -0500 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <87bo18351z.fsf@flea.lifelogs.com> References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385391254 10103 80.91.229.3 (25 Nov 2013 14:54:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Nov 2013 14:54:14 +0000 (UTC) Cc: 15965@debbugs.gnu.org, Kenjiro NAKAYAMA , 15966@debbugs.gnu.org, 15967@debbugs.gnu.org, 15910@debbugs.gnu.org To: Kenjiro NAKAYAMA Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 25 15:54:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VkxYI-0006lB-Qa for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2013 15:54:19 +0100 Original-Received: from localhost ([::1]:53140 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkxYI-0000rH-8l for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2013 09:54:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkxY8-0000q3-M8 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2013 09:54:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkxY2-0006gx-R1 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2013 09:54:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkxY2-0006gt-Mu for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2013 09:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VkxY2-0007Wp-12 for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2013 09:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2013 14:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15910 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15910-submit@debbugs.gnu.org id=B15910.138539123828929 (code B ref 15910); Mon, 25 Nov 2013 14:54:01 +0000 Original-Received: (at 15910) by debbugs.gnu.org; 25 Nov 2013 14:53:58 +0000 Original-Received: from localhost ([127.0.0.1]:43910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkxXx-0007WW-5p for submit@debbugs.gnu.org; Mon, 25 Nov 2013 09:53:57 -0500 Original-Received: from mail-qa0-f49.google.com ([209.85.216.49]:36144) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkxXk-0007VU-Kc for 15910@debbugs.gnu.org; Mon, 25 Nov 2013 09:53:50 -0500 Original-Received: by mail-qa0-f49.google.com with SMTP id ii20so6391396qab.1 for <15910@debbugs.gnu.org>; Mon, 25 Nov 2013 06:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=qWUNK7tujuvY1LeWael8BAImYMcDGKq1z4bF0sqq/HQ=; b=K+ruOlrRhxTtrsMfUMCmYSr6vdZxEl19MxXAaluBAvrXrfowd3t4mSU77UWUkhd3la qaIVtTCRbdrZMWqZA7iYZkhq6FbrlWrWhUdCusgW74ZAMwnY29uDu8qyS657txjexA9a EHKigiWVus+rMKNfk2P8DUBrCYX0tUcoPsMrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=qWUNK7tujuvY1LeWael8BAImYMcDGKq1z4bF0sqq/HQ=; b=IFrygoGOfxcW3aDizWyFvOZj+eInoem4vtpL1cWrclhWTCiz3Vr86YIbB6FucRA+ms 2jwqUu2WedELwojTSEU7QRNZmZS2lostQqyAb9rSZWLsync82d/0N85wEMJQ9Ko9WyZl q7RmEDFa9w73R9ev/uJGXj6wtp6VE48/yyhR6kNhOpShz8J7uYk/j8z2qDqlcNijcqeG WZKcldUhIBOhKxpxzCKhRJAXpjJzlOU4X0vdSiZVo2Nk+LklJLBTnfslb8+rGKjf2MTP ytY5fHV8f0xF0TTcqtukh6VUcNMjpK2pd28aRsBCWL5qEA3Mj8n4c6Uck8d63FTgUG3O 7AVQ== X-Gm-Message-State: ALoCoQloYxDr5ShfSo+vuHUqu8KS834WDd6s66qgXyFol160hORVkvmSOc1cXdnbX97/3xqBihI2 X-Received: by 10.229.182.69 with SMTP id cb5mr46240214qcb.19.1385391218892; Mon, 25 Nov 2013 06:53:38 -0800 (PST) Original-Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id b4sm8193641qai.7.2013.11.25.06.53.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2013 06:53:38 -0800 (PST) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Mon, 25 Nov 2013 00:15:52 +0900, Sun, 24 Nov 2013 23:41:44 +0900, Sun, 24 Nov 2013 23:12:47 +0900, Mon, 25 Nov 2013 00:57:33 +0900") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80948 Archived-At: Thank you for the patches. All of them are OK to go in IMO (and tiny changes). Could you consolidate them in a single patch with a ChangeLog please? It can wait for your eww history stack changes or can be submitted sooner. Thanks Ted On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA wrote: KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it KN> doesn't save current URL in eww-history. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA wrote: KN> eww should ask "yes or no" when add current page to bookmarks, since KN> only "b" key to add bookmarks is easy to mistake. KN> (My bookmarklist has amazingly increased.) KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA wrote: KN> eww should ask "yes or no" before quitting, since only "q" key to quit is KN> easy to mistake. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-quit): ask confirmation before quitting eww On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA wrote: KN> Thank you for your review, Ted, Masatake. KN> OK, I try to revise the patch to add eww own history stack. KN> And I put ChangeLog entry to my report next time.