From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenjiro NAKAYAMA Newsgroups: gmane.emacs.bugs Subject: bug#16236: 24.3.50; [PATCH] eww: Don't set local value. Date: Tue, 24 Dec 2013 16:37:50 +0900 Message-ID: <87bo06n1gx.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387870761 17787 80.91.229.3 (24 Dec 2013 07:39:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Dec 2013 07:39:21 +0000 (UTC) To: 16236@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 24 08:39:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VvMaK-0005Vl-0o for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2013 08:39:24 +0100 Original-Received: from localhost ([::1]:36930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMaJ-0000lG-J0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2013 02:39:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMa7-0000d8-Ne for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:39:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvMZz-00010c-7c for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:39:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMZz-00010X-4H for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VvMZy-0000X0-G3 for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2013 07:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13878707141991 (code B ref -1); Tue, 24 Dec 2013 07:39:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Dec 2013 07:38:34 +0000 Original-Received: from localhost ([127.0.0.1]:37544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvMZU-0000W2-VK for submit@debbugs.gnu.org; Tue, 24 Dec 2013 02:38:33 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54995) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvMZP-0000Vr-KE for submit@debbugs.gnu.org; Tue, 24 Dec 2013 02:38:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvMZH-0000tS-4q for submit@debbugs.gnu.org; Tue, 24 Dec 2013 02:38:27 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:51774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMZH-0000tO-1T for submit@debbugs.gnu.org; Tue, 24 Dec 2013 02:38:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMZ8-0000V3-JV for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:38:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvMZ0-0000pm-4s for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:38:10 -0500 Original-Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:39100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMYz-0000pi-Tv for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:38:02 -0500 Original-Received: by mail-pd0-f180.google.com with SMTP id q10so6011004pdj.25 for ; Mon, 23 Dec 2013 23:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:from:to:subject:date:message-id:mime-version :content-type; bh=sx69leuzTIfLU2ilupint8Y4rJibAJKprqwoDoyjfXc=; b=LT+IWlLpFJ/1UjWLWUHSREEFC3gXE8ZWPkATjqdsZO2FukkmljT7XB+teQ4F7eKk/h 8EkllXg95xwFUf/nEdl7nbWAO0aWvqbCtoQUBpWURjAfPWAmq/DWBulXl2KALk2WiLQ6 16i6/XAphwK2bgAAXIYdqZ45J8DCcwMsJVpruF9qiGAvUoD/PFHs4As9qqOShY6vQIQ3 lIzrJHxl/ZibGfnb7RlGaPbZ2Ch8LOQqtj/quFnKiv8dRl69sJZ7Vh4eJcqklAUn3/FY /tx4xZL7Apm4VaNCZ2mSOyjFnq71UAWe+EKl6Rm2nwHiWAEqJijwX498B93W3ZmVm0wF nsFA== X-Received: by 10.68.29.4 with SMTP id f4mr30761483pbh.85.1387870680869; Mon, 23 Dec 2013 23:38:00 -0800 (PST) Original-Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-u1.redhat.com. [66.187.238.11]) by mx.google.com with ESMTPSA id yi10sm51627056pab.8.2013.12.23.23.37.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Dec 2013 23:37:59 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82494 Archived-At: This report includes a patch to the bug. Please, review and install it to the official tree if appreciated. Now, eww-history-mode does not work well. eww-history and eww-history-position should not be local value, since eww will use them in eww-history-mode. Or, just deleting two lines will work well. - (setq-local eww-history nil) - (setq-local eww-history-position 0) Kenjiro Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-mode): Don't set local value to eww-history and eww-history-position. Signed-off-by: Kenjiro NAKAYAMA --- lisp/net/eww.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 89a7eb9..fdf5aca 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -467,8 +467,8 @@ word(s) will be searched for via `eww-search-prefix'." (setq-local eww-current-source nil) (setq-local browse-url-browser-function 'eww-browse-url) (setq-local after-change-functions 'eww-process-text-input) - (setq-local eww-history nil) - (setq-local eww-history-position 0) + (setq eww-history nil) + (setq eww-history-position 0) (when (boundp 'tool-bar-map) (setq-local tool-bar-map eww-tool-bar-map)) (buffer-disable-undo) -- 1.8.3.1 Kenjiro NAKAYAMA