unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
To: 16277@debbugs.gnu.org
Subject: bug#16277: 24.3.50; [PATCH] eww: Cannot use double/single quote for search words.
Date: Sat, 28 Dec 2013 20:36:55 +0900	[thread overview]
Message-ID: <87bo01ryug.fsf@dhcp-193-97.nrt.redhat.com> (raw)

This report includes a patch to the bug. Please, review and install it
to the official tree if appreciated.

* Reproduce the bug.
step 1. M-x eww
step 2. input "eww.el" to mini-buffer. (eg. sEnter URL or keywords: "eww.el")
(Result)-> Error will occure (eg. error "eww.el/80 Name or service not known").

The cause is that eww cannot treat double quote or single quote.
(Therefore, eww cannot search the word which has "." dot like eww.el.)

I send the patch to fix it.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>

        * net/eww.el (eww):  Support single/double quote for search.

---
 lisp/net/eww.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 25309d1..578032b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -157,8 +157,9 @@ word(s) will be searched for via `eww-search-prefix'."
          (user-error "FTP is not supported."))
         (t
          (if (and (= (length (split-string url)) 1)
-                  (or (> (length (split-string url "\\.")) 1)
-                      (string-match eww-local-regex url)))
+                 (or (and (not (string-match-p "\\`[\"\'].*[\"\']\\'" url))
+                          (> (length (split-string url "\\.")) 1))
+                     (string-match eww-local-regex url)))
              (progn
                (unless (string-match-p "\\`[a-zA-Z][-a-zA-Z0-9+.]*://" url)
                  (setq url (concat "http://" url)))
-- 
1.8.3.1

Regards,

Kenjiro





             reply	other threads:[~2013-12-28 11:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-28 11:36 Kenjiro NAKAYAMA [this message]
2014-01-05  9:25 ` bug#16277: 24.3.50; [PATCH] eww: Cannot use double/single quote for search words Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bo01ryug.fsf@dhcp-193-97.nrt.redhat.com \
    --to=nakayamakenjiro@gmail.com \
    --cc=16277@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).