From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.bugs Subject: bug#16313: 24.3; package-delete does not update package-alist Date: Wed, 08 Jan 2014 00:08:09 +0100 Message-ID: <87bnzncrvq.fsf@bzg.ath.cx> References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389136155 5780 80.91.229.3 (7 Jan 2014 23:09:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Jan 2014 23:09:15 +0000 (UTC) Cc: Tom Tromey , 16313@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 08 00:09:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0flu-0007eT-Nl for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Jan 2014 00:09:18 +0100 Original-Received: from localhost ([::1]:43951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0flu-0005Yj-76 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2014 18:09:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0flk-0005NO-K8 for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 18:09:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0fle-0000gr-P9 for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 18:09:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0fle-0000gn-M8 for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 18:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W0fle-0007gP-Ff for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2014 18:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Bastien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2014 23:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 16313-submit@debbugs.gnu.org id=B16313.138913609829469 (code B ref 16313); Tue, 07 Jan 2014 23:09:02 +0000 Original-Received: (at 16313) by debbugs.gnu.org; 7 Jan 2014 23:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:41653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0fkw-0007fD-8E for submit@debbugs.gnu.org; Tue, 07 Jan 2014 18:08:18 -0500 Original-Received: from mail-we0-f175.google.com ([74.125.82.175]:39291) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0fkt-0007f2-8u for 16313@debbugs.gnu.org; Tue, 07 Jan 2014 18:08:16 -0500 Original-Received: by mail-we0-f175.google.com with SMTP id w62so773885wes.20 for <16313@debbugs.gnu.org>; Tue, 07 Jan 2014 15:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=SKLvC0HUrFu7nbbtQVODBWrrcU/Jwc4TF1Y0FeZFyaU=; b=Bi3rRIf5YArtROIu6AGXk1hTBROW4tt/comLtgKMKDRxLsBi0ZlHBC0ffxbS0/s7hn Fw91AboeOeDGFllj+pV6fLDaNGamaMIl/tPWyFQBc6Qri/kKCJwiiCRbw33r90fRuXLq 4oavK2zavhZPCPF08QQRd70Rz9QJSj9kmQ4W+Da06wW9aj6btfPdk4qnmZszvOvo0ln1 bbj8rAdYaG1WcIrnBEdyXltOKVaBvzEyDYPpkRSHNRyi9mk+X9CwF8yOHQNVm1nPdvZm r8ElBAWQcEBlmczbAisyVgEoFucpPt1KsSCyQtj2adej2k1stBWKLnpBn+bpyj3JZCJK QI/Q== X-Received: by 10.194.178.135 with SMTP id cy7mr24655297wjc.21.1389136094456; Tue, 07 Jan 2014 15:08:14 -0800 (PST) Original-Received: from bzg.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPSA id po3sm46639489wjc.3.2014.01.07.15.08.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 15:08:13 -0800 (PST) Original-Received: by bzg.localdomain (Postfix, from userid 1000) id A7E091C20717; Wed, 8 Jan 2014 00:08:09 +0100 (CET) In-Reply-To: (Glenn Morris's message of "Tue, 07 Jan 2014 17:08:36 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83147 Archived-At: Glenn Morris writes: > Bastien Guerry wrote: > >> Still, package-delete did not cleanly delete the package from >> package-alist, only its description. > > _Should_ it remove the entire entry? It's not obvious to me, given eg > the way package-installed-p works. Tom may confirm or infirm this, but I think it should. The fact that package-installed-p checks for the description seems due to the min-version parameter, and indeed, IMO the function should be first checking for the package name before its description. >> I pushed a fix to cleanly remove the package occurrence. > > - (delete pkg-desc (assq name package-alist))) > + (delete (delete pkg-desc (assq name package-alist)) package-alist)) > > That doesn't work for the first item in the list. > Why not the more obvious > > (setq package-alist (delete (assq name package-alist) package-alist)) No reason, the above is better. Should I fix this or wait for Tom's feedback? -- Bastien