bug#18962: 24.3.94; python eldoc setup code: wrong str test

bug#18962: 24.3.94; python eldoc setup code: wrong str test

[carlosjosepita]

The following test (taken from python-eldoc-setup-code) is wrong, since
it will accept any object that has an attribute called 'startswith', not
necessarilly a string or code object (as required by eval):

        if hasattr(obj, 'startswith'):
            obj = eval(obj, globals())

---------------------------------



In GNU Emacs 24.3.94.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.12.2)
 of 2014-10-16 on carlos-jampp
Windowing system distributor `The X.Org Foundation', version 11.0.11600000
Configured using:
 `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --with-x-toolkit=gtk3 --with-xft
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
 --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'

Important settings:
  value of $LANG: C
  locale-coding-system: nil

Major mode: Custom

Minor modes in effect:
  show-paren-mode: t
  shell-dirtrack-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  ido-ubiquitous-mode: t
  ido-everywhere: t
  winner-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <up> 
<up> <up> <up> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <up> 
<up> <up> <S-right> i m p o r t SPC i n s p e <tab> 
c t <return> i n s p e <tab> . <tab> g e t <tab> s 
<tab> ( + + <backspace> <backspace> _ _ P Y <tab> D 
<tab> ( <backspace> ) <return> <S-left> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <down> <down> <down> <down> C-s s t 
a r t s w C-s C-s <up> <up> <up> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down-mouse-1> 
<mouse-1> <down> <up> <up> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <up> <up> <up> <up> 
<up> <up> C-a C-SPC <down> <down> M-w <down> <down> 
<up> C-s s e t u p SPC c o <left> <down> <down> <down> 
<down> <down> <up> <up> <up> <up> <up> C-a <return> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <up> 
<up> <up> <return> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
C-s C-s <left> C-a <right> <left> <return> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> M-c C-g M-x 
r e p o r <tab> <return>

Recent messages:
Quit
End of buffer [9 times]
Mark saved where search started
Quit
No match
Making completion list... [3 times]
Mark saved where search started
Mark set
Mark saved where search started [2 times]
widget-before-change: Text is read-only: "Attempt to change text outside editable field"
Quit

Load-path shadows:
~/.emacs.d/lisp/rmail hides /usr/share/emacs/24.3.94/lisp/mail/rmail

Features:
(shadow sort gnus-util mail-extr emacsbug message idna rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils misearch multi-isearch pp cus-edit cus-start
cus-load wid-edit vc-git python json server paredit edmacro kmacro paren
cl-macs ob-python ob-R org byte-opt bytecomp byte-compile cconv
org-macro org-footnote org-pcomplete org-list org-faces org-entities
noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle
org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval
org-compat org-macs org-loaddefs find-func cal-menu calendar
cal-loaddefs ess-toolbar ess-mouse mouseme thingatpt browse-url ess-menu
ess-swv ess-noweb ess-noweb-font-lock-mode ess-bugs-l essd-els ess-sas-d
ess-sas-l ess-sas-a shell pcomplete ess-sta-d ess-sta-l cc-vars cc-defs
make-regexp ess-sp6-d ess-sp3-d ess-julia ess-r-d compile ess-tracebug
format-spec ess-roxy hideshow ess-help ess-developer ess-r-args eldoc
ess-s-l ess ess-inf comint ansi-color ess-mode ess-noweb-mode ess-utils
time-date ess-custom executable ess-compat ess-site yasnippet help-mode
cl gv ido-ubiquitous cl-loaddefs cl-lib advice help-fns imenu-anywhere
imenu ido windmove winner ring info easymenu package epg-config
wombat-theme tooltip electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
gfilenotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 255413 31287)
 (symbols 48 34750 0)
 (miscs 40 1843 1307)
 (strings 32 64264 12709)
 (string-bytes 1 1904291)
 (vectors 16 33810)
 (vector-slots 8 1414795 14406)
 (floats 8 622 276)
 (intervals 56 1466 439)
 (buffers 960 19)
 (heap 1024 54735 1274))

bug#18962: 24.3.94; python eldoc setup code: wrong str test

[Fabián Ezequiel Gallina]

Fixed on master at 9ae5396

bug#18962: 24.3.94; python eldoc setup code: wrong str test

[Stefan Monnier]

> Fixed on master at 9ae5396

Could you install bug fixes on the `emacs-24' branch instead (unless
they aren't applicable there, of course)?


        Stefan

bug#18962: 24.3.94; python eldoc setup code: wrong str test

[Stefan Monnier]

>> Fixed on master at 9ae5396
> Could you install bug fixes on the `emacs-24' branch instead (unless
> they aren't applicable there, of course)?

Hmm... I see you've done that for the other fixes, so I assume this one
was not applicable to emacs-24, sorry for the noise,


        Stefan

bug#18962: 24.3.94; python eldoc setup code: wrong str test

[Fabián Ezequiel Gallina]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> Fixed on master at 9ae5396
>> Could you install bug fixes on the `emacs-24' branch instead (unless
>> they aren't applicable there, of course)?
>
> Hmm... I see you've done that for the other fixes, so I assume this one
> was not applicable to emacs-24, sorry for the noise,
>

As soon as I pushed this in the master branch I thought about it and
then I decided the improvement is not worth even the process of
cherry-picking it.

I'd be careful next time, luckely this wasn't a big deal.


Thanks for the warning though,
Fabián