From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree Date: Fri, 21 Nov 2014 21:04:19 +0100 Message-ID: <87bno0mibg.fsf@rosalinde.fritz.box> References: <87lhn7s522.fsf@rosalinde.fritz.box> <83lhn789tq.fsf@gnu.org> <87h9xvruan.fsf@rosalinde.fritz.box> <83tx1v6mur.fsf@gnu.org> <87a93nrlql.fsf@rosalinde.fritz.box> <83lhn76iex.fsf@gnu.org> <8761easv3s.fsf@rosalinde.fritz.box> <87r3wytcaa.fsf@rosalinde.fritz.box> <83vbm96dxs.fsf@gnu.org> <87oas0n8sr.fsf@rosalinde.fritz.box> <8361e84yxb.fsf@gnu.org> <87fvdcmpeg.fsf@rosalinde.fritz.box> <83bno0tjjc.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416600324 12030 80.91.229.3 (21 Nov 2014 20:05:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2014 20:05:24 +0000 (UTC) Cc: paul@tilk.co, 19102@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 21 21:05:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XruSC-0000zu-AC for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 21:05:16 +0100 Original-Received: from localhost ([::1]:42316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XruSB-0006JE-JG for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Nov 2014 15:05:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XruS3-0006Gi-VC for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 15:05:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XruRy-0001nw-J0 for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 15:05:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XruRy-0001nJ-Dq for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 15:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XruRy-0005uO-4Z for bug-gnu-emacs@gnu.org; Fri, 21 Nov 2014 15:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Nov 2014 20:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19102-submit@debbugs.gnu.org id=B19102.141660028422687 (code B ref 19102); Fri, 21 Nov 2014 20:05:02 +0000 Original-Received: (at 19102) by debbugs.gnu.org; 21 Nov 2014 20:04:44 +0000 Original-Received: from localhost ([127.0.0.1]:41254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XruRg-0005tq-5j for submit@debbugs.gnu.org; Fri, 21 Nov 2014 15:04:44 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:51301) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XruRe-0005te-Eg for 19102@debbugs.gnu.org; Fri, 21 Nov 2014 15:04:43 -0500 Original-Received: from rosalinde.fritz.box ([89.245.122.145]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Mg42v-1XdOMd02kf-00NVHi; Fri, 21 Nov 2014 21:04:22 +0100 In-Reply-To: <83bno0tjjc.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Nov 2014 21:56:07 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:HKUTzwQQUTLJOtE3Y3WVMHt6M9O4udChTM/PkTOhqAQlOl9Xt+U vZGoDDrbUX5QgBLQQnJ7r426badk18khXcttKf4v6uNAKPV6VXPsbwItwl2DJIkzsvSpCTX GsVG9KgEyK490eYZ9FLIjnG7ZLOCzOzgNT9krBBwjYclni47NFH1EHPVxXpwN5XxQgfhbI/ RLFdCOHqImujRxyL9uc/g== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96407 On Fri, 21 Nov 2014 21:56:07 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: paul@tilk.co, 19102@debbugs.gnu.org >> Date: Fri, 21 Nov 2014 18:31:19 +0100 >> >> >> But can C-g really take effect here? >> >> There is no place in the function where execution halts to wait for user >> >> feedback. >> > >> > C-g sets a flag that is checked by evaluation. >> >> I don't understand how this could result in C-g taking effect before the >> function finishes; could you elaborate? > > C-g sets a "quit" flag. When Lisp evaluation takes place and the quit > flag is set, the Lisp interpreter throws to top-level, thus > interrupting whatever function was running. Thanks for the explanation. >> I think that, once the non-file buffer case is taken into account (and >> not doing means moving a subtree can corrupt the outline by putting two >> headers on the same line), the cleanest fix is basically the one Paul >> Rankin proposed in his last post. I've attached it as a diff against >> emacs-24, where I assume the fix should be committed (I added a comment >> and tweaked the function Paul posted to avoid irrelevant changes to the >> current code, and also restricted the error handling by making it a >> user-error and having it signal only when the user attempts to move over >> a higher outline level, avoiding an inappropriate message at bob or >> eob). Does this patch qualify as a tiny change, or does Paul have a >> copyright assignment on file (I don't have access to the file)? > > I don't see his assignment. IMO, this patch is borderline wrt being > "tiny"; I'll let Stefan judge. Ok. Steve Berman